Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <5d93f726-bd43-20ad-5057-1de575809cde@intel.com>
Date:   Mon, 25 Sep 2023 16:25:54 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 4/8] x86/resctrl: Add node-scope to the options for
 feature scope
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, Fenghua Yu <fenghua.yu@intel.com>,
        "Peter Newman" <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-5-tony.luck@intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230829234426.64421-5-tony.luck@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmpzS0twaVU5d0NzQjVvS2VTMEN4Um5oMUd6UC9Icy9XMUJzRGtEOUFZWW1M?=
 =?utf-8?B?U2ZpZlhpSUtsQURtWWlhVjVCaVJjWGYyUTZSM3AybGVZTUJsME9WeDB1M2FS?=
 =?utf-8?B?c25Ycll0cVcyL0ZXVFRqZUFFa0ZTdWw5RCtteG1HUmlUcy9uekJaSktNKzRh?=
 =?utf-8?B?akcvTWVRa0JVNXhxSzlvdXNWOUJrWXRSTGg4c3d4NG9iNTVpS3p2eER0UkRV?=
 =?utf-8?B?b3Jsd3lBV0dWYWliRXllTEVxMlBTOS84RmVkcGJDZnNQRW5lUjRTeXd1ZjdN?=
 =?utf-8?B?UXZrRjlTcEJnWVJ6cHViRmd2bG5DWFBZZkJlU2JYOWNUcTBFR1puNzU3SDJx?=
 =?utf-8?B?cUVzZnVkNnhjVGdjNXJLZDlyaDdhSVhtT0FPeUlqVXpvN2R3eGlGSmtUUmRy?=
 =?utf-8?B?SG52UVRBRWJUN0o3ckxPanF5cVZIK3lQc2habStBaDVtQmtDT0g2UU5oRUEx?=
 =?utf-8?B?UUlZSkNlbTJub3NVdGs2TFJnbUNLeVRUZ0d4KzhBMUlZSTdnZS8yR0FDZzNs?=
 =?utf-8?B?YjlyNUJjbmVOUUVyN1JVMEVIYkNRZEFjTjlSbDFreGpUQTRadkN2Q1gveFBr?=
 =?utf-8?B?UUxWa2VBc2ZEMzVtYThzUHNBZlRMSkp4RnBJSEJVbW44WGRVeWdWdWNRZlNS?=
 =?utf-8?B?NzZqeDA0Y3VrY050UFJzVEgzMEtuOG8yd29jUDZ2QUxnbkFXV1FzUjFYUG85?=
 =?utf-8?B?ZGJxaXh1TnFmU3lFU1A2WUo5aVN5NXk3ZThhWlk1M3NqSStSSlU3aDBpcjVM?=
 =?utf-8?B?b3ZxZGpoWU5qdzVGSFZSUUxwYmdmTWUvYTkveWhwNDU3SzlWaWVISFRRRFQ5?=
 =?utf-8?B?OFYrWW9nSjF1M3kwdE9SY3VpRm1hZXBsaXNwdjc4MXpPQ1JvR3lvYnFUeE05?=
 =?utf-8?B?VXpYaWJKVForOHorY3NoUzJ3ZkxVejBOOGVkY1VBbDVUVUU1bm5Za0x1UXdG?=
 =?utf-8?B?WGZqUGQ2eWJ4eTVSVGdDOFBFbGZEUEZ1ZEw1blJjRVh6c01SY3NlNXBMNi9x?=
 =?utf-8?B?eEd0eUtuNWVibzBkUEp4dG43U2ptbmFkdENuSzVxZ0RJWTNhZ084c0ZZMHpR?=
 =?utf-8?B?R3h2TnBHdWxQZFg4WkVXckZubW1iWG5PamE5Q0tXeUwrTHYxREFweklVUWhv?=
 =?utf-8?B?b3h4OTJ4MkIzTnlCcE9yVkZHSlU0dDBEU3Mvc0dOU0tib3dPNTYzUkt2d2Jo?=
 =?utf-8?B?bm5CSXVVaEU1NTVqM3VPQjVJUEFzTlFiR1lhS2NyczVrYUhZaXVKcHRZU0JW?=
 =?utf-8?B?enFCUGJPOVF5ckdSRXJ4b25aQU5OQmNZOTlvQ0ZaTXlqNWYrdUl4Mk11YjMw?=
 =?utf-8?B?b0JKYzJFaWtBZWVja0UzOENvR1hPb1dEeVBZa29Oa01kd2R6MFBGL3VYK1Jn?=
 =?utf-8?B?Wlg1MHBMTCtJRWpUVXlzb1NIb3pCaFhveDZIOURCanZUMlVGNHRIMTlTTEVx?=
 =?utf-8?B?WUNYbklnMC83NzAyWU85V25idUVOSFdKaWJrVTN5dnJrM25HMUM0RDNqOXR4?=
 =?utf-8?B?SXZSTzcvVkZhRWhzQUdoT25iR0tlSkhoZkxkaXM1RkdaMHJENVZaUXdXMUZ5?=
 =?utf-8?B?d3YzdGhQOGs3akFZSlZTSjZGZ0JZQTlRL0xTM3pick1TK2ZoY3JKTHJkREkx?=
 =?utf-8?B?aE8zck4zQ2s1QWtUT1pvSjlCc3NrUERJUHArUTdXeXpuN1A4ZzNLTHMvcW9h?=
 =?utf-8?B?dWxEcHZhd1F2cUF3ZVVYWWMzUWVybzhna0dsMkZRSHdkZSt3dXlmdi9zU2lV?=
 =?utf-8?B?U2lidlcwZHNQamtlZ1d5b09oZWdHamQrYlYxT3JvV2tnVW1ncC9jQWNwOEJV?=
 =?utf-8?B?L2tCM0x2d2E3YlB5VmR5WGJneUFJVVZCY1BNNFNuVm1SanoxTGg1VnE4R2Uz?=
 =?utf-8?B?TkFUMGdoektCbjJuaDBsaStWVjVPODlyNUJKODlWQjJnWDZaZXB4MEFVb1ZH?=
 =?utf-8?B?czZoSkFPMnZlaGwvS3U2SDdhekNtUkhjOG56d0c5Y1BPQzdnZnRNMUQ5R25V?=
 =?utf-8?B?NlFEZjNrdzFXMlVLYi9PZ2dyR0Y5b3JkMVRvc2l3UHhianBaVG50UDhlM3gx?=
 =?utf-8?B?eHUraWFBa1FEWmlRV0hwR2VWOGRCMDc5aGROQ3gyTVBtN3VUc1NRTWtxSXVQ?=
 =?utf-8?B?ZDMwSkNNdXJmYWNpaTk2Z3JscmtCMTIvZzZMRmczTThLaGltS05WQWVVL2Jz?=
 =?utf-8?B?MFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c0adc46-9c57-4c90-77bc-08dbbe1ec56c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 23:25:57.4698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b9//DYgDJ5vnZbBPKyCoccp43XamaMKdGLHd+0NYQBzpSlx8Rnucypls71k4POcv/wMZ8QKy85UaSAeHTPjg+Nl2n2g62uWBO69FdP699rU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8033
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 25 Sep 2023 16:26:13 -0700 (PDT)

Hi Tony,

On 8/29/2023 4:44 PM, Tony Luck wrote:
> Currently supported resctrl features are all domain scoped the same as the
> scope of the L2 or L3 caches.

fyi ... this patch series seems to use the terms "resctrl feature"
and "resctrl resource" interchangeably and it is not always clear
if the terms mean something different.

> 
> Add "node" as a new option for domain scope.

Could the commit message please get a snippet about what "node"
represents and why this new scope is needed?

> Signed-off-by: Tony Luck <tony.luck@intel.com>
> ---
>  include/linux/resctrl.h            | 1 +
>  arch/x86/kernel/cpu/resctrl/core.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 08382548571e..f55cf7afd4eb 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -163,6 +163,7 @@ struct resctrl_schema;
>  enum resctrl_scope {
>  	RESCTRL_L3_CACHE,
>  	RESCTRL_L2_CACHE,
> +	RESCTRL_NODE,
>  };
>  
>  /**
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 3e08aa04a7ff..9fcc264fac6c 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -514,6 +514,8 @@ static int get_domain_id_from_scope(int cpu, enum resctrl_scope scope)
>  		return get_cpu_cacheinfo_id(cpu, 3);
>  	case RESCTRL_L2_CACHE:
>  		return get_cpu_cacheinfo_id(cpu, 2);
> +	case RESCTRL_NODE:
> +		return cpu_to_node(cpu);
>  	default:
>  		WARN_ON_ONCE(1);
>  		break;


Reinette