Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     Arnd Bergmann <arnd@kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        "Kubalewski, Arkadiusz" <arkadiusz.kubalewski@intel.com>,
        "Michalik, Michal" <michal.michalik@intel.com>,
        Jiri Pirko <jiri@resnulli.us>,
        "Hay, Joshua A" <joshua.a.hay@intel.com>,
        Vadim Fedorenko <vadim.fedorenko@linux.dev>,
        "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] ice: require PTP clock for building
Thread-Topic: [PATCH] ice: require PTP clock for building
Thread-Index: AQHZ78jGgTby0iFDvU+ADGoYgeC6t7AsFAmw
Date:   Mon, 25 Sep 2023 21:49:01 +0000
Message-ID: <CO1PR11MB50895BBE115A20B1A1EEC603D6FCA@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20230925155538.526317-1-arnd@kernel.org>
In-Reply-To: <20230925155538.526317-1-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MADUfIeB4V5T/ccJhNLMRTKuhSz8/6InGLZX/hvZaX1eEk9C5iTaAgp+B/Vw?=
 =?us-ascii?Q?T/F6od2XKVVbeNxLh2Sp2xXEGseokTAN08AEFEKut3Q7+x+Ywfu2ogzB2oVr?=
 =?us-ascii?Q?zD5bHw919yyT9iDEMIotu8UcPg6faMYgrTsyJsEtYPMf6ks2wy0QAKfkH3Mx?=
 =?us-ascii?Q?0IjQw9N8O4Ru+ghURZjXgfluetOvXOA62Ssqm6f15M9OqN6nuANkRMb6A+v6?=
 =?us-ascii?Q?LNNJV/4i8by8Yvk3B7DMMZXdlw+P1lWgFbNzGjXBc8sGHT2af1WWuP30Gm2l?=
 =?us-ascii?Q?m3nGQQNVrtU0BMcjXieuidUPTa+MTaN3qXVwXzcXF+w4/Tu6RWMDmEe+TrGb?=
 =?us-ascii?Q?/4Y3ithzmJhUOA0PQWyijBgj6pZAZDcuzkGyp5XR115sleHCrgdSYulFsumf?=
 =?us-ascii?Q?Gj4yH/zuJNNDy6DMBR1H+nNYgUNO8KOSM7ZZZWFEFnbV60ZuK5LhdvqTwg/B?=
 =?us-ascii?Q?aNhlVoQQ55i0KJtsd3zptF5jqhaGUBK8Vrv1cUB4CkohCKCvDnpaNZD7K7ZH?=
 =?us-ascii?Q?H6pWXlUT9/btgbM4k1dyIzb8UB+Z1CyN1ETu0CVAJ750pT3E7w9er9PIi6pq?=
 =?us-ascii?Q?bdk3PbdwRlGwX5dHt8VIm1ulzpO9L0e1xw9++TTo2dywUuPDaBoGV5bSfWtI?=
 =?us-ascii?Q?MDttVad1owdSlhL9L23ESLH/i426+NxNRlW02rwCT8b0A59UepNPX6nXpumy?=
 =?us-ascii?Q?eHc6ueMrjGZGG4NyqA/I09R6YiIFnitY3CSUoral/twn+9AXlHIlbPPa5jQe?=
 =?us-ascii?Q?RRGP17CfLa4xOCRtPTc0+hvWALepRM7i3/fWJfhIVfZI3M49F2E8Q9hBIRqK?=
 =?us-ascii?Q?ZImNCloQztG6l7jFImbxrCeZUDZ182lv9dds60CcHy0+0aF7Y5oM39oT05QX?=
 =?us-ascii?Q?9WzeAXVuQvgZmNlYeSDyBng04Ow0YWVWkpA0nvOE/VeY0sIpZZzvkajRBs7h?=
 =?us-ascii?Q?GAnpeadf//KrCBYpRKw9bTfyZf/6wX8OQZyo22cT9yminrFoHPBY4J+zgSb5?=
 =?us-ascii?Q?IM/noDaI4nwWiqLLYYOxxZa2SPG3Wzq9wwrhQD4q6xivygq9xtI/CfAYSSJg?=
 =?us-ascii?Q?kvtPA+4HKe6w/QQMwxETMT5yuenoVylF/wBMpWFF7O9qbu9zOKknqyofowWf?=
 =?us-ascii?Q?peB7jyNjtFUXVdcizBGRlw4il1b493ug0Gh5WC0/g/C8bqAs5wM6WSKnyFmB?=
 =?us-ascii?Q?IYo7sLNYI5LZ5oHPGriEjr2QU5oZuizixdvoWVF1o5r8S+vaOx21M7JQDmIl?=
 =?us-ascii?Q?rkwc8sKvBCRIC81LNHR2OhFduTukB4wHp/+eCjPpw6mb7GTEP8aEV4WF1E2/?=
 =?us-ascii?Q?PRqc4Qi4XEzGnS6eD+rXx/8vnaBNa/ARWRpn2JtJq04hjErnKnQm6l68sSsy?=
 =?us-ascii?Q?qT3pVqLXB13wY5qBt26GroGoSRO39knhtjF+YJK6pmECGLrEh2sqKgLYlfrB?=
 =?us-ascii?Q?MaMuFETHkcqjNopgI9MoHy6XQrz1qAOOASrR597D6VV9RuWOgyrLY2SK8I50?=
 =?us-ascii?Q?RclTxhqh2uKfCbztHcaiR0E3n1gMw25XznXs2opWJcge8IZCkki//GdnExs9?=
 =?us-ascii?Q?2oHO3weR9wGPLd1vaoDgEYSKgOKDx0EcWyw//bGp?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 98cafa83-5047-4006-e026-08dbbe113aa3
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Sep 2023 21:49:01.0394
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9frKj0mLNq29OUU/0Ay0nrh3YAJIT8kH9BJ3XhbWUWp8rjAojmgH+CJJiQK/oRHrA7nICTq7+A+TLS5Hq6iFSvxAeMa1Bk5bl9gW0Mdsarg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB8063
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 25 Sep 2023 14:49:16 -0700 (PDT)


> -----Original Message-----
> From: Arnd Bergmann <arnd@kernel.org>
> Sent: Monday, September 25, 2023 8:55 AM
> To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L
> <anthony.l.nguyen@intel.com>
> Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>;
> Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Pao=
lo
> Abeni <pabeni@redhat.com>; Kubalewski, Arkadiusz
> <arkadiusz.kubalewski@intel.com>; Michalik, Michal
> <michal.michalik@intel.com>; Jiri Pirko <jiri@resnulli.us>; Keller, Jacob=
 E
> <jacob.e.keller@intel.com>; Hay, Joshua A <joshua.a.hay@intel.com>; Vadim
> Fedorenko <vadim.fedorenko@linux.dev>; intel-wired-lan@lists.osuosl.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] ice: require PTP clock for building
>=20
> From: Arnd Bergmann <arnd@arndb.de>
>=20
> A previous fix added PTP as an optional dependency, which was correct as
> of commit 87758511075ec ("igc: fix build errors for PTP"), but this
> has recently changed with the PTP code getting more deeply integrated
> into the ICE driver.
>=20
> Trying to build ICE when PTP is disabled results in this internal link fa=
ilure
> as the local functions are left out of the driver:
>=20
> ERROR: modpost: "ice_is_clock_mux_present_e810t"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_is_phy_rclk_present"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_name" [drivers/net/ethernet/intel/ice/ic=
e.ko]
> undefined!
> ERROR: modpost: "ice_get_cgu_state" [drivers/net/ethernet/intel/ice/ice.k=
o]
> undefined!
> ERROR: modpost: "ice_is_cgu_present" [drivers/net/ethernet/intel/ice/ice.=
ko]
> undefined!
> ERROR: modpost: "ice_get_cgu_rclk_pin_info"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_type" [drivers/net/ethernet/intel/ice/ic=
e.ko]
> undefined!
> ERROR: modpost: "ice_cgu_get_pin_freq_supp"
> [drivers/net/ethernet/intel/ice/ice.ko] undefined!
>=20
> I tried rearranging the code to allow building it again, but this was get=
ting
> too complicated for an outsider, so just enforce the dependency to fix ra=
ndconfig
> builds again, until someone wants to clean this up again.
>=20
> In practice, any configuration that includes this driver is also going to
> want PTP clocks anyway.
>=20
> Fixes: 8a3a565ff210a ("ice: add admin commands to access cgu configuratio=
n")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


There are a couple of other fixes already posted including the one I posted=
 last week:

https://lore.kernel.org/netdev/20230921000633.1238097-1-jacob.e.keller@inte=
l.com/

My method keeps the PTP dependency optional and instead disables the featur=
es that required PTP.

Thanks,
Jake

> ---
>  drivers/net/ethernet/intel/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/in=
tel/Kconfig
> index e6684f3cc0ce0..c452ecf89b984 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -278,7 +278,7 @@ config ICE
>  	tristate "Intel(R) Ethernet Connection E800 Series Support"
>  	default n
>  	depends on PCI_MSI
> -	depends on PTP_1588_CLOCK_OPTIONAL
> +	depends on PTP_1588_CLOCK
>  	depends on GNSS || GNSS =3D n
>  	select AUXILIARY_BUS
>  	select DIMLIB
> --
> 2.39.2
>=20