Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Tue, 26 Sep 2023 08:05:07 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     huangli05 <huangli05@inspur.com>,
        Greg KH <gregkh@linuxfoundation.org>
Cc:     <osmtendev@gmail.com>, <speakup@linux-speakup.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] staging: speakup: Remove repeated word in comments
Message-ID: <ZRIuQ65mCABdhKLk@debian.me>
References: <20230925054559.3857-1-huangli05@inspur.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Px7V2FwQOhhdPJkC"
Content-Disposition: inline
In-Reply-To: <20230925054559.3857-1-huangli05@inspur.com>
Precedence: bulk


--Px7V2FwQOhhdPJkC
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Sep 25, 2023 at 01:45:59PM +0800, huangli05 wrote:
> Remove the repeated word "the" in comments.
>=20
> Signed-off-by: huangli05 <huangli05@inspur.com>
> ---
>  drivers/accessibility/speakup/speakup_soft.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/acces=
sibility/speakup/speakup_soft.c
> index 6d446824677b..6549bfb96e7f 100644
> --- a/drivers/accessibility/speakup/speakup_soft.c
> +++ b/drivers/accessibility/speakup/speakup_soft.c
> @@ -446,7 +446,7 @@ static int softsynth_adjust(struct spk_synth *synth, =
struct st_var_header *var)
>  	if (var->var_id !=3D PUNC_LEVEL)
>  		return 0;
> =20
> -	/* We want to set the the speech synthesis punctuation level
> +	/* We want to set the speech synthesis punctuation level
>  	 * accordingly, so it properly tunes speaking A_PUNC characters */
>  	var_data =3D var->data;
>  	if (!var_data)

You have not addressed Greg's patch email bot warnings from your v1 patch
yet [1], so I repeat it:

> - You did not specify a description of why the patch is needed, or
>   possibly, any description at all, in the email body.  Please read the
>   section entitled "The canonical patch format" in the kernel file,
>   Documentation/process/submitting-patches.rst for what is needed in
>   order to properly describe the change.
>=20
> - You did not write a descriptive Subject: for the patch, allowing Greg,
>   and everyone else, to know what this patch is all about.  Please read
>   the section entitled "The canonical patch format" in the kernel file,
>   Documentation/process/submitting-patches.rst for what a proper
>   Subject: line should look like.
>=20
> - It looks like you did not use your "real" name for the patch on either
>   the Signed-off-by: line, or the From: line (both of which have to
>   match).  Please read the kernel file,
>   Documentation/process/submitting-patches.rst for how to do this
>   correctly.

Thanks.

[1]: https://lore.kernel.org/all/20230921021349.3350-1-huangli05@inspur.com/

--=20
An old man doll... just what I always wanted! - Clara

--Px7V2FwQOhhdPJkC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCZRIuQwAKCRD2uYlJVVFO
owaFAP45m2M6m+UQ3hKIhl7/GWiKz83TMTo3H91TH6zpSrSwzAEA2WojItEt9nrq
eCe/RUV8SwH4R69wDP7a53zkq9a2JAY=
=9WSw
-----END PGP SIGNATURE-----

--Px7V2FwQOhhdPJkC--