Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <8c2f8756-be5c-e2b3-e1a8-d2751a4531a0@nfschina.com>
Date:   Tue, 26 Sep 2023 09:20:50 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] cifs: avoid possible NULL dereference
Content-Language: en-US
To:     Dan Carpenter <dan.carpenter@linaro.org>
Cc:     sfrench@samba.org, pc@manguebit.com, lsahlber@redhat.com,
        sprasad@microsoft.com, tom@talpey.com, linux-cifs@vger.kernel.org,
        samba-technical@lists.samba.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
From:   Su Hui <suhui@nfschina.com>
In-Reply-To: <1ae6c204-ed00-4626-8246-32d66ae7e232@kadam.mountain>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/9/25 23:07, Dan Carpenter wrote:
> On Mon, Sep 25, 2023 at 12:52:21PM +0800, Su Hui wrote:
>> diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c
>> index 2108b3b40ce9..37eed057ded0 100644
>> --- a/fs/smb/client/file.c
>> +++ b/fs/smb/client/file.c
>> @@ -4878,6 +4878,12 @@ void cifs_oplock_break(struct work_struct *work)
>>   	struct cifsFileInfo *cfile = container_of(work, struct cifsFileInfo,
>>   						  oplock_break);
>>   	struct inode *inode = d_inode(cfile->dentry);
>> +
>> +	if (!inode) {
>> +		cifs_dbg(FYI, "%s : failed to find inode\n", __func__);
>> +		return;
>> +	}
>> +
> Are we allowing this in the middle of the declaration block these days?
Really sorry for this, I will modify it right now.
Thanks for your reminder!

Su Hui

>
>>   	struct cifs_sb_info *cifs_sb = CIFS_SB(inode->i_sb);
>>   	struct cifsInodeInfo *cinode = CIFS_I(inode);
>>   	struct cifs_tcon *tcon;
>
> regards,
> dan carpenter