Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1584684rdh; Mon, 25 Sep 2023 18:33:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFc79XZADD+2KbHllDdEmM9cD/3QmykzsiTUN7qDdFwLN1C69YiLnyaqrONGm/jDYekPQ/B X-Received: by 2002:a17:90a:fa93:b0:267:70a8:abff with SMTP id cu19-20020a17090afa9300b0026770a8abffmr7187994pjb.29.1695692014033; Mon, 25 Sep 2023 18:33:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695692014; cv=none; d=google.com; s=arc-20160816; b=k5BrO+G4XCwYUrpaNGSmotAb4vJE9iICUcG+NILKk505eF740u2iChlmruu6uwCWo1 Rs9O7gqWp7V6bUdDLAszYLn1oP+lc3OgMY/EYw3VVRjP2BApQ5H7SiE9jxxxcDqf5gGO ylDwK8ryyCNMwMvxe3TCHnTtJFDVX5KA+ypES+uZe3p8nsITQNU0SeuxfkWpr/Ky/1sm UZ/qSfzX75fdbdKhGyPwGO00Hx+8lU3ASPg3xZ1CXbL/w+0wsHKsNOAslvySJR/y2evf Df0JCRUurddVEFqIxxubqmEERHJm4TZmVtPA9VCSqM64rU4mf5zlVEEyTWO2S/BbV/k8 mQVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:cc:to:from :date:references:in-reply-to:message-id:mime-version:user-agent :feedback-id:dkim-signature:dkim-signature; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+H/CZgEis=; fh=Jhw0mw8itBUd7uOc5p9JthF28c5+rps1oklFx6RzaoU=; b=IRmZgCrNXNETKftCi5IvXkVxO0HjWd+tdWz3sdHK1LIl5bKxJ5OLjzdyLFxl3tZALo 8eq75pgyBZfXsYho8UvKrjh2SBAIwHPEktrDP/PtuMbBLlzpFRJe0TXvSeABnornIJVt vna6Ryzwd80xqsTcdK48wpg1x7Nwr/G0f/zQrnfgyyHxxwtI/z1jcxqidph5EbD9ebBq 8PANoq5kovVadGEoeeefbKQZlWmIaL6m/E1ziUULU7XpXG2SULe6hcjFS/OpXV7iHLqM TKWwZp9DDmFtt/lDADOBJuqDLeTSKaGJWQYI9Xmnf3P5q/ewSoEROjIdc6pLQy590yl6 TwAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=iqFM2qdr; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="A9sS/MXG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id j5-20020a17090a31c500b0027482a0f548si4918756pjf.133.2023.09.25.18.33.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 18:33:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=iqFM2qdr; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b="A9sS/MXG"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 29BB5806FB79; Mon, 25 Sep 2023 18:32:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232312AbjIZBcv (ORCPT + 99 others); Mon, 25 Sep 2023 21:32:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjIZBcu (ORCPT ); Mon, 25 Sep 2023 21:32:50 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F6BD101 for ; Mon, 25 Sep 2023 18:32:44 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id DF2E35C0568; Mon, 25 Sep 2023 21:32:43 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute6.internal (MEProxy); Mon, 25 Sep 2023 21:32:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1695691963; x=1695778363; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+ H/CZgEis=; b=iqFM2qdrwdtNuhzQ4HP+X2tJ4aPrgSuXnESCe4kabvf4tgeuSXG IUQOdVRdzeATuztIh9yui6KA838SFU1N3/2h8xCycaThXuG9AMguZJ2d6dTIbOs2 IP31yp12JYAHcc2lDPg0arkshhIaWPktn1mu3bTV+2p2ISBd9pGDA6aDeSsaLENx OPcxblSQrzZqaG1motcw0IuZlH06NlpKHcgGplBlI6ek4iCiq6YYqeL/w0C9Waib X4WRGK+befqhNGeKMynyFgKiwdWIyZBtR6U0HrvcRRcT/5rPPXIvG84uwn4dupy+ YfvyZ3SVC300H5MxRjDAhsw1Ch8eY8wGrRA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695691963; x=1695778363; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+ H/CZgEis=; b=A9sS/MXGzuXTVZNOK/xoupemIzzx8zkQ6LCm+LyJJXZ675lsGPG F45lhCbPKE7gOsoQpPMDUOMuBZ8ft6zb/P750LAX+HVJ/zNdebIHWw1ZINv8eLy6 P4EuwMsrEscw0ulP8LqsThb3BG81f4vpAQdNTYFQYFnt68rgMOzCVeJJyrN4KiN4 nsQxMOGP6jJsNLjd2Tbc7yfkq8v/fSCqf19BtszNCtM+tO4Aeue0G2SUbX7ec6/Z +N+2yANyP0eWhOey/2V5Mm4TkuptID8iv/VT2VhqmYT7Kzm5tXGL+1kBPjUPJryW +NcQXd2CvJZMApE0MtYMN+Y+3qFg2xcdOHA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelhedggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet nhgurhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecugg ftrfgrthhtvghrnhepgfeiieettdelkeehffevieetgeejgeffveefhfffkedvudefuddv veejgeehheevnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehmrghilhhfrh homheprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Feedback-ID: idfb84289:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id EE4111700089; Mon, 25 Sep 2023 21:32:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c MIME-Version: 1.0 Message-Id: In-Reply-To: <20230925095532.1984344-4-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-4-u.kleine-koenig@pengutronix.de> Date: Tue, 26 Sep 2023 11:02:21 +0930 From: "Andrew Jeffery" To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Joel Stanley" Cc: "Rob Herring" , "Arnd Bergmann" , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Pengutronix Kernel Team" Subject: Re: [PATCH 03/40] soc/aspeed: aspeed-p2a-ctrl: Convert to platform remove callback returning void Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 18:32:48 -0700 (PDT) On Mon, 25 Sep 2023, at 19:24, Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling = by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Andrew Jeffery