Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Mon, 25 Sep 2023 23:58:21 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Andi Kleen <ak@linux.intel.com>,
        Christoph Lameter <cl@linux.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Yang Shi <shy828301@gmail.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Vishal Moola <vishal.moola@gmail.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 09/12] mm: add page_rmappable_folio() wrapper
Message-ID: <ZRIQjZOZJ2ZFkY8C@casper.infradead.org>
References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com>
 <f4dc7bb6-be3a-c1b-c30-37c4e0c16e4d@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f4dc7bb6-be3a-c1b-c30-37c4e0c16e4d@google.com>
Precedence: bulk

On Mon, Sep 25, 2023 at 01:32:02AM -0700, Hugh Dickins wrote:
>  {
>  	struct page *page = __alloc_pages(gfp | __GFP_COMP, order,
> -			preferred_nid, nodemask);
> +					  preferred_nid, nodemask);

I really prefer not to do this "align arguments with opening bracket"
style.  As long as they're indented enough to make them visually distinct
from indentation-for-if-blocks, I find it annoying when functions get
renamed to something with a different length and somebody then wastes
time reindenting all the arguments to match.

> +	return page_rmappable_folio(page);

I don't particularly object to the main thrust of this patch.  I'm not
sure I like it in huge_mm.h though.  Maybe in mm/internal.h?  I
wouldn't want anyone outside mm/ calling it.