Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Feedback-ID: i56684263:Fastmail
Message-ID: <edc0b599-c5d1-4e9c-a51b-eb8ceaef7acc@ryhl.io>
Date:   Mon, 25 Sep 2023 23:58:46 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 2/2] rust: arc: remove `ArcBorrow` in favour of
 `WithRef`
Content-Language: en-US-large
To:     Boqun Feng <boqun.feng@gmail.com>,
        Benno Lossin <benno.lossin@proton.me>
Cc:     Alice Ryhl <aliceryhl@google.com>,
        Wedson Almeida Filho <wedsonaf@gmail.com>,
        rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
        Alex Gaynor <alex.gaynor@gmail.com>,
        Gary Guo <gary@garyguo.net>,
        =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>,
        Andreas Hindborg <a.hindborg@samsung.com>,
        linux-kernel@vger.kernel.org,
        Wedson Almeida Filho <walmeida@microsoft.com>
References: <20230923144938.219517-1-wedsonaf@gmail.com>
 <20230923144938.219517-3-wedsonaf@gmail.com>
 <CAH5fLggxsewmtzXjehbawDCTHO0C7kteU_CLnh80eMNj=QyP9Q@mail.gmail.com>
 <969eab7f-ad40-0dfb-18b9-6002fc54e12b@proton.me>
 <ZRGd4lsNP30L2yB3@Boquns-Mac-mini.home>
 <14513589-cc31-8985-8ff6-a97d2882f593@proton.me>
 <ZRGyRQuBcWvgtdNR@Boquns-Mac-mini.home>
 <9d6d6c94-5da6-a56d-4e85-fbf8da26a0b0@proton.me>
 <ZRHWqbvYlXBXEOh-@boqun-archlinux>
 <c5134a1a-a60d-73bb-9faa-aa1dfc3bc30d@proton.me>
 <ZRIB0hXNvmJtmyak@boqun-archlinux>
From:   Alice Ryhl <alice@ryhl.io>
In-Reply-To: <ZRIB0hXNvmJtmyak@boqun-archlinux>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/25/23 23:55, Boqun Feng wrote:
> On Mon, Sep 25, 2023 at 09:03:52PM +0000, Benno Lossin wrote:
>> On 25.09.23 20:51, Boqun Feng wrote:
>>> On Mon, Sep 25, 2023 at 05:00:45PM +0000, Benno Lossin wrote:
>>>> On 25.09.23 18:16, Boqun Feng wrote:
>>>>> On Mon, Sep 25, 2023 at 03:07:44PM +0000, Benno Lossin wrote:
>>>>>> ```rust
>>>>>> struct MutatingDrop {
>>>>>>         value: i32,
>>>>>> }
>>>>>>
>>>>>> impl Drop for MutatingDrop {
>>>>>>         fn drop(&mut self) {
>>>>>>             self.value = 0;
>>>>>>         }
>>>>>> }
>>>>>>
>>>>>> let arc = Arc::new(MutatingDrop { value: 42 });
>>>>>> let wr = arc.as_with_ref(); // this creates a shared `&` reference to the MutatingDrop
>>>>>> let arc2: Arc<MutatingDrop> = wr.into(); // increments the reference count to 2
>>>>>
>>>>> More precisely, here we did a
>>>>>
>>>>> 	&WithRef<_> -> NonNull<WithRef<_>>
>>>>>
>>>>> conversion, and later on, we may use the `NonNull<WithRef<_>>` in
>>>>> `drop` to get a `Box<WithRef<_>>`.
>>>>
>>>> Indeed.
>>>>
>>>
>>> Can we workaround this issue by (ab)using the `UnsafeCell` inside
>>> `WithRef<T>`?
>>>
>>> impl<T: ?Sized> From<&WithRef<T>> for Arc<T> {
>>>       fn from(b: &WithRef<T>) -> Self {
>>>           // SAFETY: The existence of the references proves that
>>> 	// `b.refcount.get()` is a valid pointer to `WithRef<T>`.
>>> 	let ptr = unsafe { NonNull::new_unchecked(b.refcount.get().cast::<WithRef<T>>()) };
>>>
>>> 	// SAFETY: see the SAFETY above `let ptr = ..` line.
>>>           ManuallyDrop::new(unsafe { Arc::from_inner(ptr) })
>>>               .deref()
>>>               .clone()
>>>       }
>>> }
>>>
>>> This way, the raw pointer in the new Arc no longer derives from the
>>> reference of `WithRef<T>`.
>>
>> No, the code above only obtains a pointer that has provenance valid
>> for a `bindings::refcount_t` (or type with the same layout, such as
>> `Opaque<bindings::refcount_t>`). But not the whole `WithRef<T>`, so accessing
>> it by reading/writing will still be UB.
>>
> 
> Hmm... but we do the similar thing in `Arc::from_raw()`, right?
> 
>      	pub unsafe fn from_raw(ptr: *const T) -> Self {
> 	    ..
> 	}
> 
> , what we have is a pointer to T, and we construct a pointer to
> `ArcInner<T>/WithRef<T>`, in that function. Because the `sub` on pointer
> gets away from provenance? If so, we can also do a sub(0) in the above
> code.

Not sure what you mean. Operations on raw pointers leave provenance 
unchanged.

Alice