Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Mon, 25 Sep 2023 10:46:46 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Cindy Lu <lulu@redhat.com>
Cc:     jasowang@redhat.com, mst@redhat.com, yi.l.liu@intel.com,
        linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, netdev@vger.kernel.org
Subject: Re: [RFC 6/7] vdpa_sim :Add support for iommufd
Message-ID: <20230925134646.GC13733@nvidia.com>
References: <20230923170540.1447301-1-lulu@redhat.com>
 <20230923170540.1447301-7-lulu@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230923170540.1447301-7-lulu@redhat.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5mneuuNa4820R8KCBeT/nTVPab1YsRD0E00wmF4cu0M4+PSEk8DiXBWRcY1Q?=
 =?us-ascii?Q?TubstUxdUCMpqxm7FyEJvg0yoRWAOY8hdshf2Xy7LnMFYmvNt2c+PBpR0Mpj?=
 =?us-ascii?Q?4yIK3kngDFOqKVUuYTQE2xPzi5pOAcTy5Vm/7gTe+NOMhTYmuHEShFvoJvlC?=
 =?us-ascii?Q?1c2JKI5b/fZhbkK+wSoZ2UP4GzvEig03I9FW3FcoN95Q9JKYtECXk3AfkYH1?=
 =?us-ascii?Q?WwgaV5I9nbkVQ3l2+MkiVwbP3+J6mNFwiPjMBpAGpay2epJoc3GCJTTjoT+i?=
 =?us-ascii?Q?GQB7y8n7CDGzv6isnqRcKP65UBnmkDx8weXgf5jM5teiWD4pQgnIFODDWM4i?=
 =?us-ascii?Q?FQtkYXkfrdqultX1STUiY53RHkjjKMJSKNSn60gs9+el4rs3IvsL5rHZsiiL?=
 =?us-ascii?Q?5qSXAj2aEU91NSf2VRu2P32Lleff3EMBLmizeJu/N25Cn7NBdO/CIRqwYOLQ?=
 =?us-ascii?Q?pysLoIarvtSyrA1BrFXXtHZ5MqCqy0JXcr8l83DWY8VWC6z719d5KnacrUHt?=
 =?us-ascii?Q?x+lSZcEnYbWDiwrDdT4Vwj+eGvV/t9OcdkfRJ9wOlI/DmUwjYgdTmETJ3fXX?=
 =?us-ascii?Q?OopF2ZS99L9C+GrayVv44RtXnPRCV5oRlWRnMUrDhLgJoDI6pAdYDwGwAL1S?=
 =?us-ascii?Q?3cMsLLrGUfvnNWEh+UPT0i9EyzeAAFOAe1kpCOridKU/dZo5tHu0/IiICPQF?=
 =?us-ascii?Q?XQ5oXb07a9fNnGSc6RUjZ2hX9UWnFXxdS4idWk0wVSBnLneapKw793RiJRNB?=
 =?us-ascii?Q?+ZjW9L7iV22KZWhXT2Vs5P4Lo2zw79S0ITp6RbUX510WLqFHOeuzgXUkRQpq?=
 =?us-ascii?Q?ZxzxIvQXphyoCnE2YCZDfeuXITceFPzvUQwnYhQPUlu5Y20/rlTNXXwn2IHY?=
 =?us-ascii?Q?pSQ0boLlDNubgnb4X0dAevGPF/PxsJh+wpAAMpRDLRich92qxqC8QpjIyj9b?=
 =?us-ascii?Q?fv/54Mma1KoRrkVBjA3VokUI7byulOiZwq2dBhQzOIgIwSI8sX03KnF0ilpC?=
 =?us-ascii?Q?ck58iSLKaCP3hnl0bAyT0C0symS3SXLuAYZLgpHcbsPu7BAdRkhjdcdD46xl?=
 =?us-ascii?Q?XROX3TU5mnhtfgH7gd1qCm1Zjg/ArydP/RPy0UEdm+sDvvp2erWajdytpyLZ?=
 =?us-ascii?Q?IUIeahEMSu9SiERTxVRJUmT15se5VcZ+6uPFEwGZXxDAOSYfMg7t+Bd8Qd5o?=
 =?us-ascii?Q?msC9PuxgZy/iBD/AWCzoeX6fo3hCRc/ni+w6c1gRGEzXukEsHbEgLiH0KC+l?=
 =?us-ascii?Q?g8BrJhEG++uXBpcA7Jx73ZIZQPaeIHktr5N6BJzXjL3Hk28djLNOjb1d3eyf?=
 =?us-ascii?Q?mcz7I77+UAgMuRG52DGuC82o+FVobXeZZ01+2thVZBShogLXN3aV+LjMJxA3?=
 =?us-ascii?Q?F2gZgWeeQTJklQ9TrZxaCjklBbhO2Je6cpsVz72AM9DsgsPudlGmOyH8HIQv?=
 =?us-ascii?Q?DSNafkFZW5AyM9V2BNyRfUmp045PBX8qNPvq9q6TkjZJGdcSmBnMmXqBRE6p?=
 =?us-ascii?Q?ZGuWzAlXSSrly5vgB8Tj42uWBXNlD9DZVc8Y7RzDlxGq0wuKxox+J8FVoqA4?=
 =?us-ascii?Q?hfYJFUfSfaZIJhcVAivGBuX1EkxOOZZDUHsLQabe?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0592dd27-acc5-4d54-bc44-08dbbdcddd1c
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 13:46:48.0142
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: w6ZUI/lb9gRqmVETV+D7IqiZqZ2jYvwTreOyy66PrFBGRBYplGMHv6gTY0kwc0+q
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9066
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 06:47:00 -0700 (PDT)

On Sun, Sep 24, 2023 at 01:05:39AM +0800, Cindy Lu wrote:
> Add new vdpa_config_ops to support iommufd
> 
> Signed-off-by: Cindy Lu <lulu@redhat.com>
> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index cb88891b44a8..55e6f45bb274 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -727,6 +727,10 @@ static const struct vdpa_config_ops vdpasim_config_ops = {
>  	.dma_map                = vdpasim_dma_map,
>  	.dma_unmap              = vdpasim_dma_unmap,
>  	.free                   = vdpasim_free,
> +	.bind_iommufd			= vdpa_iommufd_emulated_bind,
> +	.unbind_iommufd			= vdpa_iommufd_emulated_unbind,
> +	.attach_ioas			= vdpa_iommufd_emulated_attach_ioas,
> +	.detach_ioas			= vdpa_iommufd_emulated_detach_ioas,
>  };

Er, this series never calls iommufd_access_pin_pages() or
iommufd_access_rw(), so something pretty big is missing

Jason