Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <1d3dc6d5-7191-ef5c-7f09-8911c4b4fa15@intel.com>
Date:   Mon, 25 Sep 2023 09:59:22 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
Subject: Re: [PATCH] ice: require PTP clock for building
Content-Language: en-US
To:     Arnd Bergmann <arnd@kernel.org>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
CC:     Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        "Paolo Abeni" <pabeni@redhat.com>,
        Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
        Michal Michalik <michal.michalik@intel.com>,
        Jiri Pirko <jiri@resnulli.us>,
        Jacob Keller <jacob.e.keller@intel.com>,
        Joshua Hay <joshua.a.hay@intel.com>,
        "Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
        <intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20230925155538.526317-1-arnd@kernel.org>
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20230925155538.526317-1-arnd@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cFhuUjZoZlVDUmFtQTBjQnlOQkZpWWhVc2lNRmdKTXNBcmxIZnFFWTFIdUUy?=
 =?utf-8?B?dXYyaUw2dGc2Ui9zRzJ2VkF4VDdsT2tKVng5R3JkRTd5YU5BNkE0RHFFYUhs?=
 =?utf-8?B?L2VXT1RGZnNEYnpZaTJwa3BwdHlnQUxKZDdtTG8yNVZTYUFGcXBhTThocDVL?=
 =?utf-8?B?ZFFLdFZRY3hkTnQ3YVhZblJqVk84bVI5aGswOEJsNWF0U043a2YrMHFMRms1?=
 =?utf-8?B?YnM2QmRvcHV5VFUra1NQOXdlS3RyTUtFTDJBYnVEQ20vV0NYeUlwTzVoRjQv?=
 =?utf-8?B?MS9DV0RjVHVlMGtJSml4ZHZRc1BBSDNJdUUxQ2FzOG9sTHZiTW9nQWdpUXly?=
 =?utf-8?B?L2N4RzIrQmxVNFJzQVIxYjZoZzR0WlViVkVoT0plS0FVcEtlQXYrZGRrR3Qw?=
 =?utf-8?B?UG5iZFFCRm8yS1BmaCt5K1dWeUR6SDBYM0N3U1YraU9EQ2RHbngydTVTZklY?=
 =?utf-8?B?SzlRMnJlcDc2Vnl5L1JsNUlGQmxSMlZuUlV1aC9MMTdmUDF2dnBOOFg5NFdt?=
 =?utf-8?B?YVpWcGRyR3Fwc1RPejBMVWE2ZDFPNnFpWDBEZThRSVc2MHIzN1R3blRwbFpW?=
 =?utf-8?B?Q1FNck11QWdIaS9rVGZQZWlrcWpGSXVDc0dvVDNRZDBYZU5jWG5xY3RvUFhO?=
 =?utf-8?B?cTdOVHQ2UVhmTU9OeEhXQUtmNzYyK1RzWnEyc1h4aGhReE5CZGpYazZFMU5r?=
 =?utf-8?B?VWhJbnF1Tk9MUVIwdUtWTnJOdUZ2bjJjdmVDVVowZmRNS0liY1dZSE96VFQw?=
 =?utf-8?B?OEZHaldTNDJ1VUNTcXBqdHdHT2hjMnY4Rkd3L0FnWnluQ2UzSUR6N0s5RXU2?=
 =?utf-8?B?NXZKOFBYT2tWZHZlQU05OVZrRjRsR3dMN1JKUDVYNjRhVVlVUmxOQWRRR0lV?=
 =?utf-8?B?L1BYVWcvNGViVmI3ckJTNHMzRmJZNnMwRkFFd29zMjJYYjdnV1ZNYnQ2ekE5?=
 =?utf-8?B?U1ZTS3NuUWdGSkVSaXFMaVVrNy8xSlNBUFNoQlhkOUZRWVFOc0RUZ3c4TUFa?=
 =?utf-8?B?eVFvRGlMSWhNUHhQM2pkbmtEdWIrODlTWnhjRUtUSjRWay8xQlk2Y0pTaGI1?=
 =?utf-8?B?VThLMy9DaVJVUElYNVhoRDJFSWxwNTErclVhQS9oUkk0RG5uT3oyS3JJTmxp?=
 =?utf-8?B?U0YrTU5HMVYrYTBqM1pnelMyVUVXa3orajI3QmJUODN6U011anFMRjZ1dXFr?=
 =?utf-8?B?Nm5MbWxPUjk3ZGtSY2Jua2VDZzlDTVlxMEd2eUxZaU1rTW9tdTFkUi81UlRa?=
 =?utf-8?B?WDRqakpQUGJGOXhyWGd0enRHM3A1ZGpmN2J5QzhwSHBHMDlBZ0toK0NuVlF6?=
 =?utf-8?B?Vmd4QWw0T1pvM0VNdEh2c2lFVnp1MDhuWkpVdDRkYjZyWHFNSTBwL3ZIaDh1?=
 =?utf-8?B?UExpUktOUVQvOTdFdmUyOGNxeFBjMy9TNXRnZTBrZlJldWxxVUFOSzEzc2F2?=
 =?utf-8?B?MVRLa3VDRlg0L2oyeUZtRll0NWpaSlF2QkNhdHQ2d054akVzdExuWjJRamhK?=
 =?utf-8?B?aUZZSUFXeW5RQmlEQkY2c0JveDBqdE1iVm5VUStMbDlHTXk1LzFWNDY2cUFq?=
 =?utf-8?B?NndteENRcDFUUVVRSENsZzFvcHpvcFZwa3A3OS96Tms0aUdTbFBOS1cwdjA5?=
 =?utf-8?B?c0FMMjExQllzVmdWMjFlZTdKcjF3eHhwSm9JdllxTTRQejY2TDRnSitMQW9y?=
 =?utf-8?B?YXlqeDZHbnpLNWtlRGhtUHZNclRjMDh3Q0FkTHFTV2NMU3ZTOHhKQ3Fzek9u?=
 =?utf-8?B?cHlteVRXRytLNE51MUpoRlEyd0VEcFdOYzJyZ09IVHB5Vk1yQkxJWE13enhD?=
 =?utf-8?B?RHgxb3k1c0g1anpiTDBLdHYzUVV6S2tGNjNqbkpvZXNNVHIrdzBUcjBybkFF?=
 =?utf-8?B?R2Z4bzNoejRDQlBkc05lMTBHNkVYNXBzMURHV09WQk12NC9KS2hxc0JkemJH?=
 =?utf-8?B?R0hMeVk1K2FGTDROK3Y5QkkyMFJwN2I0Q3dweGpiSWpEbUtTdm85T0tXbjM4?=
 =?utf-8?B?TGd0Ly9xaVJrQjNEZHgzdjF2aVhqQ3RPQVY2R0V3TlB4MVdkQXR1Z2RLTDhr?=
 =?utf-8?B?d3FhZzcxc0RvYk5TMk9QWTlHYlJzaFZ6b2tzbU5oZ0pMdll0dkVqdllCY3dy?=
 =?utf-8?B?WVpQYnRwaFlZUzJZMUpJYTFGQzhPb1I2SkUzb0JPUnhPV0QzS2hteStjU1pi?=
 =?utf-8?B?d1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d46b38e7-a0ee-461d-aadd-08dbbde8c799
X-MS-Exchange-CrossTenant-AuthSource: BL3PR11MB6435.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 16:59:28.3770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Gt+UcSV4Z3IoDb0MjL0NIFUgZ4idJ+/G/vHLHG2cLDXHS516fFPWaapNHf9rb+ec7mxTBfKp1EhzLu7BYQMiybRgCs08c57AI7frmX7DK1A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4872
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Mon, 25 Sep 2023 09:59:42 -0700 (PDT)

On 9/25/2023 8:55 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A previous fix added PTP as an optional dependency, which was correct as
> of commit 87758511075ec ("igc: fix build errors for PTP"), but this
> has recently changed with the PTP code getting more deeply integrated
> into the ICE driver.
> 
> Trying to build ICE when PTP is disabled results in this internal link failure
> as the local functions are left out of the driver:
> 
> ERROR: modpost: "ice_is_clock_mux_present_e810t" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_is_phy_rclk_present" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_name" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_get_cgu_state" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_is_cgu_present" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_get_cgu_rclk_pin_info" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_type" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> ERROR: modpost: "ice_cgu_get_pin_freq_supp" [drivers/net/ethernet/intel/ice/ice.ko] undefined!
> 
> I tried rearranging the code to allow building it again, but this was getting
> too complicated for an outsider, so just enforce the dependency to fix randconfig
> builds again, until someone wants to clean this up again.

Hi Arnd,

There's a pending patch to netdev that does this [1].

Thanks,
Tony

> In practice, any configuration that includes this driver is also going to
> want PTP clocks anyway.
> 
> Fixes: 8a3a565ff210a ("ice: add admin commands to access cgu configuration")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

[1] 
https://lore.kernel.org/netdev/20230921000633.1238097-1-jacob.e.keller@intel.com/