Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <5f753ef4-caec-479a-bff4-43c16fb3317b@amd.com>
Date:   Mon, 25 Sep 2023 12:44:03 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: s2idle stopped working with 6.6-rc on Thinkpad T14 G1 (AMD)
Content-Language: en-US
To:     Thorsten Leemhuis <linux@leemhuis.info>
Cc:     Linux PM <linux-pm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux kernel regressions list <regressions@lists.linux.dev>
References: <0d84fb59-4628-4c7f-ab1a-f58889ef2c9b@leemhuis.info>
 <e556ae63-0539-4b34-b33f-5f5beb4183d1@amd.com>
 <e049aa41-b136-4071-850f-d06b47fe67a1@leemhuis.info>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <e049aa41-b136-4071-850f-d06b47fe67a1@leemhuis.info>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L1o4eXRkSnRMWTc1NzRXTHlvaGJZWHpORlZsT2dvdkV1VERpRHlTL2tSelJP?=
 =?utf-8?B?ZmRpekY5UEtNSUc1dHhZRXVDV01oRFo4eUU2T01GNlFkeVBNRFNzMUtrVWUw?=
 =?utf-8?B?U2YyTW5kUU8wQjFxb1NMMlFRVllOQm9Ya1pqSS9hTjZwMVJjMGovWXJuM2Uv?=
 =?utf-8?B?cUVJSXhLRUY3RzBzbG1yaWFiZDFINnptZHpGN1NPei9WdnpsRkZyMytRUTcr?=
 =?utf-8?B?ZHZldHRuNFRkZDVoNEZXSnYxMGJUYTUyNGF6YVlkeGlyclpjZmRCZWFVeEZ5?=
 =?utf-8?B?WWpTeDM1WnpxRmZOeWNhUytQdXF2WWs1eC9pcFhDZ3VoSGVpYUVyRHdyRXQ1?=
 =?utf-8?B?Uk1qK2Fvem9lQzZyMXpZSXl4MElab3QwRGFkaXY5d2MvYXRhYWtyNkhWeVpE?=
 =?utf-8?B?V3dGU2tEMEovWUJwWnZRQzJmUjNEVGdQaExJYmlncmVnVTR0dUZyMGd6NzRy?=
 =?utf-8?B?T1lIMFNBWDZVUXlQdzZYOXFZdmdlQnV4OVM4bFJValJCUS92RWxIRjJiajho?=
 =?utf-8?B?bHdIVWU4Zld0WW4xdno4SDkwanZJa1dRVTFZSXFmK1RVT04zQUhRZVV5THRT?=
 =?utf-8?B?cnZiVEthbE1nd0JETmVwbVJCeVU3dE12N3pqcWU1L3R1YjNHNkZDdzU2b05m?=
 =?utf-8?B?WGJTT2FNcjhDanhNQXkwRWZJeHd0K1VWQ3FuZEVDSk1hRno1Znl2MGY0QW95?=
 =?utf-8?B?NGhSL3RwQ1NNVDNKUGJ1TjJhTEpNeHBmQzhFQTVyNzl4VW1SMEVSeExIOGZF?=
 =?utf-8?B?N1VCdVFYZ3lnR0xFV0FEOU1nbU5STTh1dHF1amNQWm1aU3lGVUh6NElVT1px?=
 =?utf-8?B?eVUvdEtZeXhlRlNlYTBsd0lVMzQ1amc2eUJPaGhoK1Q3YWZKVSszdkN6WTlF?=
 =?utf-8?B?eVlGbHdKNitITG9IcmgyWnVUMGpwNDA5M3lTd0xLY25CNGVxOVFOSGN0eUlE?=
 =?utf-8?B?ZkNUL1kvUlltQmwwMzZFc2ljWUhVeGVwM3h2RE5MdEo3OXQ3TTE0dHRKb0J6?=
 =?utf-8?B?LytRY0RyVWRYRVhsK2VjN3dKVUxobnFYMDNlM1NzTUJnem1BejNmeVVQSUtB?=
 =?utf-8?B?cEZzSDJMaWozeTJlNWZZR280M2V5SmZoVWVRK29RVldPczdiT0k4VWU5QmJx?=
 =?utf-8?B?ZTh1S3FWOUVqeFFBVW1vMEU4K08vN20wZld3NnhDd2FUYXo4eDVDWDRWRzg1?=
 =?utf-8?B?bVFHVjlsMk81NVFUT210aFhsdmVaSVZ5WTN3Tyt1RU9UeGQyZUFlU2p5ZXJv?=
 =?utf-8?B?ZVhKMEZ1QTJTTTh4YnBMNkRuWEJzTk95OE9hdnVRZVplN3NYZ2x3blRndm0z?=
 =?utf-8?B?b2RMMlpodHpDSVJnelVjVWM3S3I2bWxyUkFVSStNQXNMMnBoZjlPd1owMXhJ?=
 =?utf-8?B?SnFHRjdLUHl4S1JHTks2TXZvV3p0Mi9iMG1lQUoreStEOGE5OWR0UjVJT2Vn?=
 =?utf-8?B?V3BXZEJxSWdpMEwzaklDbGZrMkVtbGhqL1NlS0s3NWlSU3VEMFhzNk9jakRr?=
 =?utf-8?B?STFlWWgrNWYraXNvZjlmNE9oWVRBWTJvZXRqb0grc0I4ZDZtN1JGdm5WUG16?=
 =?utf-8?B?R2J6WVlSNnV3YmpoSkd1RXJuYnNLTDBOWnpHQXFHcDY1cy9SQWpmNkVqMSs4?=
 =?utf-8?B?eVB4ZUFmb0tvaXpldFVvUzhqbmVkSXdWM3EyU3FTU1FEWit5eFJVNXpxd3dT?=
 =?utf-8?B?OHF2VU4yYWE0YkFjM3hmMURIVXJoMjJZaTExTmlDTE03dDZ2TENCYnAyOEJn?=
 =?utf-8?B?N1RFSjUvWEtCMDl3NzJ5L0wzTURwRlFCVjlHN0pkNlo4TGQrd2ZrTURYOUJ5?=
 =?utf-8?B?YWVyK3liRldWdFQ5U1JGWDBTVzg5Mk9NTytaOXBRWWNTdVlQSmVMbjdOVUpj?=
 =?utf-8?B?RFBhMnRPTk5wd1NmMCtSK3U4ZitlZHl6eExCTzNySHN1YzBQU1FIMkZzZWVS?=
 =?utf-8?B?T0VJSkRSZW11d2Q0eU1LOVVlYVljY3R2a1ovQjNoU0p5VVhzWTlCNWVlVkNJ?=
 =?utf-8?B?anMrRTNqZkNCVzIyQWhPaFh3dW9IaWNicWJlMGFRMU5FVHRQUnFJcFprblJm?=
 =?utf-8?B?anZtUUdTMVNtUGxjYkpBaytrTXpkdVpRMWMyTUJmeTFJS1QreXJpZ0lWZHdD?=
 =?utf-8?Q?//Tbq+yVnKqvnGnr8XdqIKDEV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 97e9b8fd-b7dc-43d3-4af3-08dbbdef03e2
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 17:44:06.5844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Ugtj4FuO+CWmMuMVEN6bKdMHQjZ3iTAFXq9q32LqSHQGKQOSsu0LAMlbEMl54+GwvK+Euxcf5g5bNm/Z4q4xpQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5668
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 25 Sep 2023 10:44:18 -0700 (PDT)

On 9/25/2023 08:45, Thorsten Leemhuis wrote:
> On 25.09.23 15:25, Mario Limonciello wrote:
>> On 9/25/2023 05:55, Thorsten Leemhuis wrote:
>>> Hi Mario! Did you by chance hear anything about lock-ups on resume with
>>> mainline affecting AMD systems? I'm asking, as s2idle stopped working
>>> for me with 6.6-rc on my Thinkpad T14 G1 (AMD).
>> You're the first report I've heard of this.
> 
> Thx for taking the time and replying.
> 
>> Yeah not too much useful stuff here unfortunately.  Can you check
>> /var/lib/systemd/pstore to see if you got a traceback for whatever
>> caused the problem?
> 
> Sadly nothing there.
> 
>>> Dmesg for 6.6-rc3 (with a USB-C dock, but problem happens without it,
>>> too):
>>> https://www.leemhuis.info/files/misc/dmesg-6.6_rc3
>>
>> Being G1, can you try "amdgpu.mcbp=0" on kernel command line?
> 
> Just tried it, but didn't help.
> 
> Guess it bisection time then...
> 
> Thx again for your reply. Ciao, Thorsten

FWIW your email prompted me to double check the two other Lenovo systems 
I have on hand at my desk:
* P14s Gen 1
* L14 Gen2a

One of them had a Ubuntu userspace (20.04 IIRC) and the other a Fedora 
38.  I built 6.6-rc3 and couldn't reproduce any issues with s2idle.

So yes; bisect is the next step, thanks.