X-MS-Exchange-Organization-Antispam-Report: OrigIP: 163.181.251.8;Service: EHS
X-Server-Uuid: DF9F24A0-1A5C-40A5-8B0A-DEB676E72ECF
Date: Mon, 12 Nov 2007 11:07:33 +0100
From: "Andreas Herrmann" <andreas.herrmann3@amd.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
cc: "Akinobu Mita" <akinobu.mita@gmail.com>, ak@suse.de, tglx@linutronix.de,
       mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix cpu-hotplug regression
Message-ID: <20071112100733.GA5560@alberich.amd.com>
References: <20071107011258.GA31607@alberich.amd.com>
 <200711070335.44416.ak@suse.de>
 <20071107131836.GB31607@alberich.amd.com>
 <961aa3350711070615m4a165546k4fa888cb546846f6@mail.gmail.com>
 <20071109121634.c7812697.akpm@linux-foundation.org>
MIME-Version: 1.0
In-Reply-To: <20071109121634.c7812697.akpm@linux-foundation.org>
User-Agent: mutt-ng/devel-r804 (Linux)
X-OriginalArrivalTime: 12 Nov 2007 10:07:33.0629 (UTC)
 FILETIME=[D7DD9AD0:01C82513]
X-WSS-ID: 6B26FA6207S2198852-01-01
Content-Type: text/plain;
 charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2161
Lines: 59

On Fri, Nov 09, 2007 at 12:16:34PM -0800, Andrew Morton wrote:
> On Wed, 7 Nov 2007 23:15:38 +0900
> "Akinobu Mita" <akinobu.mita@gmail.com> wrote:
> 
> > > [PATCH] x86: fix cpu hotplug regression (don't call mce_create_device on CPU_UP_PREPARE)
> > >
> > > Fix regression introduced with d435d862baca3e25e5eec236762a43251b1e7ffc
> > > ("cpu hotplug: mce: fix cpu hotplug error handling").
> > >
> > > For CPUs not brought up during boot (using maxcpus and additional_cpus
> > > parameters) we don't know whether mce is supported or not at "CPU_UP_PREPARE"-time.
> > > Thus mce_cpu_callback should be called after the CPU is online.
> > 
> > Thank you for finding and fixing the problem.
> > I added two fixes to your patch:
> > 
> > - Avoid mce_remove_device() for the CPU that is not correctly initialized
> >   by mce_create_device() failure.
> > 
> > - make CPU_ONLINE callback always return NOTIFY_OK.
> >   Because CPU_ONLINE callback return value is always ignored.
> > 
> > > Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
> > 
> > [akinobu.mita@gmail.com: make CPU_ONLINE callback always return NOTIFY_OK]
> > [akinobu.mita@gmail.com: avoid mce_remove_device() for not initialized device]
> > 
> > Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> 
> Andreas, could you please review and preferably runtime-test this new
> version?

I'll test it today ...

> Assuming that all goes well could one of you please prepare a final patch
> with a complete changelog?

... and can send a final patch after successful testing.


Regards,

Andreas


-- 
Operating | AMD Saxony Limited Liability Company & Co. KG,
  System  | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 Research | Register Court Dresden: HRA 4896, General Partner authorized
  Center  | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
  (OSRC)  | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/