Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <26fc07a6-9d8d-dd6a-9348-36d3ee5c973c@intel.com>
Date:   Mon, 25 Sep 2023 16:01:16 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH 2/4] Revert "sched/topology: Introduce
 for_each_numa_hop_mask()"
Content-Language: en-US
To:     Yury Norov <yury.norov@gmail.com>
CC:     <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-rdma@vger.kernel.org>,
        Tariq Toukan <ttoukan.linux@gmail.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Maher Sanalla <msanalla@nvidia.com>,
        Ingo Molnar <mingo@kernel.org>, Mel Gorman <mgorman@suse.de>,
        Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        "Daniel Bristot de Oliveira" <bristot@redhat.com>,
        Pawel Chmielewski <pawel.chmielewski@intel.com>,
        Yury Norov <ynorov@nvidia.com>
References: <20230925020528.777578-1-yury.norov@gmail.com>
 <20230925020528.777578-3-yury.norov@gmail.com>
 <49c0fa46-3787-99c5-2b8b-3da71ce33216@intel.com>
 <CAAH8bW_Lu_wk7q6eu6evV-ejVXJZn0s3ikw=e=r_tJfYOvqg0Q@mail.gmail.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <CAAH8bW_Lu_wk7q6eu6evV-ejVXJZn0s3ikw=e=r_tJfYOvqg0Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWtBNGUvSit3VWZKVm5LdVFzaXNqMVI0Rmo3NW9VdDRJd1hyS0JaTVFwbnB3?=
 =?utf-8?B?K0h5TFFiMG5HTmhsNm9lY0p2MUhrOFlHS2hCYXA5MXVMRGNQU25wQXBINFdv?=
 =?utf-8?B?N0xwdzdXayswM1JWMTU1SHN5MlhKRkpPbk1ZbCt1VjhjK1dISktvNlZQcGli?=
 =?utf-8?B?N0poNE9vY0taWHdoL2p4TzVOSHpielhFN2dGbk1PVnFHWWRUeU1GYW9ybHdq?=
 =?utf-8?B?dzgzMTRoVjdxOXg3dlh1SVUrVm5SZHJ0YlNQVnBUakJLeWdoWnBHdDFXN3VR?=
 =?utf-8?B?VmdvMndEOHVUaklTaFZiU3RFM3pqclNLNmNBR1hyQTdGc2hPUTFKR05td08v?=
 =?utf-8?B?WTR5QlFoSkxaRXJtQzdQak0xY1NEN0tPNHFVTXZQSVlrbnl1NjZCQlF3ZzRG?=
 =?utf-8?B?UTFsNHhlYlI3WG01eWpUQXJSRS9jMUsvUm9jTDA0TnU2cFJ3MitGelordDBp?=
 =?utf-8?B?MWhtS1ZvMXhaV2tVWmdXOVlGVTMycWdFc1A0eGdmNnlLVHZqYjRyclBJdjNZ?=
 =?utf-8?B?NWVMS3ZsZVJOZGJvZExOUVpXQmZoNU4vQjBKb2tTVXFsbHJscXdLdVlLQU1s?=
 =?utf-8?B?dzhIMWFIMjhNQmc4ckc0VFkwNEZYeWdnOU9LLzYydGNqY1dYdFdPOWJqYXdK?=
 =?utf-8?B?RzRNZmVIYkRoOFpBMy9FUkVUUUw0Vm9YRkpkZHQ2RlpoNlhFSkFIb2FYSWY2?=
 =?utf-8?B?SnlBV3pQSTN4d1dadUpOU0dNVnVsRVovRkptdWdDUytkZ3p1Mm9aajU0cDJi?=
 =?utf-8?B?d1lIcGlIeTFlTjI5UnZua2NNbWNvdVYwOEZ0WkRiMEMyNGplUU9SbkwxVjJY?=
 =?utf-8?B?eG5VaHlUQUpncC9FVGhDN05MN2xXUGNyeXJQdWhYNnlGdUFmY2NrWmxXV2xz?=
 =?utf-8?B?S0FoMHFzM1NnZmJjWmlXK3ZJa2FJbklkK1ArVzFWRVdyUmhkN2l2WGgrTG5a?=
 =?utf-8?B?eFQ4ZEhNMzJEemVocEFsMlpmSmpWOHJCNFhoMmJjNmd1WmdjWUk5c1pzL0Iy?=
 =?utf-8?B?SEFnNHJNV0FxK2s1NW96OVE4ZlgrZVIwNGZPNWUvOFY0Nmo5QzJmdEJJcnAy?=
 =?utf-8?B?cXluRS9QNzhFK2Qzb2M2VEVqMStCeVZEN29kdzdSRHNPNUdhZzZNUE9EMkRN?=
 =?utf-8?B?dkdpZUNMajViSVgwRHIwZUFXa3ZzeTNjWG0vWXU5OGpyZU53TzhzZUw4aVJH?=
 =?utf-8?B?WFowTEtCUjA2OXA2T0ZoSWlXMldHRDFacDMzcFFtMkh5VG9yMXNsV2loQUdi?=
 =?utf-8?B?ajlHUnlTL0Qvd3FxVFVWRjhSSFNVWEMwRFNDVURvcTg1VXlLRVc1RytscFFM?=
 =?utf-8?B?MHJWQlRER3NhdE9PMFZmUG5SNkRYdnpOT1BHQXNZakRyRVhBcU4zZlp5Q2Zw?=
 =?utf-8?B?a2plTU9tYmVZTmtvN3diSU5PLzArOTdvbThqdFh5bDFEaC9scERuOFBvblZN?=
 =?utf-8?B?VXYxQk5EOEl1Z0VLcmIzUW92TEd6aWFlRnBjdURJOVZvRE9zdExySHFFS0NP?=
 =?utf-8?B?bUJVZ3FKbjhTNWp6VUNzbzh5VkdyMnRGbHNqdHkzcHlHRHphdmZzYlhPZUVn?=
 =?utf-8?B?aWdoVHcyTllzNHdwSFU4VWd6Mnp0NzY4YTRxN24yNk5aTDYwMm1DM09ReXhY?=
 =?utf-8?B?T2c3NEZhWloyMnlQMm41VFlmUm1Zbmw1Rk1RVWhIdHhCTUJra1oweFByMVI1?=
 =?utf-8?B?a2V3NzZ2cUFnYU9LOGhaeVNXWW1KNm5HQ0dnK2ZvK3lkYVRwc3hYY1BOQUJq?=
 =?utf-8?B?Vndsa1pLMUdkSUdUZVBTOUd4djU2cE9TL2hrclpQNkZKbmV4UXQwL21VelY0?=
 =?utf-8?B?L3RKSVRIZ0NLZWtIcnhXZ0dWQUU5UG9McXFCbkUzV09wNkdZYUVhMk51eTVl?=
 =?utf-8?B?MEw4M29NencwL0s5Y3BrbDBHWVk5aG1QZ0FmOWRINnRLWTVHSS85Y1lVckRk?=
 =?utf-8?B?RnhlY25zN1FwR2hFcGVhM3o4eUxOeVZjdVRacUN0Z1BUTHlQUXhoZmpFMFJx?=
 =?utf-8?B?elJXdkJ6d3FXZzZ4cmVwNlV1dExyemJoTG1VZ2dFUnh5T0FhSUhBUEthbTBm?=
 =?utf-8?B?ZkY3QXNldjdVcFZ2eWJjZHQrVitvYk9CSXJPak5jR1FxdnhSby8xMldMOHFi?=
 =?utf-8?B?a0dZMUU2T3ZabFUzTXJUVG4vcU5HVFZ5bmFOZ1l1MC94YlgzLzF3WHZZdHIx?=
 =?utf-8?B?WFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c9d8d49-2e3f-4129-5e90-08dbbe1b5456
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 23:01:19.2573
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zTetVg2zNU3QrHDTXA3CSwEQ01A2cqquhpJ0QQqhkAOwii+JxXhTpuBnu7QSmp33jSxYOG7AkdlHMeeCxvAi3dM5wbN8YgtwT6CAd3s/yw4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6240
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 16:01:37 -0700 (PDT)


On 9/25/2023 3:55 PM, Yury Norov wrote:
> On Mon, Sep 25, 2023 at 3:46 PM Jacob Keller <jacob.e.keller@intel.com> wrote:
>>
>>
>>
>> On 9/24/2023 7:05 PM, Yury Norov wrote:
>>> Now that the only user of for_each_numa_hop_mask() is switched to using
>>> cpumask_local_spread(), for_each_numa_hop_mask() is a dead code. Thus,
>>> revert commit 06ac01721f7d ("sched/topology: Introduce
>>> for_each_numa_hop_mask()").
>>>
>>> Signed-off-by: Yury Norov <yury.norov@gmail.com>
>>> Signed-off-by: Yury Norov <ynorov@nvidia.com>
>>> ---
>>>  include/linux/topology.h | 18 ------------------
>>>  1 file changed, 18 deletions(-)
>>>
>>> diff --git a/include/linux/topology.h b/include/linux/topology.h
>>> index fea32377f7c7..344c2362755a 100644
>>> --- a/include/linux/topology.h
>>> +++ b/include/linux/topology.h
>>> @@ -261,22 +261,4 @@ sched_numa_hop_mask(unsigned int node, unsigned int hops)
>>>  }
>>>  #endif       /* CONFIG_NUMA */
>>>
>>
>> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
>>
>> I might have squashed all of 2 through 4 into a single patch but not a
>> big deal.
> 
> I just wanted to keep the changes more trackable. No objections to squash 2-4,
> whatever maintainers will feel better.
> 
> Thanks,
> Yury

I'm fine with keeping them separate.