Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <72d6854a-719f-e941-8b56-eda4e3027c66@intel.com>
Date:   Tue, 26 Sep 2023 13:52:46 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 1/6] iommu: Add new iommu op to create domains owned by
 userspace
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-2-yi.l.liu@intel.com>
 <BN9PR11MB5276A8E4869C48A2419CBA5F8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276A8E4869C48A2419CBA5F8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1pQdGJUTW1KMk1xc2JZWDI2V1VITFZ3SmdaQnBHZFpvWEtja2JmRFQ5RHc3?=
 =?utf-8?B?dmhqL0grY3MzTERDNHdtK0hLNmUzalVLazZKSXdhMjhqMzJTOXNGd2ZGYTU2?=
 =?utf-8?B?bzliWklUMUhEaUcxQ1ovMlZ5T2lodWNRcjhzVHNTQnZKbFBYbkNHS0RqNUdV?=
 =?utf-8?B?YWc5Rmk2d1ozZ25sckpNUEEyc3MweVdyYTdkcmNKbXFVbFh5MjdEdk1vUC8r?=
 =?utf-8?B?Y2owK0JoUGZROGtKMHZNb0ZQNzkySzB2aEdlc1pEbFlKR1djSS95QVh3NEpU?=
 =?utf-8?B?QThhZ1o3b2twYTZBVzI1ZGRQNnlNdFJTTE4rUkNKMk4yY0k5Y3lWREpuY1U4?=
 =?utf-8?B?dlJPSjdLemxjb1dDWFk4VFAzQVN6YXhjRFJraVJzU2UzbmEzLzhHQVJ2WTVx?=
 =?utf-8?B?d0pQSnZmek1PM0kxY3czWjBVdHlSa2FJWEhNR2tEK2ZUTTAxS2dhdkFWSnJ0?=
 =?utf-8?B?ZjhtWkYxbG94cWl6VFpWMkdTNzBKbXRLdGlsVkVNMHFOb3N5YTFpdExPbHZ0?=
 =?utf-8?B?UDdhZndlRHl1MTBjWHI0L2NzYlloUHdsdFg2MGdYTzN6cnRiNWpQdGl3S1lN?=
 =?utf-8?B?K3J1aytTamNLbVNQWjUxK3lMbHhVUVY0ZTQvUGo5OFprRW9keUhUZHorN3BM?=
 =?utf-8?B?dld4Y1FDT05ZUVB2OEtDSU11azMwTVVQK01vZno4NDdNS2hNcWgrNE52REVy?=
 =?utf-8?B?RzI4aHE2dkxXSXF4NGNtWE13ZExGekVOUWlhRVhhR2hzeHB2Tk8vV0pRWUF0?=
 =?utf-8?B?QXN5cHBUdXJUY0tpT1B0d1ltWUhnUW1JRnZIekZDM21jcXRMb3RYSTI3alky?=
 =?utf-8?B?SjFaUmRvbkk4TnN0Q2RlQ05FZWhkTWVYVW9QZCt4SzJvQS9UUm95amF4YmJN?=
 =?utf-8?B?NHJiNmJjNWRKVDJ1OHRXUjR5TmtWNk9jek1TSEd5dTFxT0pNdXVqVXpwQ1p6?=
 =?utf-8?B?Q0FuKzhDZUQzeFpIeTZxUDZSNzBwa2Q4YlZXY2l0RWROeUVYTjAyeElQQWhL?=
 =?utf-8?B?OWgrOUpsOSs1VjhuWUVSWlhGK1VwY002cWVBNmxabGdHTWFYY3pPbGwyUm0x?=
 =?utf-8?B?dFNVUHRmTGw5dkVscVVqckdQOHRLSmE0SjdBWFZuYUV6aUVHRGJrUDRpQkxT?=
 =?utf-8?B?WFdpK3NCRzhJTkNmTWpWM1hjVll0M2dlZUhOQVpBdEVaRXlzeGkzNmhJUUov?=
 =?utf-8?B?bEN3UjBTQXNYNWIweGtFSXpKdlBrOCtoS1QwRVE1TWZ5Z0Jscmk3VnFWdkFs?=
 =?utf-8?B?T3F2RlFMTkp2U0hEdlZ0a3ZEcjR3S0syT29OclhrNjZOSHpkaWhIbnJUaHFG?=
 =?utf-8?B?SCtseUhFU3RoM00xQWRoUUp0K1pPcTJHbzJvWktvTjZIZ1RXemwrS2JDUmxW?=
 =?utf-8?B?M0pVRkRRS25ZSDlIZC9WR3J1VXkxUDJ0dVpibG0za3U0Z1JEYlQ5NXJoSncw?=
 =?utf-8?B?Z2JsandHdUpyNGQ0cGZONUdBdVlEU2lDUVEzNERnOGpqOVJwYVhGeGxyWFNl?=
 =?utf-8?B?TWwzVmwzQmQ1dFBHbGJQQWdUbThZUm12YXRhRnVuYU1aT2gyNExVdzA2UWp4?=
 =?utf-8?B?am9Sb3VrU21kT0dleVhtaW40VHVVWlhXS0lqeDJJK3h2am5aSURma2dGZjZD?=
 =?utf-8?B?bTlVYmZ1MzNDT2Qva3p3UGRnNWRwRE5Ga0dtS0IybHB3Zk9tME1GYWtuOGRz?=
 =?utf-8?B?NStVT2w3cUpjMFREd3F0cHpBVFNpbitIQ2QwMW1NS2lEN1pudUU5M3ltbkUx?=
 =?utf-8?B?WnJjYjNtS21hcnJzc00wL0pVS2VYYUpFcjc0MEhtWGZtR2ZIaHMzNE5QM2FP?=
 =?utf-8?B?elIzWXM5d1lsZk5DRFJmVEVwYzd1V0MvYkY5Vkw5UDBEVG11MlZSeGEzUGJa?=
 =?utf-8?B?cGZJdHBPOVlua0NSMkptRUlVNi91NFRpR1BqcW5CUG1PalB2cWtxMzVPSnIx?=
 =?utf-8?B?N1duc0dKUVVDUE40eXlCZm1URGRubjV2NkdNT1ZBZWdSTEhYZlBmTENwdkJM?=
 =?utf-8?B?MGVtZy84N3gxaWoxQVZIak05eVVMemJaSnFtV05KYkFPM0FOOVMyazRPUjUw?=
 =?utf-8?B?TFptZkdRUThzL0RtN0Z1Y01TUElJbjRXbHM5MDlXRlU4aE40Z0RXbnR1TXdW?=
 =?utf-8?Q?oNPl7lZKjORUtU/eiPJ9uAwUf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bf9737a0-021c-4c44-f377-08dbbe547ee2
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 05:50:32.1694
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vh/prv1h+gNMFbLr+neg+j04EQsEaFiMQ9wsRVn7WRR5pcd2wwEDYHkb1nlPzGs1qdRBgwy/Dn1NArtTcmE3tw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8012
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 22:51:01 -0700 (PDT)

On 2023/9/26 13:28, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Tuesday, September 19, 2023 5:25 PM
>>
>> @@ -235,6 +235,13 @@ struct iommu_iotlb_gather {
>>    *           use. The information type is one of enum iommu_hw_info_type
>> defined
>>    *           in include/uapi/linux/iommufd.h.
>>    * @domain_alloc: allocate iommu domain
> 
> Given now we have two @alloc ops it'd be clearer to also update the
> comment here so the explanation for @domain_alloc_user() is easier
> to be understood, e.g.:
> 
> @domain_alloc: allocate and return an iommu domain if success. Otherwise
>                 NULL is returned. The domain is not fully initialized until
>                 the caller iommu_domain_alloc() returns.
> 
>> + * @domain_alloc_user: Allocate an iommu domain corresponding to the
>> input
>> + *                     parameters like flags defined as enum
>> iommufd_ioas_map_flags
>> + *                     in include/uapi/linux/iommufd.h. Different from the
> 
> "to the input parameters as defined in include/uapi/linux/iommufd.h".
> 
>> + *                     domain_alloc op, it requires iommu driver to fully
>> + *                     initialize a new domain including the generic iommu_domain
> 
> "Unlike @domain_alloc, it is called only by iommufd and must fully initialize
> the new domain before return".
> 
> *domain* here already refers to the generic iommu_domain struct.
> 

above comment well received.

-- 
Regards,
Yi Liu