Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1699626rdh; Tue, 26 Sep 2023 00:12:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHBOwqe34HfI+b7BAciF+tXiy1GqwdLQXCqIXnOAnwG2UKtYZVjedkgn13/2d0I6Ff8NLJL X-Received: by 2002:a05:6808:2187:b0:3ab:83e1:ef6d with SMTP id be7-20020a056808218700b003ab83e1ef6dmr12906341oib.6.1695712335821; Tue, 26 Sep 2023 00:12:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695712335; cv=none; d=google.com; s=arc-20160816; b=u6QyJwLptVbrMXk412qFcwy/oKLEMGL6lZBLwcjJuYNGmj+hcfWc6OnpC2nH1ZAsu2 8mxNHSjtVQabny2A9JhCWXiy8CWcbh6XnVxTwNon/vlfCwf+uBaSUS5muNbJTjSF8fuC 3K3+lGFA1nMV9It4xMyZjVSN0JIZcUmB/TUs1k43rZa9DzO2tP3CmP+wWH4ezprt9HyM CYnZCF8efJaa7AqTTILi/tAKCptGn/IOYKVKtSqQ2anargr8PmE+/yk4Hqqmixo61S89 ZEv/H29VUlMibSYEouIjMzdo29Lk61u0Z91I6JSREdA+o+RSmD6KH1SmVms+rndxpWAP 5SQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:subject:cc:to:from :date:references:in-reply-to:message-id:mime-version:user-agent :feedback-id:dkim-signature:dkim-signature; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+H/CZgEis=; fh=Jhw0mw8itBUd7uOc5p9JthF28c5+rps1oklFx6RzaoU=; b=jiUiJUBkX3kvKqQLmBPS97udR2MPD23BsnfybWBXSjh38y8uH98f3vcp+w+lcJdYdV PInyzdDmf6e8EC6S698TLfTOTA48jaNmcYghTR2R4AxuyixW623vyaYjKtQHKdqCu33f kPsv4TNHDjM5J4PJzFG1y+gMCc8wK9MEf763eyUlhlR9Czgp5Rzb1K5s1ZDcCp2xqLwG rvBp79ExdJwKTc23TXmK4SaxvKF09VvaVu8HphxEfG072sMWYZCAUg95psV/2W96JVq3 u9mp6htm/4p2Ly8aNLl4D3qLM5AfJkFaQSKEmpdb2PGY6FnmE7NhmSv+YT6z7L0gzJdw bR8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=eiMP9I+G; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=bjG9ANdS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id fo10-20020a056a00600a00b0068fa57cc15bsi11878624pfb.124.2023.09.26.00.12.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 00:12:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@aj.id.au header.s=fm1 header.b=eiMP9I+G; dkim=pass header.i=@messagingengine.com header.s=fm2 header.b=bjG9ANdS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 57F9C809C42B; Mon, 25 Sep 2023 18:31:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbjIZBbR (ORCPT + 99 others); Mon, 25 Sep 2023 21:31:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229486AbjIZBbQ (ORCPT ); Mon, 25 Sep 2023 21:31:16 -0400 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2473810A for ; Mon, 25 Sep 2023 18:31:09 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id C1FA85C017D; Mon, 25 Sep 2023 21:31:06 -0400 (EDT) Received: from imap50 ([10.202.2.100]) by compute6.internal (MEProxy); Mon, 25 Sep 2023 21:31:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1695691866; x=1695778266; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+ H/CZgEis=; b=eiMP9I+GYtijmNB30gzVkjhrZ07gKOEGyhOfsl71Wzz33L1Sny1 rX4v5syH41sqU0+lwNZlnCazh3LYB6X+k0rPvmIfRJEwcAXCvEqdTpviZyiljv6A NqZ2EQQ+h840ORSuy8oXXoOHBQT7fNUVJFyixPzASnlNthryoEC0Bqe6BLuVRSjP unUwITl8Opus4zcdK8iYAtEWOzrobHEFroXwjN+RkHfSzjhG98u/UqaeLs+/HIfW UgLcg6lIY0LLMZiX5quNk/UJowncsfD7P39lE583/OF8ZPs5ezodkxX1kVQBbAfr fa3Mwqj08cYPDW6QsTqOh1CPkHsY/cid5OQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1695691866; x=1695778266; bh=w4gsiSlns8NKzCbLupKqwoRRqRNO/EeFJL+ H/CZgEis=; b=bjG9ANdSBUgpnplqMQZ5v+3DZx/VmzCVt4tn9IXyRJVkA4gZW3v qsKptQKPqZ4OKB/sJG/kuBfoKLVeSswySMaledWcp2oLuroGP9w/yDCrtUbGP6Bk pDF1cEkXFzMD9tjLf1j9o4RCn2WTTsFxrL1P/7VKd2wTBH+bbfcwa8WrLgMcajnY Ygo7+8EPbmgNvLao2+WWhy437Mmq+ExY/Edc9ceiX0fO1WjVbH/QpqNtsW5Ni/vA tmkuq8Xa+niEwneJFXwa2YxjfCeAWPwxHgLrApA/0Wtg/uJiVsrbpe/IJ+oDOuWI MvVrI5+rR25WdvR9orz8LhXeqLHoetF8+/Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudelhedggeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtgfesthhqredtreerjeenucfhrhhomhepfdet nhgurhgvficulfgvfhhfvghrhidfuceorghnughrvgifsegrjhdrihgurdgruheqnecugg ftrfgrthhtvghrnhepgfeiieettdelkeehffevieetgeejgeffveefhfffkedvudefuddv veejgeehheevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheprghnughrvgifsegrjhdrihgurdgruh X-ME-Proxy: Feedback-ID: idfb84289:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 398831700089; Mon, 25 Sep 2023 21:31:06 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-957-ga1ccdb4cff-fm-20230919.001-ga1ccdb4c MIME-Version: 1.0 Message-Id: <39fe757e-0b0c-4aa0-9150-29bf4e255788@app.fastmail.com> In-Reply-To: <20230925095532.1984344-3-u.kleine-koenig@pengutronix.de> References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-3-u.kleine-koenig@pengutronix.de> Date: Tue, 26 Sep 2023 11:00:44 +0930 From: "Andrew Jeffery" To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , "Joel Stanley" Cc: "Rob Herring" , "Arnd Bergmann" , linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Pengutronix Kernel Team" Subject: Re: [PATCH 02/40] soc/aspeed: aspeed-lpc-snoop: Convert to platform remove callback returning void Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 25 Sep 2023 18:31:24 -0700 (PDT) On Mon, 25 Sep 2023, at 19:24, Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling = by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Andrew Jeffery