Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH 4/6] iommufd/hw_pagetable: Support allocating nested
 parent domain
Thread-Topic: [PATCH 4/6] iommufd/hw_pagetable: Support allocating nested
 parent domain
Thread-Index: AQHZ6ttUjfPwGBMFl0qs/bqpL9atnbAsn3Ow
Date:   Tue, 26 Sep 2023 05:32:08 +0000
Message-ID: <BN9PR11MB5276DBCF4B2DCF894C4E53278CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-5-yi.l.liu@intel.com>
In-Reply-To: <20230919092523.39286-5-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2Cjjr5shgowALZjSNFS6e1pmw8QYK31HKZj4Rtk09G9f4RK8rKLC3WhzvxN3?=
 =?us-ascii?Q?0FWUI73XL4RkGrqlbR6MAMAUU7Se4tASw6xM2Fu+1WegS6cj1IxgrhSimykC?=
 =?us-ascii?Q?0fbI9dU81W2GAW7Lj30s1lxsE3XeGr19grVOLk/8ygedlwEg1JoDSndJr1kE?=
 =?us-ascii?Q?veEecP3QJqn4VVGzud1EI6AoMV4sOx97Avxala3wPFRGGz02Nh8bBAyJbqBT?=
 =?us-ascii?Q?hbfaradWomVZQ+XVOWWrILU4HgFiCPnpkSM8z+DslZ9eAkEiSO200o6ZX6CD?=
 =?us-ascii?Q?5SqVasRjCShr6pZJciu6aMTOmApQ5eMRHyA0WOxQc3ZvcXZ6nNUcCg4cpKDV?=
 =?us-ascii?Q?M+EQXi7u7jqMeKBzfXEq6t7GZZsrso8vIfUTog7pIGrEE9m9M4/enZZd9Oko?=
 =?us-ascii?Q?QC+WgzoL1RMRrVUoAbitjwdDDGrVKMcEahg48DCRhBCK1I9ZX4Qz3yzioJwX?=
 =?us-ascii?Q?mOzwG453GwXLMOaPpLkWpS67shMwYq+3sP55vfd/VuY1lWsrRzbPlZM1QWKG?=
 =?us-ascii?Q?IXCqTDKNvK0aEKzR0nIbvaSCQW63ss7lyXZaZSV/gO7p7Ayt18AHF57+DgHe?=
 =?us-ascii?Q?pDPzEa2HhrOblZ74RyqgEeY2wlkY4H7lSctsbr3leu1syRKvGhhtJjGP6bBx?=
 =?us-ascii?Q?NtZJ9UzRCxz7Pno2/uyHJMvwgTvZ29ew5v+hzv50hOQzhnaWRSSUuyKLZfd0?=
 =?us-ascii?Q?pH1iy9JjSEFsG35CceI8zVfAh4SPPomLwvkPM445EMmVzcaZd5S5gJmGrrwJ?=
 =?us-ascii?Q?Pj41i6ar/tX2yQdfC1dcOFx1gQ5IE641EoL9p9KZw6gNpANUlyPFjVhGey9L?=
 =?us-ascii?Q?MtupccXzpGlh097WFhF8bWVqc+EDCdR35KUZM+v3mBcD3AjdmFSrEifO6R1W?=
 =?us-ascii?Q?DgnPMaDj87XtCqPtY7LiWvQ74tXfH/l3Op6eC4n8vBtN/j4TTjuSNebkPJPX?=
 =?us-ascii?Q?E7GbcxFDz1H4+tVtoj1lV13PWbOnVHTb+e+z3VrnRYZmKoCbOXWms7LJeWoL?=
 =?us-ascii?Q?ueSUsgMWr6ZljAaE9oyyplAaXhIhapa9MzsH/GfkcoPP0X2xSAKMTdXURLn0?=
 =?us-ascii?Q?L2WmRnRyOFImEmb0QGLqJfwgcyjKo+022wG5dPZLg3QE90yt3O+oJUdcQais?=
 =?us-ascii?Q?GVUlH5nvntSni7yrcv2clE5JpnpyZ79Y69n/NvmIYAxAWVuGW/sFhfcghLId?=
 =?us-ascii?Q?VMtDcOZE5H/tYqd96pbx+DlO1Y4IDyh3ki2M7r6XlPIeDayg/9ACuMVQGfbp?=
 =?us-ascii?Q?SLMccql55bOssE1xm6BIzXVB2a53aRRCxQvpHS/klBCGkPuLzoG4dCJpBUeb?=
 =?us-ascii?Q?xXRs20cq/L9wvgEIFPgdinelqs+29p4Y3KHj204ViMEgaNgUu+tO+bD1lVUM?=
 =?us-ascii?Q?bm2TE9HpcjBbEeT3YEzzRJofD4DFoHDZULDeJ80+tSxgYKIZ5iHnqKD5YQBV?=
 =?us-ascii?Q?zLVE1Ik812c2TSACzy6wXGO3vsyrHM2EVSiAYNvzmzvdUusldiGgNL0DadpF?=
 =?us-ascii?Q?jqS4raRyCS54Q6aKCRAs97UMPXKZZAms/zyzrJoMpM1/HDJkOHHlFbmoW2NN?=
 =?us-ascii?Q?xjGHk2kity90VPucVrUD6ZJYstX8ciogcrNJBF6N?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cd2b40bd-e0e1-4d93-6ea4-08dbbe51ed21
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 05:32:08.2995
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: G/g3BqZd8S0+AqSDHLmGdpR90meLuho6qOCTDhWGqoXy+5iwSY18tCYcVAcdgeupcer8kmtyVOOlA0QDC1WNRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7339
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 22:32:45 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Tuesday, September 19, 2023 5:25 PM
>
> @@ -83,6 +83,9 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx,
> struct iommufd_ioas *ioas,
>=20
>  	lockdep_assert_held(&ioas->mutex);
>=20
> +	if ((flags & IOMMU_HWPT_ALLOC_NEST_PARENT) && !ops-
> >domain_alloc_user)
> +		return ERR_PTR(-EOPNOTSUPP);
> +

if (flags && !ops->domain_alloc_user)
	return ERR_PTR(-EOPNOTSUPP);

as long as flags is non-zero we'll need the new alloc_user ops.