Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1711467rdh; Tue, 26 Sep 2023 00:43:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGHeAcfLLZdkpvFEuX+RluOJYXcmP8DTHneKvOlSsZ1uFNtqXJa9UDXSb74lSCzZY4ndj8W X-Received: by 2002:a05:620a:2698:b0:771:7698:7c51 with SMTP id c24-20020a05620a269800b0077176987c51mr10591492qkp.16.1695714214046; Tue, 26 Sep 2023 00:43:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695714214; cv=none; d=google.com; s=arc-20160816; b=XtIwghho40Vuop0RiqbAyiALQi2oy3XC0pjygCj8p8aGHsc4MgDSD+RE2Y5WZC5Q09 Snyx65rlpP5h8T/+HWDxGU7n7nuBNLuEjWxbusGorR2j/cUmtURO6YbYgxNuaVf9qaLW +fxjBGzWTsTVPzVgKi1TZaoONTrYho+Zvlv+Y5of8o7eF01anm2O9ujunqhwchPiUmYX dxzwM07b/kB8+/DzcoNXpGJZHpuGEtkKrush6k2r44o2YMcYTqkbQGhcXL4fH9humcvO pe/xyrAMjG1jRJNN5GiZTOoAxMEVFziGyYwAeY3MVxyVYiaNX2cFCfjRvcmX7LA1u8bs /OrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:to:content-language:subject:user-agent:mime-version:date :message-id; bh=g45dcWC8ukue29AjnQYRbJKrWV2twu3b5LBo+9TnmSU=; fh=vP3d9L+Q7bFMgakUiJeeXEGMbxQd8XZf8LRSTNfXNBs=; b=aeD7Va/sX37a2mcSNoN0lJXtCc8YbtqOc+n46T8/UB1mNxDad/6S0/osioQlQhwi9/ EVddRoaUPclIjwjLtxXVIJFhtcpE7+LFxCOwIEGGn3cYuXAOuQzH/JzgcA9ciknJE4+/ j7M6Z2FazC33ABMOx0fsTtxYtYU7OXXbylwp4VASdctgdd5nzoGBD/kUsfb91aIDYWQb igRF8rEv/naQSLnDX/zio9CN8m/oRYhYs6KZd/z0UvLWXzK4Srcxpr7QyIeihOanKT1/ No8MjjYVzGCPoKVJF1rTHi+lrV9GuCfn8vsnFndq0d2HvapTncNPKG6I0xAyqKFJ4yKK IM7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id x186-20020a6386c3000000b005648d3f2031si11411846pgd.362.2023.09.26.00.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 00:43:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 07822825B4B2; Tue, 26 Sep 2023 00:34:21 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233516AbjIZHeU (ORCPT + 99 others); Tue, 26 Sep 2023 03:34:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233448AbjIZHeR (ORCPT ); Tue, 26 Sep 2023 03:34:17 -0400 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F143DC for ; Tue, 26 Sep 2023 00:34:11 -0700 (PDT) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4RvrxZ46TCzMlrn; Tue, 26 Sep 2023 15:30:26 +0800 (CST) Received: from [10.67.109.254] (10.67.109.254) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 26 Sep 2023 15:34:07 +0800 Message-ID: <57ce70f7-2b5d-384d-d14e-b9e96e3ca636@huawei.com> Date: Tue, 26 Sep 2023 15:34:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 0/2] static_call: Fix two wild-memory-access bugs in static_call_del_module() Content-Language: en-US To: , , , , , , References: <20230915123605.3732345-1-ruanjinjie@huawei.com> From: Ruan Jinjie In-Reply-To: <20230915123605.3732345-1-ruanjinjie@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.109.254] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-2.2 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 00:34:22 -0700 (PDT) Ping. On 2023/9/15 20:36, Jinjie Ruan wrote: > In __static_call_init(), any one of the kzalloc fails will cause > wild-memory-access when traverse the site and subsequent sites in > static_call_del_module(). > > Changes in v2: > - Add a new patch which fix a a similar problem. > - Update the commit message and simplify error stack for the first. > > Jinjie Ruan (2): > static_call: Fix a wild-memory-access bug in static_call_del_module() > static_call: Fix a wild-memory-access bug when > static_call_key_sites(key) is true > > kernel/static_call_inline.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) >