Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <8e459e7b-2951-e252-b1ec-c2dd6d047aff@intel.com>
Date:   Tue, 26 Sep 2023 13:50:09 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH 4/6] iommufd/hw_pagetable: Support allocating nested
 parent domain
Content-Language: en-US
To:     "Tian, Kevin" <kevin.tian@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-5-yi.l.liu@intel.com>
 <BN9PR11MB5276DBCF4B2DCF894C4E53278CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <BN9PR11MB5276DBCF4B2DCF894C4E53278CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bm9qaWdUOXlKZzVUeVYwZFFTWjQyQm12b3U5Y0F1UXZCN1o4UTM4d2lucVpq?=
 =?utf-8?B?TjFPcDJOdTF0ZG9VTWJabVFMN1Vud0FDRGRTcnpQa0Z0cGVCbFdZN1YxdlVL?=
 =?utf-8?B?YmMwRUxrbWZlSFlCcnFpZUhnMWdyeVZuTlN4TkZJcEIwTUxmK2JDSzB6VElu?=
 =?utf-8?B?NDJVZ1g3R1MrTWFkS1RNbng0Rzl4K2NIMllMNVd3Um0wd2VuQzV6RFRMc3F5?=
 =?utf-8?B?dHpVb3lHM3FVRDVESndiTUE4bFZ3SCtsWkxEM2dxL0cxZk5aeDEvK3JZaENh?=
 =?utf-8?B?NDRBMzRqemtHRXlHRmxmemVFOHBMbnJmRlF1ekg1bnFZU0o5TnNXMGNoU0xP?=
 =?utf-8?B?V3RaZ3hjcjFPbTZSWjlUeFRrOC9wczhxbFpEV2RXV2tjYXpHRk40dTY0VzRr?=
 =?utf-8?B?cGFoZXVRZ2hQNHBVbXBTQ2U3STk3M2ZLK055cXl4dlpzclNlWTM4VDB4aXNT?=
 =?utf-8?B?UWdaZVBMKzZicy90bE5mRFgzOW9vSFZWdk5kKys0dXBITlV1TUtrRUwrZ1dI?=
 =?utf-8?B?Q0ovSjdEWjA5S0UrL2pSWEtoVUNBWXZtYnVMS1dyVnYxOTdlSVh2OTRBd2N5?=
 =?utf-8?B?UklkVElRRWY1ME44eTFGTGtsWVdTMm1ESG5BdVBReTlHR0NqN2VQNSt4bXhZ?=
 =?utf-8?B?Tm5kL2hGUTljQnhVYVRJQno2OEYyMmlVUmgrSGpMdlEyUkc0SFpISDhpSjgx?=
 =?utf-8?B?cFVoYjR4Sk9kNWRmNW9HaDF0SFkxTitUR212YUlvaHhVeXhIaGM3Vi9qK2pP?=
 =?utf-8?B?ZGMxbkR0eEpuTDBURjcrVnUrR1F2ak5obHVJU2xQNHl4VVh0NkVqbHRFdlBo?=
 =?utf-8?B?NDVTenlIdHZXOWhjaFVFankrUll0ZFQ2L2JnN2tZWmk2OVp4cnVwYUNhQ1F5?=
 =?utf-8?B?SnYxZnMyS2NtcEtXR3ZKZFAvb2pIZEJ3aEhqL2JUQVhvcFBZQTQ0RU5zSzdC?=
 =?utf-8?B?NjFDbzVtcjl6Slg3am9peCtLeFh6RjdrSlJrV0c3Vm1VRUlmLzFwMTNDMCto?=
 =?utf-8?B?anVqQUI0ZjNpSTFnMHZDTGl6bUh3QUJoaFdRWldmN243alBEWUlSYkkwQWRF?=
 =?utf-8?B?eFNwdUtFMzY3TVRKTFpGZzJuQnVMWkFvcm1QOTVDNFF0UkNFU0Q0Wk4vWUZX?=
 =?utf-8?B?TmNlSHRONDdxYUhDaEloNUNjOTd5Um41ZWhYM0FBS2tRaFE5SzBTWTBSaHpI?=
 =?utf-8?B?K2prSFBJeFcvSUJXeW1Kb1ZrZkx3RlVmZ0N2eFBnQUpDZkhLeUl2eUZud2ZE?=
 =?utf-8?B?U0lxa3FrUUJHY1gzTS9nbVA1SUNNTStBTngxbWJ1RDlWSk5ndDQyZXNWajd4?=
 =?utf-8?B?M2RKYkxDTUNmQ2drQXdhU3lIczhWYUVFdTJ5NU10WWNPM2NWb3RuS0UrS1Vs?=
 =?utf-8?B?em1QRWhRQ0EraGtwU3A5dFIxN25hWU90OFdBYy9tZHpyZU03Q0dWSGNJeTIv?=
 =?utf-8?B?a1MyWHlZRzNJMWZ5V0t5WDlVeVUwZDdRSlBiZXlqdThvYW9LSWN2Q1gzZm5O?=
 =?utf-8?B?UnVNZXF1ZEx6YzdsVUlEM1FKZkpmYkQ1d2ExK21sbHI4VTJhMGl0NS9NVTBL?=
 =?utf-8?B?bmFmVkt5TDE3T0dPUjFqR1lud3lSdE1xTTAwWkdiM1M2Qlk0cFNVM0Q2Tmd6?=
 =?utf-8?B?NnNkb0ptbWE4WUVEbXdZemFDUGwwWUdWSWxuSGJ5TnNXcndIOEwwSzBFeFM4?=
 =?utf-8?B?MVdtNWRLc2J3czNtRUhsS1Rmc3JhSmFram9LTVlZNCtOMjZtRDJXZE1ZTG5K?=
 =?utf-8?B?Z3AvT0h2WFdYT1lib2hBMWY0RzVmSzd6T0lJUzBMU05GWXptRnB2SnRZQWg2?=
 =?utf-8?B?Y1lYK3BEbjkvR2dxMHpvNGxLdDY2Rjc1aHVTWHdDTndFcUdQNmx3WkZoLzhv?=
 =?utf-8?B?MWoyZVdTTm1vZVFUbk9DUkMwQnBIc2RjOUtJa2FobFNqUkR3bXROQUw5UDAr?=
 =?utf-8?B?NEtNMTI5c1I0SHhMOUg3U3NBNWVHaDNsUUQzbDhRTklLTC83ZUtHME9MSVdE?=
 =?utf-8?B?ZEUyY2UyZERzVmc3ejljTWk2QTNqTW9YQnVtcFJVZHZvZi9wOHcvazU4alBx?=
 =?utf-8?B?N3djMmhETFBXOC9XcHhwUlYyNFZrU1dCb1JMUUdrREl1SSttRW9WbU9KUjVk?=
 =?utf-8?Q?H9Mlmy+09r4mfjljb2jFRlYXC?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e269d7c8-6ec0-4a87-6c28-08dbbe541f38
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 05:47:51.6746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qAGUttno3lFZilVN0Tm8k3TkJpeO0sdTg7vVQp9Mi/hxSRNlV84rkKCoAbHDPrbhnFUYkxHVew8hElT4eDGRdQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB8012
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Mon, 25 Sep 2023 22:48:07 -0700 (PDT)

On 2023/9/26 13:32, Tian, Kevin wrote:
>> From: Liu, Yi L <yi.l.liu@intel.com>
>> Sent: Tuesday, September 19, 2023 5:25 PM
>>
>> @@ -83,6 +83,9 @@ iommufd_hw_pagetable_alloc(struct iommufd_ctx *ictx,
>> struct iommufd_ioas *ioas,
>>
>>   	lockdep_assert_held(&ioas->mutex);
>>
>> +	if ((flags & IOMMU_HWPT_ALLOC_NEST_PARENT) && !ops-
>>> domain_alloc_user)
>> +		return ERR_PTR(-EOPNOTSUPP);
>> +
> 
> if (flags && !ops->domain_alloc_user)
> 	return ERR_PTR(-EOPNOTSUPP);
> 
> as long as flags is non-zero we'll need the new alloc_user ops.

yes.

-- 
Regards,
Yi Liu