Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1760126rdh; Tue, 26 Sep 2023 02:44:28 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEoq91rOKFfueypN6F6qY/BmFA+x8YMGja/teosr/iPHJSY6RH514gUKJuHEGRCLVhARA94 X-Received: by 2002:a05:6359:59e:b0:143:688f:dc03 with SMTP id ee30-20020a056359059e00b00143688fdc03mr6380358rwb.2.1695721467871; Tue, 26 Sep 2023 02:44:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695721467; cv=none; d=google.com; s=arc-20160816; b=SPIkvX0I1xRJlq7EocPp+vuka+frwfJFx6q8BX4nGBehbSTRAzN4wwZavSmokHoyKp BqM8qqe5/985i/WHVkrDVvy3DjFaLWI1h0UBii2bD6sQ9AxGYlWXkzLMvsuJvVlYSboa /6JFXqxj+3wqOSpD3evd+PULMDLPUbMJmuqs9DcSKbCyIfbXlsXS7A1FgFsAjDHdUgxe NJxbvimPtshn7z4iA3ZHTyPIH8+2q9f1hBGHaunEONbxPTFtb8aKZ18JtwHCmPY6XAyH 54zBhidg6Z5kYOqz6wX6n10NcfxQxl79uvdl8gIlWnMXtzGAAOzXOxMP3JJu7WMqb0NL l9kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OXEGc233FwgZTzVRao3yByWflP5aysEGD2O8UZNBZrI=; fh=DQ4iYRSMLAEi5vZHJLJxXHYGayqB3vG83MXII+z0OHs=; b=Aym8eeNRKpsYPhkr0yuRDzSNTTW5D9NExyhHDLOENE6Rbx0uJV64nW+Z1S8wPOZzJf Ko0YbeRohjD/l559VscWjEzK1s5L3SvsyaWw8UOZAw5a71QdOYm6M/gW96HOp1G9AJ+V IuibbDuV0WcffhNUIn8IZACcigVKJxeQA5glTC2eOLEyWYSIdwMRbicNoOasNV7p1puH vNSp2ZjxsNm2g7joDG/tNAvkrX6FzeeNOjtotBhzMqT9rsEo8J57YCLvt2ICgBr69as3 DRqaqzpa0ig5Q0BDfmh/SAi9eJN/DU6QBX9tXtn2Ua023qBEonkNgVvkHD4Up7Cgnqm5 lVcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kW10MjOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id e26-20020a63545a000000b0057828b85ae6si12177672pgm.281.2023.09.26.02.44.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 02:44:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kW10MjOW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2C4F78093435; Tue, 26 Sep 2023 02:31:08 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234240AbjIZJbE (ORCPT + 99 others); Tue, 26 Sep 2023 05:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234225AbjIZJbC (ORCPT ); Tue, 26 Sep 2023 05:31:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EA4712A; Tue, 26 Sep 2023 02:30:50 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6AD69C433C7; Tue, 26 Sep 2023 09:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695720649; bh=hj4oxhOkY4q3xTfX5ieHdoLzD+mLcLaLDO8XnC6wpXI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kW10MjOWGXCIICnfagr6XcT9Im7CQZjdm9bT1IhfwzLWOa/brK9fo0al2Nmc3o1Wy ric8CucrtnCGkTXN/4oTdNdb5LlIwhyGyk1vbuy3RrP7vx9sUF37yKOmL7Nj3Ab8/0 IenBaFbogr9fJvlk84kVZFmZ+INx8iIYrXC2yf0AHqK/7TORqZNvE33vqibQQib6Kt S1FgXH6p30FKqzbHsQduKb1hP7Xah1EwPhQrAsEZWBb3uPcDhpPhhXiTLyIlFoD/Du hjYM8vaaYJr+6/a9/+1QcixYCwGmRglkygFkWh7qtseYDHGqLlU8hUBuhXI6vMLUkd rxiNZhAs9wfoA== Date: Tue, 26 Sep 2023 12:30:46 +0300 From: Leon Romanovsky To: Junxian Huang Cc: jgg@ziepe.ca, linux-rdma@vger.kernel.org, linuxarm@huawei.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH for-next] RDMA/hns: Support SRQ record doorbell Message-ID: <20230926093046.GG1642130@unreal> References: <20230920033005.1557-1-huangjunxian6@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230920033005.1557-1-huangjunxian6@hisilicon.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 02:31:08 -0700 (PDT) On Wed, Sep 20, 2023 at 11:30:05AM +0800, Junxian Huang wrote: > From: Yangyang Li > > Compared with normal doorbell, using record doorbell can shorten the > process of ringing the doorbell and reduce the latency. > > Add a flag HNS_ROCE_CAP_FLAG_SRQ_RECORD_DB to allow FW to > enable/disable SRQ record doorbell. > > If the flag above is set, allocate the dma buffer for SRQ record > doorbell and write the buffer address into SRQC during SRQ creation. > > For userspace SRQ, add a flag HNS_ROCE_RSP_SRQ_CAP_RECORD_DB to notify > userspace whether the SRQ record doorbell is enabled. > > Signed-off-by: Yangyang Li > Signed-off-by: Junxian Huang > --- > drivers/infiniband/hw/hns/hns_roce_device.h | 3 + > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 30 ++++++-- > drivers/infiniband/hw/hns/hns_roce_srq.c | 85 ++++++++++++++++++++- > include/uapi/rdma/hns-abi.h | 13 +++- > 4 files changed, 120 insertions(+), 11 deletions(-) Junxian, do you plan to resubmit it this patch to fix kbuild error? Thanks