Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <75d28233-c8bd-4528-a775-8ccdc7fc3e26@huawei.com>
Date:   Tue, 26 Sep 2023 17:39:23 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH -next 8/9] mm: page_alloc: use a folio in
 free_pages_prepare()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     Mike Rapoport <rppt@kernel.org>,
        Matthew Wilcox <willy@infradead.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>, <ying.huang@intel.com>,
        Zi Yan <ziy@nvidia.com>
References: <20230926005254.2861577-1-wangkefeng.wang@huawei.com>
 <20230926005254.2861577-9-wangkefeng.wang@huawei.com>
 <b7818a38-d991-6cdd-c908-fe0ebc3677c6@redhat.com>
From:   Kefeng Wang <wangkefeng.wang@huawei.com>
In-Reply-To: <b7818a38-d991-6cdd-c908-fe0ebc3677c6@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2023/9/26 15:49, David Hildenbrand wrote:
> On 26.09.23 02:52, Kefeng Wang wrote:
>> The page should not a tail page in free_pages_prepare(), let's use
>> a folio in free_pages_prepare() to save several compound_head() calls.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>>   mm/page_alloc.c | 15 ++++++++-------
>>   1 file changed, 8 insertions(+), 7 deletions(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index 06be8821d833..a888b9d57751 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -1070,6 +1070,7 @@ static __always_inline bool 
>> free_pages_prepare(struct page *page,
>>               unsigned int order, fpi_t fpi_flags)
>>   {
>>       int bad = 0;
>> +    struct folio *folio = page_folio(page);
> 
> We might have higher-order pages here that are not folios (not compound 
> pages). It looks a bit like this function really shouldn't be working 
> with folios in the generic way, for that reason.
> 
> Wrong level of abstraction in that function.

Thanks for your point this, also the change also looks unnecessary too,
the main purpose to use a folio in this function is prepared for
converting page_cpupid_reset_last() to folio, as the higher-order pages
the next patch is not right, I will reconsider it.

> 
> What am I missing?
>