Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH 1/6] iommu: Add new iommu op to create domains owned by
 userspace
Thread-Topic: [PATCH 1/6] iommu: Add new iommu op to create domains owned by
 userspace
Thread-Index: AQHZ6ttG+pOroHJpaUK6j3B03cTda7AsnJDg
Date:   Tue, 26 Sep 2023 05:28:13 +0000
Message-ID: <BN9PR11MB5276A8E4869C48A2419CBA5F8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230919092523.39286-1-yi.l.liu@intel.com>
 <20230919092523.39286-2-yi.l.liu@intel.com>
In-Reply-To: <20230919092523.39286-2-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AaRtiRwTEQ3ajEOHmGENwsHBOTVC+SLM2frqmvmMTOvBJ2eGu4W+7GqQRcU3?=
 =?us-ascii?Q?oOMLVTwwKslqTCweYxjEtJN7oHi8Pc2ytfmQ9/GV8r02s7OlmbaWaZ2IysLR?=
 =?us-ascii?Q?kotI1fcW8XrqZeBx510KS4Ki4tbQW8HpnUoIsYBXCO/F0YkXWNm7O9vjBHLn?=
 =?us-ascii?Q?viU1zClF2hfu/lHZLs+sXfABY+vAGXAwhu8a5usP3SU03SYQPuxaH4qIrfMe?=
 =?us-ascii?Q?Ww8U06r2vMOT3f8N5vO/OCCsRlHVBpoNnsUWF7F6kx52A9Ab4zIlleO6YcXH?=
 =?us-ascii?Q?SP+ZiY8WZA8omBFxv6tzVODSy7TP73a0fo0fF0RA6AHTODQ9fsJMnc6wSD7g?=
 =?us-ascii?Q?m4wsIvjVgcggRcgm28tFbzwzw889jcAW9GeiVyjyalvi4et8jAyBFEiniHL+?=
 =?us-ascii?Q?+f7nYJT/Y1onUTVnHvEJGN61n0KIlZdadkPINOkH0tlL6RLD1h5lI5OiBoWS?=
 =?us-ascii?Q?igPol+8ZsEHiUbSAJt8PmKOUvvAW6FcLC2tZWDvvFhLnHp0k1m+UekZUaHIc?=
 =?us-ascii?Q?O+5Iq778Ok2axvgOWiHNRGJJUWS/p26VdY+UGpV6dbHlvjJwsBNeJxDTRNdV?=
 =?us-ascii?Q?K8MvJoZixqxarvrEAwN9jqZi3GAybVri2KsyO4HoJHdanLSz3mYAkAgwrC5l?=
 =?us-ascii?Q?AcfGGEQOGlXX+cgKt/KTIYAYwMOjUlZhC+x4puifmSid209UltJ+so93DiWA?=
 =?us-ascii?Q?Co9NooNb/l3goM6JbnFJ29IxsR4Nou1OF+BMERYoeb2hYwMsAc9rG34fQAmg?=
 =?us-ascii?Q?hHHokVS/BjUxAWejBPY0aYpUQOG2BIgt4mSKxU3o8i4c8bKNuvPVgVs8sBL1?=
 =?us-ascii?Q?uVjI/Cz5SNglvszzFbxrbil+wU6pYQylFxI/iRvekbkTr4HXuXQUpGNMtkng?=
 =?us-ascii?Q?uJmS2D4GXdypOHDsPu9yypmUJn/DFizSb9xZS8ySK1b2WzkUH3dLTALxdkKi?=
 =?us-ascii?Q?ulLAntMnuztp3FczTGcglgJNOQkheH13fM6Qz4VykXWu79QYO4p3HSZi6Qgn?=
 =?us-ascii?Q?Y1B3lwaatw29WYUYAn3TGPRum+zkzWqmNXmaQfjc7MU5rGp514B+sr6zDfRX?=
 =?us-ascii?Q?RbRFlySA45tNJvKs2E8eIJfz8UAM558VYa2Jgm0n0hkg2iJU0SRmHi5vbY9T?=
 =?us-ascii?Q?G2myHFXWaJONzELBbCw02KPgLMpYmr9XAkNdroo4uv2l17vLuIjNCZyqjRV9?=
 =?us-ascii?Q?g3oCr5JdTMt+eRHdTfsJxh5GquZwQSlHF7NA+9+tFXfKGsA/uct43HjLVc5b?=
 =?us-ascii?Q?AN08fh3a/z8XmdEB4f6YuBEShvUqNZrEmlPmWxksM839cfZsUXWtH81jIa2r?=
 =?us-ascii?Q?w5HaEjAWWR9rujrUCX/sr8CE1MXjExiIJZdAAaQpFbsLc0F8STlu2QcYzR9P?=
 =?us-ascii?Q?mc0i71cKBw9WJCu9WrRUxRwPOt7ZeZHnlb0Dgin3YByYcRtiGlDgcNTAOmfq?=
 =?us-ascii?Q?1WDe7SwkaMStC1Gzhxn3UqrBuYsBTIf10BcDgLiq6I2/yBsbh4cKwHVb45vz?=
 =?us-ascii?Q?vopnUgzUidy2z4pQkbVbgHYNQqX2A9m4qd2v5CQ4L7ofOqolD5kWJqwIceZ/?=
 =?us-ascii?Q?CSKj29npVhB/jT5X0zQ/A0LKvByz1cQMDTlE30oG?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2bb9f8f5-d1e7-48d8-22a5-08dbbe516135
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 05:28:13.5345
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: v9gIp4YUucOqUdz0p8hzyprsN3Hd+wEqAEhCP3l/afr20YElLBCY1B4obWt+4s8AQeTZCaYv6IiTX2z6mXJitw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7966
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 25 Sep 2023 22:28:31 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Tuesday, September 19, 2023 5:25 PM
>=20
> @@ -235,6 +235,13 @@ struct iommu_iotlb_gather {
>   *           use. The information type is one of enum iommu_hw_info_type
> defined
>   *           in include/uapi/linux/iommufd.h.
>   * @domain_alloc: allocate iommu domain

Given now we have two @alloc ops it'd be clearer to also update the
comment here so the explanation for @domain_alloc_user() is easier
to be understood, e.g.:

@domain_alloc: allocate and return an iommu domain if success. Otherwise
               NULL is returned. The domain is not fully initialized until
               the caller iommu_domain_alloc() returns.

> + * @domain_alloc_user: Allocate an iommu domain corresponding to the
> input
> + *                     parameters like flags defined as enum
> iommufd_ioas_map_flags
> + *                     in include/uapi/linux/iommufd.h. Different from t=
he

"to the input parameters as defined in include/uapi/linux/iommufd.h".

> + *                     domain_alloc op, it requires iommu driver to full=
y
> + *                     initialize a new domain including the generic iom=
mu_domain

"Unlike @domain_alloc, it is called only by iommufd and must fully initiali=
ze
the new domain before return".

*domain* here already refers to the generic iommu_domain struct.