Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1791257rdh; Tue, 26 Sep 2023 03:52:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHp9BPtyH7bSH/nuABxGWXsfZVh0yheuTDPW4uWm2LPDpiXUVYbPsidjmqMwPihwT8dDra8 X-Received: by 2002:a17:90a:f601:b0:263:f4cc:a988 with SMTP id bw1-20020a17090af60100b00263f4cca988mr6692797pjb.5.1695725555923; Tue, 26 Sep 2023 03:52:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695725555; cv=none; d=google.com; s=arc-20160816; b=aN96lvKZhF4FLMho6DDxpEwZS627Cri6zIDwmDj84BTET3CmWWYMxkkE+lUd1L4zSY cDVAzgqMPFzjfHZTXwyXcq9+gL/FuwSt77yfNI+k/gjoaYXLzywaOxQ2EKqjjF4+n5fZ SUnKECAfYUcj66JOvtOmnORNwmtBU3eHc7kj7ZOnRi0ySTctT5y5XUT8DQLY/f5s89Jl UvmoZd63s21N5QavZzWLFxXzMAD501zRQhiBPa6Xp+yygYziXAwWz7d84yvL0nC73EAG 38h6bNgevWR6A8yuwZ+pjlwgs056ZSKNZcZWM9r/u5h+EtGA/dcPTJM/QfgxRGpTqN93 8DMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dkim-signature; bh=jxwIrZXZu6AlVNAUW7u4tiHseK0LPif/A8oNBF/mleY=; fh=90f2sjRRcddAkJ5TSc/EEAbFxxXHjy/S2NAejTwp1/A=; b=BxPchyVGFczafWdzqD3xTR77lAobXqc+SQl1QOEj4njvbzinVzozOfTtDsnB1wTG+s +o9XKL4ROB5/8sZwDlFPI8N/gMtnxVgdkcjXSev2vzdusMG1QieOFISI5UMCQMKMEpj0 h4dQOTmoOX+UnBHsd8WPsArjMi4jnhml/vA0B0v1OFAR1WNUguQMVSO45m8h4+gWsW2R ZdsNCrMlWHSGxi00ApVqmQcaOIxUPfNuUVR6QfWB+LqVYLrF+euio2AunvpMFq9FZw/s H84LkBlLY8OxFYXdBd6r662/aQZ6oTcQyZVMYJbKwhAOIMMgUOaJ0HbF8OFgEsbSEGNX ghzw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmpSq5h+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id v7-20020a17090a088700b00274c8943b59si14268131pjc.64.2023.09.26.03.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 03:52:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmpSq5h+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 2B8FA806C355; Tue, 26 Sep 2023 03:45:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234445AbjIZKpQ (ORCPT + 99 others); Tue, 26 Sep 2023 06:45:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234225AbjIZKpP (ORCPT ); Tue, 26 Sep 2023 06:45:15 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD635E9; Tue, 26 Sep 2023 03:45:08 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C46EC433C8; Tue, 26 Sep 2023 10:45:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695725108; bh=Jr19cp7yaOhQeqgjjuOGhureNw6Qt3kSFYQrp6ys3gM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=dmpSq5h+4p12H+CMfVLWGr6ETOYNhl3F6Sk3hs5OTdZaCgxg9vXopsoT8+iBApq4X BVCDUlNVkY5y4xOAwrLaE2L8WChSIa8aZpfpJTIbw0ABQVSgPZ0QP8Vh2QYOM4F98B 7M1FAFV4042aYxcHwDZllNMcsluHKgmogCVm9e9xvV3NJB+C54aIGl8no7cVXRq5DJ vJNcXWYxkTDnNE0unGYbhe2eH2KRopax6YE61l8RGtt97NU5D1XTOdbvIpHP0f/hTW /g5Z5Dkp080NoP6XJfXiFgb7SEDZ6bYBHex0spKL/7E4zCEaUVBnmvS4S8/6TZUZeD WPfDzWJBCI2TA== From: Kalle Valo To: roynatech@gmail.com Cc: johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mac80211: fix station hash table max_size config dependency References: <20230923032834.9694-1-roynatech@gmail.com> Date: Tue, 26 Sep 2023 13:47:08 +0300 In-Reply-To: <20230923032834.9694-1-roynatech@gmail.com> (roynatech@gmail.com's message of "Sat, 23 Sep 2023 03:28:34 +0000") Message-ID: <87bkdpjjo3.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 03:45:35 -0700 (PDT) roynatech@gmail.com writes: > From: roynatech2544 > > Commit ebd82b3 ("mac80211: make station hash table max_size configurable") introduced config > MAC80211_STA_HASH_MAX_SIZE, which is defined unconditionally even if MAC80211 is not set. > It doesn't look like it is dependent of MAC80211_DEBUG_MENU either, as its only user is sta_info.c > which is compiled unconditionally when MAC80211 != n. And without this config set somewhere, compile > would error out. > > Make it depend on MAC80211 to correctly hide the config when MAC80211=n > > Fixes: ebd82b3 ("mac80211: make station hash table max_size configurable") The commit id in fixes tag is too short, more info in the wiki link below. > Signed-off-by: roynatech2544 Please use your full legal name, no pseudonyms please. See wiki. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches