Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH v4 07/17] iommufd: Add user-managed hw_pagetable support
Thread-Topic: [PATCH v4 07/17] iommufd: Add user-managed hw_pagetable support
Thread-Index: AQHZ7GCNGmhTffD5jEKiTFgUr50vNbAsx/Yg
Date:   Tue, 26 Sep 2023 08:14:47 +0000
Message-ID: <BN9PR11MB52765F6D764B0C621A2D3FEC8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-8-yi.l.liu@intel.com>
In-Reply-To: <20230921075138.124099-8-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P7ygxJ76ESlRud46nH8YM1bMojJnIE4Wc7Fgi+Th683k3PTCkKByxxhC1E+O?=
 =?us-ascii?Q?hwg/f/z2Vo7CQ3c5ssSjw8hEFykRjnX0gLYxnrrvxjRe3P1sMezAluhKBtwa?=
 =?us-ascii?Q?Vs46qafpb7wYa1a8uGvx5SuSuWtVDBenGLzFVI6xApvSowSiVY5ER1D01yeS?=
 =?us-ascii?Q?UnB4fnZpwl39xPd9SMhOyYMbQ6RSRjSqnNPSjNntFBiOjQ44cs9gVLobTWaB?=
 =?us-ascii?Q?T7aim+oTMw05djClTiMnnMjnG+kwaDa1zE0Yi6aZpnVqQdpzB6TpzyUg+N78?=
 =?us-ascii?Q?rRMvWaiRi8r0j0hn9RE5lLAx0QggwRkRRR7pTl7gN+3VR4P44/wvD8CESX56?=
 =?us-ascii?Q?XvbTcRQl4P550fdXFc7wYX5kCGluhhNW2c4WgPBJKWLY55V9fmQG2GPinA94?=
 =?us-ascii?Q?xTQyfkQbkEk1ACyqU5BrXeJm2BNaCKoho89LC/F+JyWLNOJ1EOXGqUuLV7Vj?=
 =?us-ascii?Q?TVT0tx4ZFSGjrOJW+nkFqzZBhBQKBes6w7nNTGsqOpgZMYQM4yqnS5+EE9HA?=
 =?us-ascii?Q?yz4M7BwNMIjsGMUt6l7oRBFXx/p21kGJnxnEJafhxzyUN2QHJvSzYWXDU9PY?=
 =?us-ascii?Q?UAxiNDyOKfYPgIQIySHMNVFixPNvat8eC4xu1r+m1t+T4TZBIslaR2QfEXX0?=
 =?us-ascii?Q?qpYjtvAZn0bNVPeSC3Y4gjXn46iZd+bJ0Qw03XlfMPWeVlqvsThLtoV63VrE?=
 =?us-ascii?Q?j1t7xwQZVZCGEh/9rAJKIy5hiHM0bCroYPJt32F6MmuyIXlc8wSUTJ8lsqZ9?=
 =?us-ascii?Q?qv80jCFxj2EZTbUoIxnPu+Vf71SbQkfJ6ajkwO8s0uct1cljMNaqSG4I2UeD?=
 =?us-ascii?Q?ha3meRYh8kCQlQcwRqw+zJCgbizAcfpj5j/Gz+rtRV8FZ0CLSvxLGOOJKPtS?=
 =?us-ascii?Q?hvda1f10de9X4LTY/RRAMPqeeNbdckrqX6DFxUZx0Q1clz19klR+Fzp4OtCt?=
 =?us-ascii?Q?W0w2ponNaDjy/O0bO0cgYWs80jG5ubqyEXOF6grE7foSznAG/W6kqXHcvrVj?=
 =?us-ascii?Q?+DdFzpEWVFsFMRnn89BztLstWhCSKgcxvyV9LKkTkoAZpdHiCORCe0DwU8Gu?=
 =?us-ascii?Q?lw0Y+8xVWcfybmopsVB9JxviKMFYSwKhAhQqI28Ep7Ml/PE2jGf50moSO/SJ?=
 =?us-ascii?Q?gIOVGCPL1z0K84hlHl79oJt0TEKSY5JWZ0wRYTtsh3nzyocFdnjiDvoLRs76?=
 =?us-ascii?Q?UShXfry6okm2ZzcD9oP3MDi/YBZpUbbWA9wM/zYkbr/s1SfrtuDJGfAKr0Tu?=
 =?us-ascii?Q?Dja8y9OVx/zLplV/Quq99BU8i0MRJEUtJ+wOrDNaSnlW7RiFqg6RA22hbpO6?=
 =?us-ascii?Q?WBlr8nqvWwuug8tcx3LwiGQvMAhKHAC8xzfc5SJ372eFQo6FG3Sb05qH+vUf?=
 =?us-ascii?Q?zWh45choLIkr794ulHPJlCu9dkx4AjofEZELUsSSYY8R/IJReKFwk2b/N23/?=
 =?us-ascii?Q?0pe08ZzFVbr71Ja/HyM7W1dt0Z1zjOTRLtuJQZ+K0AF7Y1mpAI0HrIOPfGwY?=
 =?us-ascii?Q?K+N1PssfJHlg99C5eFCs5TmUq42avdDiROqatsLyYfuS8XsVBHv1WxIqtwYS?=
 =?us-ascii?Q?XiPYOI0QVmtTZZSW743/OXnX9sZla5wKZP4jRqKy?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f4ad315-9b38-43f9-aa36-08dbbe68a630
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 08:14:47.6889
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tmZHaESUEeXG6vpJGZFyuhiejXPtkmScy1GTDtYWwYRNBJBtlCvtHxEHotmxvtRXiKQkXzM6IE0P4IVhARtgGw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5108
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 01:15:56 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, September 21, 2023 3:51 PM
>=20
> +static void iommufd_user_managed_hwpt_abort(struct iommufd_object
> *obj)
> +{
> +	struct iommufd_hw_pagetable *hwpt =3D
> +		container_of(obj, struct iommufd_hw_pagetable, obj);
> +
> +	/* The parent->mutex must be held until finalize is called. */
> +	lockdep_assert_held(&hwpt->parent->mutex);
> +
> +	iommufd_hw_pagetable_destroy(obj);
> +}

Can you elaborate what exactly is protected by parent->mutex?

My gut-feeling that the child just grabs a refcnt on the parent
object. It doesn't change any other data of the parent.

>=20
> +/**
> + * iommufd_user_managed_hwpt_alloc() - Get a user-managed
> hw_pagetable
> + * @ictx: iommufd context
> + * @pt_obj: Parent object to an HWPT to associate the domain with
> + * @idev: Device to get an iommu_domain for
> + * @flags: Flags from userspace
> + * @hwpt_type: Requested type of hw_pagetable
> + * @user_data: user_data pointer
> + * @dummy: never used
> + *
> + * Allocate a new iommu_domain (must be IOMMU_DOMAIN_NESTED) and
> return it as
> + * a user-managed hw_pagetable.

Add some text to highlight the requirement being a parent, e.g. not
an auto domain, must be capable of being a parent, etc.

> +	case IOMMUFD_OBJ_HW_PAGETABLE:
> +		parent =3D container_of(pt_obj, struct iommufd_hw_pagetable,
> obj);
> +		/* No user-managed HWPT on top of an user-managed one
> */
> +		if (parent->user_managed) {
> +			rc =3D -EINVAL;
> +			goto out_put_pt;
> +		}

move to alloc_fn().