Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Tue, 26 Sep 2023 12:12:45 +0100
From:   Conor Dooley <conor@kernel.org>
To:     Edward AD <twuufnxlz@gmail.com>
Cc:     syzbot+8d2757d62d403b2d9275@syzkaller.appspotmail.com,
        gregkh@linuxfoundation.org, jirislaby@kernel.org,
        linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
        syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] riscv: fix out of bounds in walk_stackframe
Message-ID: <20230926-shorter-acetone-25a93d7ab27c@spud>
References: <0000000000000170df0605ccf91a@google.com>
 <20230926105949.1025995-2-twuufnxlz@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="MisKy8cQA+A+qNEs"
Content-Disposition: inline
In-Reply-To: <20230926105949.1025995-2-twuufnxlz@gmail.com>
Precedence: bulk


--MisKy8cQA+A+qNEs
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hey Edward,

Where did you come up with the CC list for this patch from? Please run
get_maintainer.pl on your patches and CC the output. You've not CCed any
relevant developers on this mail :(

On Tue, Sep 26, 2023 at 06:59:50PM +0800, Edward AD wrote:
> Increase the check on the frame after assigning its value. This is to pre=
vent=20
> frame access from crossing boundaries.
>=20
> Reported-and-tested-by: syzbot+8d2757d62d403b2d9275@syzkaller.appspotmail=
=2Ecom

Please also add a Fixes: tag & a Closes: tag with a link to the report
when you do so.

Thanks,
Conor.

> Signed-off-by: Edward AD <twuufnxlz@gmail.com>
> ---
>  arch/riscv/kernel/stacktrace.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrac=
e.c
> index 64a9c093aef9..53bd18672329 100644
> --- a/arch/riscv/kernel/stacktrace.c
> +++ b/arch/riscv/kernel/stacktrace.c
> @@ -54,6 +54,8 @@ void notrace walk_stackframe(struct task_struct *task, =
struct pt_regs *regs,
>  			break;
>  		/* Unwind stack frame */
>  		frame =3D (struct stackframe *)fp - 1;
> +		if (!virt_addr_valid(frame))
> +			break;
>  		sp =3D fp;
>  		if (regs && (regs->epc =3D=3D pc) && (frame->fp & 0x7)) {
>  			fp =3D frame->ra;
> --=20
> 2.25.1
>=20

--MisKy8cQA+A+qNEs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZRK8rQAKCRB4tDGHoIJi
0kqjAP90g4/G1TGVcQIXrpJ/IpCj6h9HaqBw4HfNIj6uQ/YO8gD/WqV+EnH6Ri0n
4R16KfJi3y1+MrAgywo2gRnpSYCSfQA=
=OI2P
-----END PGP SIGNATURE-----

--MisKy8cQA+A+qNEs--