Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 26 Sep 2023 20:34:17 +0900
From:   Naoya Horiguchi <naoya.horiguchi@linux.dev>
To:     Kemeng Shi <shikemeng@huaweicloud.com>
Cc:     akpm@linux-foundation.org, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, willy@infradead.org,
        naoya.horiguchi@nec.com, osalvador@suse.de
Subject: Re: [PATCH v2 3/3] mm/page_alloc: remove unnecessary next_page in
 break_down_buddy_pages
Message-ID: <20230926113417.GC1539169@ik1-406-35019.vs.sakura.ne.jp>
References: <20230826154745.4019371-1-shikemeng@huaweicloud.com>
 <20230826154745.4019371-4-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230826154745.4019371-4-shikemeng@huaweicloud.com>
Precedence: bulk

On Sat, Aug 26, 2023 at 11:47:45PM +0800, Kemeng Shi wrote:
> The next_page is only used to forward page in case target is in second
> harf range. Move forward page directly to remove unnecessary next_page.

s/harf/half/

> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

> ---
>  mm/page_alloc.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index bb74b40dc195..1c35ee022dde 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -6492,20 +6492,18 @@ static void break_down_buddy_pages(struct zone *zone, struct page *page,
>  				   int migratetype)
>  {
>  	unsigned long size = 1 << high;
> -	struct page *current_buddy, *next_page;
> +	struct page *current_buddy;
>  
>  	while (high > low) {
>  		high--;
>  		size >>= 1;
>  
>  		if (target >= &page[size]) {
> -			next_page = page + size;
>  			current_buddy = page;
> +			page = page + size;
>  		} else {
> -			next_page = page;
>  			current_buddy = page + size;
>  		}
> -		page = next_page;
>  
>  		if (set_page_guard(zone, current_buddy, high, migratetype))
>  			continue;
> -- 
> 2.30.0
> 
> 
>