Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     "Liu, Yi L" <yi.l.liu@intel.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "alex.williamson@redhat.com" <alex.williamson@redhat.com>,
        "jgg@nvidia.com" <jgg@nvidia.com>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
CC:     "cohuck@redhat.com" <cohuck@redhat.com>,
        "eric.auger@redhat.com" <eric.auger@redhat.com>,
        "nicolinc@nvidia.com" <nicolinc@nvidia.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "mjrosato@linux.ibm.com" <mjrosato@linux.ibm.com>,
        "chao.p.peng@linux.intel.com" <chao.p.peng@linux.intel.com>,
        "yi.y.sun@linux.intel.com" <yi.y.sun@linux.intel.com>,
        "peterx@redhat.com" <peterx@redhat.com>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        "shameerali.kolothum.thodi@huawei.com" 
        <shameerali.kolothum.thodi@huawei.com>,
        "lulu@redhat.com" <lulu@redhat.com>,
        "suravee.suthikulpanit@amd.com" <suravee.suthikulpanit@amd.com>,
        "iommu@lists.linux.dev" <iommu@lists.linux.dev>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "Duan, Zhenzhong" <zhenzhong.duan@intel.com>,
        "Martins, Joao" <joao.m.martins@oracle.com>
Subject: RE: [PATCH v4 05/17] iommufd: Separate kernel-managed HWPT
 alloc/destroy/abort functions
Thread-Topic: [PATCH v4 05/17] iommufd: Separate kernel-managed HWPT
 alloc/destroy/abort functions
Thread-Index: AQHZ7GCN3k0pHsaUpUaqL7OxTm+gurAsxMbA
Date:   Tue, 26 Sep 2023 07:57:49 +0000
Message-ID: <BN9PR11MB52762F3A9537A6E48E454BBF8CC3A@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-6-yi.l.liu@intel.com>
In-Reply-To: <20230921075138.124099-6-yi.l.liu@intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8vAqb7Epx6JhUxRZy5JGTdNafq+Afjz/UpZYEErpRMChPqTNGyL6FK4UrBkn?=
 =?us-ascii?Q?1r0Ubvd007hCKKa04ZvTc9SMRzaPjKVFCsFfqto59nz6DdHI2NhviXTZujTB?=
 =?us-ascii?Q?VIGinhqtgWKeUbSeK4Rhm6z6cpZSPGp+ImERDDifq/ZUc0Et53WKeE8FAWFf?=
 =?us-ascii?Q?vI04DIZ7bCnl6xxUwIDOzNSC3Y6DzvJdxstGCQzRJlLSijqzWEAEp0Nqxyos?=
 =?us-ascii?Q?4uBKhs8eAYFJRTukpnb7yDkCm3eseM81FAOBzHxWePpfVjzj8U5jrFm3KHoB?=
 =?us-ascii?Q?K/Gus3kKn3Kl/PzgkkFU8Cm89yGrzc8on9WWPfyGq3dpbdBte13X6wMRtBip?=
 =?us-ascii?Q?+KH2Ryeu1FzrBWqwRYy2Agcd0FJw1pQle6YxygA6omRW5WhBy534jZdFmJXd?=
 =?us-ascii?Q?NxDBcPxI/nGA1iRa/nwbooLbDv81g6GT9uaBk69gYsCHKytWR3BwaP/aTv+C?=
 =?us-ascii?Q?rJRhWbwIZVocA8RL+eVw9ILgsFEKUIsnV+6++z1uUq/m7cqp1SNpgrNbW0dv?=
 =?us-ascii?Q?YGMYUXwKTAAbqjJq81qhl5oi9BUOhzZU+htLISB2h/d3wl4LkqNtRIFr6Ili?=
 =?us-ascii?Q?JE5gu1xIXfjGWx9KzqGFJZP5enYU2k1i5k83W1+PjoRzCnTVDUIjBC/Tm9sf?=
 =?us-ascii?Q?6G1unpoh289Kkn/addz5gnP8fwZRGa9zfRmAEiQTbM1ZsHT+R799jkwA7UHL?=
 =?us-ascii?Q?9g91mocSh7gxqPlLNWzimv4Bsc0Gf1cYad81gymeQrk0K4mUHwhrS6Zp8Rw5?=
 =?us-ascii?Q?37JmeVnb9xXtUR+IwExmTkJQQK+xe1iRm6JJNXkUS3JRqHziFetdsVHK+9Hg?=
 =?us-ascii?Q?/St+Q/tQAbzgtl5Zf+nfOs6NVNFnf+BJD7LedHtE4j+hnzaLNZ6WuhtpdZkB?=
 =?us-ascii?Q?lxwOI7HqPQrnk9AnVKMW+MrpE6jhiMmE6/EvLd9Xyl1g2+YHAfCnZOqXW4fO?=
 =?us-ascii?Q?oeWREFdyMDDaHYc8mWBC3nHiCUc8j64TxZwEs1FNVQu+8imw3M2TWtXzR4Oq?=
 =?us-ascii?Q?ja3OejVwBOweY/cSZx412e8jIaHoDp8i4yMQIAuGVHQeDDywlncloUD8RhX5?=
 =?us-ascii?Q?BSRwBKMA0AZdqMaeygc5+RWsTZyAp+t7dPJLNXtE3kcCTFCqO+GKdVF8ZfAJ?=
 =?us-ascii?Q?p8xwUBnh1XMkLbQ4JhgA31R/bgcjmCF0QWv01JVWuYl6PkmUfnI1o3wzysmt?=
 =?us-ascii?Q?RE9jPerh+O1AkeIh1Bpx8ZreyFMaar7x+RrJ3Jffn0abzCGL7PNVzZkb1kju?=
 =?us-ascii?Q?cXU44XGZZmBaM8F8N1rPd0DQtxpCF/YZZQLOsoYtF7Nk695zKUOA7J1C7XOT?=
 =?us-ascii?Q?p4fKrDzzG8h1w2DmshKtyY4fk5N69gw1tt8x1YrgYqsUy37fYmQcQ6yL4ZVq?=
 =?us-ascii?Q?dLuZOxS4v52liW/Cn/D6HYUu1lpzn7p9EkMLHoxJWIdA2XD+QVk32f/swMXs?=
 =?us-ascii?Q?5M3yMnGP/f/Az6D38tSqWEUceqc/3tDfjDcPWGT8YLvLiOYgdWAKX/RsdFwn?=
 =?us-ascii?Q?Pzz+i2XF33nEXso3tbitj5PNxpEV3Hp4UEyg54L6knDybz1Bg+hxDQBBdUyR?=
 =?us-ascii?Q?xrVgwCLNXh1LRezvQPHZWyRK0Epttj+CkBzqE+BA?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76cf931e-dcf8-4964-c8be-08dbbe66477b
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 07:57:49.8060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: jMGIIszf6DJXZPcUmUdvNw1jUCQAl/1oDzOyBr/3YJwAZWixhxQ4TV6x6dvp7Dx0D6UztlT5FBdGqw2PB0YtVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8579
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 26 Sep 2023 00:58:04 -0700 (PDT)

> From: Liu, Yi L <yi.l.liu@intel.com>
> Sent: Thursday, September 21, 2023 3:51 PM
>=20
> -void iommufd_hw_pagetable_destroy(struct iommufd_object *obj)
> +static void iommufd_kernel_managed_hwpt_destroy(struct
> iommufd_object *obj)

'_managed_' could be removed. 'kernel_hwpt' and 'user_hwpt' are
clear enough.

ditto for all other related functions.