Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1878666rdh; Tue, 26 Sep 2023 06:22:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmFFYfPI1F1lLe4D2YIpeKXOWNoQTOFMfA3FKmJHuzo4q7rZsw4R1bK56EhY4Z6nFj87Oa X-Received: by 2002:a17:903:32cf:b0:1c6:1ac5:144c with SMTP id i15-20020a17090332cf00b001c61ac5144cmr5989018plr.40.1695734557540; Tue, 26 Sep 2023 06:22:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695734557; cv=none; d=google.com; s=arc-20160816; b=ewJFh3v7fNP27cviTJNhLw3c/TxablgRoyFEw/Awjcq0nY4g/T95bZUx+9gKVCYCls SNhjOMGp95uKALMwBShQWMvWR6K0kBqobJUnS5PnoPvK5DM+N1kGSoQSFpaOo6zMKV07 tZe/j+nycQ0tLiL00iA+ybFVvG1hRCY9ciOUsnGf9DbEUG1WDbr7ZegfdPyCyw+MIUUs kv+4ZoJimLMP+XsEMKNtZjiNOg2/eD+6Bpm5Q9G+VHK9wPtAwp4lPjApCiVUCvFdgJ8h FHLnbfAV8N9GnHoEWJCcbJ8ufn098IqesFfOf7/rz7PyWlo3JMIb+BewCi0HLqFVZVDJ 2f5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=vc4Cre/FG5qT/QgCqgpeBABCKG/U+RSEpRQZ2rr0kos=; fh=5owFIITvX1RGiVXdt331tP5Kcmk2YmQxRrWIe2S44wE=; b=0vEoHaiAXnO55tIelsUQFxpHDTWnP3PIVEGWTwHRYQKjwIEvqaSx4e33s/sUJ2QJx/ nVnf+zpEYY7lCXYsMz8eSIRhIXiWnHQx8cL7bPqWIYkLCuCBRogpvIEAeOLTpp99qbAz g6u9KNZ1MioIn1JVaLbUa7jHef5/+NY2tIOX1SRypEE2e1VJS443Qi2eIdQ4Wy2yDYvR 2ZqtdzaRkic21MRZA6bcP0c5jF0vBWgpVQSCY6aJgf65QsPbLkdVeduAjUP5fKu8gS/c dneKTDbT/cQIZKxhSrCcCrnLVLWB6HczQuQCx7UcIZMnRNnN4k+f+t4/ykAAiTiniXyV ZEvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="BP/AcUtP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id f18-20020a170902ce9200b001b9d5f07068si13250055plg.585.2023.09.26.06.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 06:22:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="BP/AcUtP"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 73345826FAC6; Tue, 26 Sep 2023 00:29:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232621AbjIZH32 (ORCPT + 99 others); Tue, 26 Sep 2023 03:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232301AbjIZH31 (ORCPT ); Tue, 26 Sep 2023 03:29:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34E88DC for ; Tue, 26 Sep 2023 00:29:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=vc4Cre/FG5qT/QgCqgpeBABCKG/U+RSEpRQZ2rr0kos=; b=BP/AcUtPRq5nmG67dVQuIgie0q bQduqE+F7z57ByRadtQ2epBdyYaEND6QXoL6Yy+9rr3REj4g2Aqz3SX+lRGGGYX2DiPpUwyMFOyeh ryLBjY6CkdxJEYeFZLIvgZZy15QjJKwB6CGg3YlQFCDHhQQqVZXGftCUvFfTmGNKolJYvCqEOc2Uw 1LtwjpuXXYHS5qkrWIZJlfCsB5EFHUlAqqMjQCUgVgIdrlO80gtZgMTUgc+F3a/1WyYeqUn1OG5vb sbnxdWXABIzKmluGRRmo73F5uNuBZKfzkRiL/TX9nB6qowuCpYlN0gj8lcogNv2Hkzw2sYL6IVKgE yzVMMeZw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1ql2VL-00FnU7-0d; Tue, 26 Sep 2023 07:29:11 +0000 Date: Tue, 26 Sep 2023 00:29:11 -0700 From: Christoph Hellwig To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] zswap: change zswap's default allocator to zsmalloc Message-ID: References: <20230908235115.2943486-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230908235115.2943486-1-nphamcs@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 00:29:29 -0700 (PDT) On Fri, Sep 08, 2023 at 04:51:15PM -0700, Nhat Pham wrote: > Out of zswap's 3 allocators, zsmalloc is the clear superior in terms of > memory utilization, both in theory and as observed in practice, with its > high storage density and low internal fragmentation. zsmalloc is also > more actively developed and maintained, since it is the allocator of > choice for zswap for many users, as well as the only allocator for zram. Dumb question from an outside, why do we then even keep the other two allocators around?