Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Date:   Tue, 26 Sep 2023 18:39:05 +0800
From:   Kent Gibson <warthog618@gmail.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
        Yury Norov <yury.norov@gmail.com>, linux-gpio@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>,
        Srinivas Neeli <srinivas.neeli@amd.com>,
        Michal Simek <michal.simek@amd.com>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Andy Shevchenko <andy@kernel.org>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>,
        Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>
Subject: Re: [PATCH v1 1/5] lib/test_bitmap: Excape space symbols when
 printing input string
Message-ID: <ZRK0yfXf/XPazxm4@sol>
References: <20230926052007.3917389-1-andriy.shevchenko@linux.intel.com>
 <20230926052007.3917389-2-andriy.shevchenko@linux.intel.com>
 <ZRKz/G8y397MmVoc@sol>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZRKz/G8y397MmVoc@sol>
Precedence: bulk

On Tue, Sep 26, 2023 at 06:35:40PM +0800, Kent Gibson wrote:
> On Tue, Sep 26, 2023 at 08:20:03AM +0300, Andy Shevchenko wrote:
> > test_bitmap_printlist() prints the input string which contains
> > a new line character. Instead of stripping it, escape that kind
> > of characters, so developer will see the actual input string
> 

And "Excape" -> "Escape" - didn't notice until my reply was sending.

Cheers,
Kent.

> Grammar nit:
> 
> "that kind of characters" -> "those kinds of characters" or "that kind
> of character" or "such characters" or ...
> 
> > that has been used. Without this change the new line splits
> > the string to two, and the first one is not guaranteed to be
> > followed by the first part immediatelly.
> 
> immediately
> 
> And the second "first" should be "second"??
> 
> "the second part is not guaranteed to immediately follow the first" is
> clearer (and hopefully what you mean), IMHO.
> 
> Cheers,
> Kent.
> 
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  lib/test_bitmap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/lib/test_bitmap.c b/lib/test_bitmap.c
> > index f2ea9f30c7c5..1f2dc7fef17f 100644
> > --- a/lib/test_bitmap.c
> > +++ b/lib/test_bitmap.c
> > @@ -523,7 +523,7 @@ static void __init test_bitmap_printlist(void)
> >  		goto out;
> >  	}
> >  
> > -	pr_err("bitmap_print_to_pagebuf: input is '%s', Time: %llu\n", buf, time);
> > +	pr_err("bitmap_print_to_pagebuf: input is '%*pEs', Time: %llu\n", ret, buf, time);
> >  out:
> >  	kfree(buf);
> >  	kfree(bmap);
> > -- 
> > 2.40.0.1.gaa8946217a0b
> >