Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Mon, 25 Sep 2023 08:48:40 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yang Shi <yang@os.amperecomputing.com>
Cc:     hughd@google.com, surenb@google.com, willy@infradead.org,
        mhocko@suse.com, vbabka@suse.cz, osalvador@suse.de,
        aquini@redhat.com, kirill@shutemov.name, rientjes@google.com,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org
Subject: Re: [PATCH] mm: mempolicy: keep VMA walk if both MPOL_MF_STRICT and
 MPOL_MF_MOVE are specified
Message-Id: <20230925084840.af05fefd19a101c71308a8cf@linux-foundation.org>
In-Reply-To: <20230920223242.3425775-1-yang@os.amperecomputing.com>
References: <20230920223242.3425775-1-yang@os.amperecomputing.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 20 Sep 2023 15:32:42 -0700 Yang Shi <yang@os.amperecomputing.com> wrote:

> When calling mbind() with MPOL_MF_{MOVE|MOVEALL} | MPOL_MF_STRICT,
> kernel should attempt to migrate all existing pages, and return -EIO if
> there is misplaced or unmovable page.  Then commit 6f4576e3687b
> ("mempolicy: apply page table walker on queue_pages_range()") messed up
> the return value and didn't break VMA scan early ianymore when MPOL_MF_STRICT
> alone.  The return value problem was fixed by commit a7f40cfe3b7a
> ("mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is specified"),
> but it broke the VMA walk early if unmovable page is met, it may cause some
> pages are not migrated as expected.

So I'm thinking that a7f40cfe3b7a is the suitable Fixes: target?

> The code should conceptually do:
> 
>  if (MPOL_MF_MOVE|MOVEALL)
>      scan all vmas
>      try to migrate the existing pages
>      return success
>  else if (MPOL_MF_MOVE* | MPOL_MF_STRICT)
>      scan all vmas
>      try to migrate the existing pages
>      return -EIO if unmovable or migration failed
>  else /* MPOL_MF_STRICT alone */
>      break early if meets unmovable and don't call mbind_range() at all
>  else /* none of those flags */
>      check the ranges in test_walk, EFAULT without mbind_range() if discontig.
> 
> Fixed the behavior.
>