Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp1921391rdh;
        Tue, 26 Sep 2023 07:25:41 -0700 (PDT)
X-Google-Smtp-Source: AGHT+IFLX8bpCx9b/FExXoOw06oIEBr+QzY6huxYPM4eUEs/WPB48h5sf9lYqShao6JgWAgYeuFH
X-Received: by 2002:a05:6808:1804:b0:3a8:7c67:7cd with SMTP id bh4-20020a056808180400b003a87c6707cdmr12435480oib.24.1695738341164;
        Tue, 26 Sep 2023 07:25:41 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1695738341; cv=none;
        d=google.com; s=arc-20160816;
        b=f7gkYzhcUyYecfmVIF2zQeSMvx629BOc6E1fLDGX4Yc9Xv4Qz8NJP5O//EQwmtc3J5
         2sA0ZWMCqtL4vAPy3V/YslgW9BOIlcm6GxQLwIMhjFA5jasqLAKYv54XM/H6YrRAAIzq
         UPVGeS3OFamjCwlI0RjfRPLhp/m9MquttIO21lroqiKCR9Lt8o2To5+A9snsyfk83RFG
         gyNyGH3LNlv4UFSXnvh6LbCPJ1uWuHKhZbCT+WLiLv4XS4sVx27v5Gr4vyYbPEi96HVi
         8COXtB8vQNLc7JdczPXMBbUB92lijUxoavGBDvMAygkEZa31/Ryk0tbEfWZPbi2Dyrjr
         O9eA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=AGmApwbQmIMmG0oLetKtfvZYkM3UfT/XuoVKlgBv2Aw=;
        fh=55jKks3UKtL1Xdvq/yaDSdtDhEEMQ1A6VM/L1bKzdJ8=;
        b=I3lN/0VfGu6XMWTaSyVZLNkfc6oQEWjLlNXJGSjtwSlijD/guRSGKHRPcdGKvuWZdu
         JJHPAl3mLyP86/IL0J+RjZB5Ixd7whJQ8ZryWp0RE9qC6HylA5jF2UBJs8NssUPSSak8
         jFxHAqtQrY2YaxhHJR1SmnFOqH9sIBMJdjFVTPiQnZEHhyyBOxAbWpPOAJYqNAc0os92
         K+jrS33L+HIdNSbwx0EhlUP2mUZQsfE6cuq1HHv7kOrkO4oK1O6uxh05Ci80QF9bTtQZ
         a3MU1YvkHULjZILKb+5EA7g5PpyxvIbSzKR99espRK5TaboOXd8ZKg4KCovsHly/a1Ch
         fKqA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WPublGIK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6])
        by mx.google.com with ESMTPS id b132-20020a63348a000000b005787de7abd4si12646789pga.12.2023.09.26.07.25.40
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 26 Sep 2023 07:25:41 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=WPublGIK;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
	by pete.vger.email (Postfix) with ESMTP id 2127F811979B;
	Tue, 26 Sep 2023 07:24:46 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233819AbjIZOYi (ORCPT <rfc822;bharatb.linux@gmail.com>
        + 99 others); Tue, 26 Sep 2023 10:24:38 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60458 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S232450AbjIZOYh (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 26 Sep 2023 10:24:37 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5E5711D;
        Tue, 26 Sep 2023 07:24:30 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EE21C433C7;
        Tue, 26 Sep 2023 14:24:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1695738270;
        bh=AGmApwbQmIMmG0oLetKtfvZYkM3UfT/XuoVKlgBv2Aw=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=WPublGIKbp5ROVPQyMjOEr+CjBt2gY3B+PkvEJ/FwIWKm2lTO1pzNxMfSXZB5ytAV
         7U0zBTk603j0EMU51eY9tP+B8IjLvSzbb0B9jTLKDJzzdEpS1tjTA4Bvp5M6v9Sx5m
         wOuUoBniyXB9WKNE4zZppTdhJd69CkXyTiyX/363egTe2DsZ4lGJh5obYfJG00GEp7
         hTz8mNRn0vfegJyKx5cJ+C0bHjbIHsFzLmciajwSMvBSMhSStRJQHusvJNxyWk8w57
         X4TpqJVUSqDZZgXaUi7pfK9cFYAwyrN50NjRbbtvAjhDnvjNE1P859zNWEOCc1bTSu
         OWcMoMBBSyKmA==
Date:   Tue, 26 Sep 2023 16:24:26 +0200
From:   Christian Brauner <brauner@kernel.org>
To:     Mateusz Guzik <mjguzik@gmail.com>
Cc:     viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] vfs: shave work on failed file open
Message-ID: <20230926-worum-angezapft-5c3f7770ad29@brauner>
References: <20230925205545.4135472-1-mjguzik@gmail.com>
 <20230926-anforderungen-obgleich-47e465f0bd47@brauner>
 <CAGudoHG0-BWTVRG8uZk5Gy8xSwpT8JO5Z=VfY3_dFcCaqhLf5Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAGudoHG0-BWTVRG8uZk5Gy8xSwpT8JO5Z=VfY3_dFcCaqhLf5Q@mail.gmail.com>
X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 07:24:46 -0700 (PDT)

> > if (WARN_ON_ONCE(atomic_long_cmpxchg(&file->f_count, 1, 0) != 1)) {

> bench again.

Can you see how much of a difference it makes because imho it really
looks a lot nicer then this ugly atomic_read followed by atomic_set...