Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <908ce024-db79-ecb0-c47a-626227038411@intel.com>
Date:   Tue, 26 Sep 2023 07:31:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v6 01/24] tick/nohz: Move tick_nohz_full_mask declaration
 outside the #ifdef
Content-Language: en-US
To:     James Morse <james.morse@arm.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     Reinette Chatre <reinette.chatre@intel.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        H Peter Anvin <hpa@zytor.com>,
        Babu Moger <Babu.Moger@amd.com>,
        <shameerali.kolothum.thodi@huawei.com>,
        "D Scott Phillips OS" <scott@os.amperecomputing.com>,
        <carl@os.amperecomputing.com>, <lcherian@marvell.com>,
        <bobo.shaobowang@huawei.com>, <tan.shaopeng@fujitsu.com>,
        <xingxin.hx@openanolis.org>, <baolin.wang@linux.alibaba.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Xin Hao <xhao@linux.alibaba.com>, <peternewman@google.com>,
        <dfustini@baylibre.com>, <amitsinght@marvell.com>
References: <20230914172138.11977-1-james.morse@arm.com>
 <20230914172138.11977-2-james.morse@arm.com>
From:   Fenghua Yu <fenghua.yu@intel.com>
In-Reply-To: <20230914172138.11977-2-james.morse@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NFlLSmJhMXE3Z3BaUDJXZEEySWhLbHZPdmt0Tmd3WGFMOGZxeTJKZWoxU0lV?=
 =?utf-8?B?NmFuUkxDMjFGM0lpMEZvTWlnSnRxTnBLdmFLeHJ1UFBZc2IvMVZuSjl1Z2cz?=
 =?utf-8?B?VE5LdzJNeG5zSm01WEl0aUJCZmY1ZlhMVVgrOHU4azkrci9hSGlqZ1JCYXVW?=
 =?utf-8?B?ZFI4MEhFQ0NaMWFUZlpicjZtdDVlZmlJeXd1dUNlZFh4R1Yvek5Zclp5bUd4?=
 =?utf-8?B?Zlk2c29rNVhSd1lmSFNwZi9ScEVBOVJZeUFMbUxqclBRczJGOThvRzFYcmJm?=
 =?utf-8?B?dm4za1BuVnVoVkZwUmZDMUE4UDBmWGF4ZzdTSEdaNFRoaDNqNm5PWHQ3VzVo?=
 =?utf-8?B?SUh0Z2xMUStmZXBBT2FreHo2TjRaNURSWlJFT0JpQkV5SkpDOURDSjdjaHRU?=
 =?utf-8?B?K2ZEZTJtemhEM0lEUVM0UkFEeE9ESTFkcUtkbUNwZFhQNGRQYzdLRWNzOGVF?=
 =?utf-8?B?Yi9aMUxyUWFRNjB0YUZBOVBzYStIdlBnNzJveHJ2TE1mTGFhaWZDNDRTdEpW?=
 =?utf-8?B?Y25RMUVzWE5uOFhOdlViSTh2NnAxd3JiaFRWemhzV0p4OXUyMnNHc2hrK0E3?=
 =?utf-8?B?WWJMWXI1MUJFOXN5M2pOVG84OUJzV083WHNscUx4VFFISVAweGJLQXhoWGNS?=
 =?utf-8?B?K1hSRzVuNDdZSWp3QkNvZWhMMzZ4cmZhcUlFcG5FRUZxdnpBcUNsWHE3QzBH?=
 =?utf-8?B?V0JXaHV0VnJRVzFIL2EwMjI4TmFwTTEyVk4ycWxyTTBMRzNOSE5NUnlYRlhw?=
 =?utf-8?B?RVhqaVJQQmRyenovMDNJVUJodGwySFlYWERLeUNZaGRjQzhtWU1ScmtFb0hH?=
 =?utf-8?B?K0NLZUsvOExSZE1FVlYvWmdmK1dLYURSTmdCd2dhdUMyQzJHcjhRUDhLMkRY?=
 =?utf-8?B?YlJDTHg5b3lhSityMklDMHMvcEpMekNnTW90NFR1bzlxbm54THlrWmQzQzhC?=
 =?utf-8?B?Y2ppeGhSc0tGWlpyd1FFdnBRcTBqSHJ1Zm41YjJBeUVBODRCM25QSTV1aXhO?=
 =?utf-8?B?TmFnenBGTlZFZTQzSlFoK3hpdERLcDVzRkcwZ0Z1K0R0YzBpUHBOUDZFeEVM?=
 =?utf-8?B?eFlKcDBMakpoUUtsaEVFVHF0ZUpUVGQzRDJNb1hXRDZFdS9CV1VzVXBQM2Jt?=
 =?utf-8?B?TXVEeG1CWmlyT0lWdi83S1lqdU85MnFMaWVQZHJrY2thNStoRy83dUExR21y?=
 =?utf-8?B?MkNkSml6NnJUQ1ZhcG9TQklhWkx5SndMQThJS0drV1hubUEvbnZ0R2hJRGtm?=
 =?utf-8?B?VzFGcldTR3ZNLzNVSmdPQTQvRlVwamdDZDl5d2VSWjg5U3V6cG1nbXJYRlgx?=
 =?utf-8?B?TnBKTzlSbHZFeEozNzhNOTdBRExxUVY4MmIwUGFCQnltYXFFUmlSMTEzUEpV?=
 =?utf-8?B?bXdHVUNzdUtKTkQzZmtRa2tXS3BBQUN0c2w2TGVzcW9BSTlGaXlrZ1pTZ0Y0?=
 =?utf-8?B?MEJ0NWxlaG84dFVMTGJjNlNnVytXTG05aDk1SXEvdE1mWjZHWlh4VGxjYVhJ?=
 =?utf-8?B?SDEyZW9vN3gyMy9pUXJ1QU9ady8ySUJ4czkzRnJPeTltK3ZEMlVCeGFYeHls?=
 =?utf-8?B?TXkvaHM4dmk3cjRxQk9xVHpONGNjQktrb1o1UjdSTlc0NGJQVUFHWnZLRTNV?=
 =?utf-8?B?U3pMTlYwa1ZpTE13WVpxdEc5aHRsTVpJRHhGU05xRzFROXZ2cmc1U25jc3Va?=
 =?utf-8?B?S0ZNS1A4Y3B2Zjd3NmJOT0VqM3hPS21jcTYyMU0vTnYxeFQrUXIxOHA0ZzRH?=
 =?utf-8?B?cXNLWjRNanhncld3Uy80OXIvT2pveFJScTRnUlVaTUcvSkJTeVZ0aE04YVNF?=
 =?utf-8?B?TDdEd3RCRmFKYjhhMFMxYWJoWHVFMUc1YUxZaFNDUVFXMmw5UVR6QmhrWlR2?=
 =?utf-8?B?ZGRGK294Nnk0eE5Uenc1NzRQWmZFc2p5R29yZzA5WTAzMEx4NHVweSt5bEgv?=
 =?utf-8?B?azB0OWhVeHlrNGdhZE5ZdXNYUE9ZMFN6Uk80c0grM2pBeFBIU21NNjFUKzdz?=
 =?utf-8?B?ODV3QnBxcFlnNlI3aGdleFZwV1lBMENDZXNyNGVOQjNYSmVsTzJDL08zKyt4?=
 =?utf-8?B?VFlMU3RCeEpycm85bnhxL2o5VHZoMGp2eGtqZ0F2ZUNlNUwyOG1PNW9QelFh?=
 =?utf-8?Q?9CkhMcRWrOHysPVlTSni4zD/7?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 26ad075d-55b9-495e-8c24-08dbbe9d3610
X-MS-Exchange-CrossTenant-AuthSource: IA1PR11MB6097.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 14:31:03.4419
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 35+D7yVB9+RYXH7kz1bOw29Isy/nTu6hYNm+QcFBeSOVQZbWfYD5c3NzLDKXO4AJJBiO5+CC6su3i+EqrkOpCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7838
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 07:31:33 -0700 (PDT)

Hi, Peter and James,

On 9/14/23 10:21, James Morse wrote:
> tick_nohz_full_mask lists the CPUs that are nohz_full. This is only
> needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows
> a specific CPU to be tested against the mask, and evaluates to false
> when CONFIG_NO_HZ_FULL is not defined.
> 
> The resctrl code needs to pick a CPU to run some work on, a new helper
> prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding
> the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to
> be behind an ifdef too.
> 
> Move the tick_nohz_full_mask declaration, this lets callers drop the
> ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or
> something like tick_nohz_full_cpu().
> 
> The definition does not need to be moved as any callers should be
> removed at compile time unless CONFIG_NO_HZ_FULL is defined.
> 
> CC: Frederic Weisbecker <frederic@kernel.org>
> Reviewed-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com>
> Tested-By: Peter Newman <peternewman@google.com>

checkpatch.pl reports warning:
WARNING: 'Tested-by:' is the preferred signature form
#27:
Tested-By: Peter Newman <peternewman@google.com>

The same warning is reported on all following patches in this series.

According to Documentation/process/submitting-patches.rst, "Tested-by" 
(instead of "Tested-By") is used.

Could you please fix the warnings?

Thanks.

-Fenghua