Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Date:   Tue, 26 Sep 2023 18:28:32 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     patches@armlinux.org.uk, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: make <linux/uaccess.h> self-contained for ARM
Message-ID: <ZRMUwGbWKN6OgMzM@shell.armlinux.org.uk>
References: <20230926172253.73204-1-masahiroy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230926172253.73204-1-masahiroy@kernel.org>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Wed, Sep 27, 2023 at 02:22:53AM +0900, Masahiro Yamada wrote:
> When I compiled the following code for ARM, I encountered numerous
> errors.
> 
> [Test Code]
> 
>     #include <linux/compiler.h>
>     #include <linux/uaccess.h>
> 
>     int foo(int *x, int __user *ptr)
>     {
>             return get_user(*x, ptr);
>     }
> 
> To fix them, make some asm headers self-contained:
> 
>  1. In arch/arm/include/asm/traps.h, include <linux/init.h> for __init,
>     and <linux/linkage.h> for asmlinkage.

Please drop the __init marking instead of adding linux/init.h, it's
not necessary.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!