Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <8199226c-9642-e089-8dce-64ac8483efea@intel.com>
Date:   Tue, 26 Sep 2023 11:30:53 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH] dmaengine: idxd: rate limit printk in misc interrupt
 thread
Content-Language: en-US
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>,
        <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
CC:     Dave Jiang <dave.jiang@intel.com>,
        Sanjay Kumar <sanjay.k.kumar@intel.com>
References: <20230924002347.1117757-1-fenghua.yu@intel.com>
From:   Lijun Pan <lijun.pan@intel.com>
In-Reply-To: <20230924002347.1117757-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eEp0aU16bHRueU0wNU1ZSjVUMmRLWEtOUjJVYnByOE9idkJZYmtrZjhJUlc1?=
 =?utf-8?B?YUk5ancyVGhXRFlkbDZzMGtvZ24xVXRjTGM1TDEvbUJhelBZc0VIVXJicWFV?=
 =?utf-8?B?VU5maExEdjZyVjZvaGlZZ3Fua2pVMi9QMjBGUmlUZSt4VTUwL2FQV2xGRUp5?=
 =?utf-8?B?ZmRIMlNlazBoWTdERDFEem1uVUp6ZFlMYjVpcEFhZVlzK3A3elZ5NEM4bjhS?=
 =?utf-8?B?KzlHRHAwZjNkZ2pwbVpiNW5HY2hhY09oOGtZNEYybFIwdkp1RGtJTWlwbURX?=
 =?utf-8?B?MzdlUDRhSE1nYUlheTBydEJTV2lCbFl0OFJDR0R5V3k2a05TeWp5Y1Z6cjM5?=
 =?utf-8?B?MGdvaDhnd2FkS1JHUXZUcWhYVU1ja3JDRjUvazlSbWc2VGhjWVdGTDE3bSs4?=
 =?utf-8?B?dldXQlZKRkd2QUIwS1ROV1NmRDNNa2t6SWtLcUh4ZkNid0Y2WkVwTEJLeFJs?=
 =?utf-8?B?b2crcm4zMmJ1YjRwV0x2dlBXZkJtQlRXamNNK3dXeDNHTHNZL0FzNitwY3Qx?=
 =?utf-8?B?R2kwWWk1MVJWeDNHRlVpTUNIR0t6RTRIUkVlZG9Jc3RUbEsvWW1WNHlscEQ2?=
 =?utf-8?B?WG5JWFgydE1SN2lHMlM5SWp6dzdrNmNNcjhrY3VLSVNLN1J4Ryt1bDlwUWN0?=
 =?utf-8?B?WXNkOEdDZ09EM1VrVFpGcUFYWjZ5bmpLM2lSbjFWVUxzbkwxM0c5aVRWUWMw?=
 =?utf-8?B?MmF1K1U2bEpUb1h3RFltaWhSMzNQNUxrTmkzVGVsczJPNDd1YllnQ0kwdHg5?=
 =?utf-8?B?V3REU214TkxERXRFdEdjSnh4dGhYNFJZUGp1TU9Qc0llUUVabTFUc1JVUjg3?=
 =?utf-8?B?b0NiMUpPY3RpaExBQnJWazRUQ0lvWnpxVXJseU92MVBaMDJ1cGVSMFpIRU5C?=
 =?utf-8?B?OWo1M2ZnMHFPNTJJbmMxQ2luMzNORXE0NlF4eDkzSm4yWmkyN1kvcTIrR2hx?=
 =?utf-8?B?U1VoUmw5TGNPTGs2RmxOajIwaHY2ZXhBUmRaMWZEdDFzRXdvaEZySTRnYmJJ?=
 =?utf-8?B?d0tOYWhRSS9qL0ZQQmthOE1mQTlkcWJSWDZlcERvbFFXWjF0MVViWDhtT2JT?=
 =?utf-8?B?aVpMd2pzVFUzZDJQZDJjVFVkKzhheE8vaHI1WDVtWlg0Yys4a1RWZkk2VWEz?=
 =?utf-8?B?d3dET3VZL0hCNlUvbm9sSSthdmZsRG5CT3JNcm4zbERFTFRzZmR6S0FHZk1G?=
 =?utf-8?B?NU01SUNQNUdOc2QwUElPVnE3d1BsTDM1bVJuRGVkZkV2TEUrRjBod1RTeEVp?=
 =?utf-8?B?OURCbWYzbCtTOW4yZEgwenJabmJHSmlJMDhQaTdtQldRdWsxOVRiS09VVVZX?=
 =?utf-8?B?UGJnMW0yQmR5UzJmTVdRU1BNNk9zNEJ1ZE9WdmFjaEVXK1M1ZndOb1JzdGg3?=
 =?utf-8?B?OCtqYUwzbVdhR05xMGJpc2g0Y0pxQThhVHFhNUUwL0QrQk9seGVHbUFHdS96?=
 =?utf-8?B?dUV1SFNQbEs2Q2tDa0ZwREtKK2Z5bWtFUEdqbktRTkxDRGRUMmxybi9xZllR?=
 =?utf-8?B?RWxPNitSUjdDYlhWaFhyRHBoeFVFY3NGdXR4L0w1UnFXT2lhY3ZUcVVQZUlX?=
 =?utf-8?B?T1RYL1UxcmZIclFoRlNhVmJJNHdCSitwQ0JPd1lzaVlidWhpcWI4RW9yeGdo?=
 =?utf-8?B?QS9PKzJZVFpnZjc4V1BYd3Q2S2JFb3hobjVmQzNNeVdIUEIvaW5nZU5xQWZq?=
 =?utf-8?B?aGx2NzN0bm1HbE5TR3N4K2JidDdNc0dDNVBMRDIrdktmQ1d6SjZTcENxS0do?=
 =?utf-8?B?dVZvZ3dqQk9vb0lIaVczeHlJNVFyc2FSYXZTc1lqUDNicFNhVWE5aXM2UjVG?=
 =?utf-8?B?aVBVNWVuTERrNDNXQXFHRHJ1M2g5S0FSdnVuaEQ1WDYxQjZ2QXhoZ1lRMDd5?=
 =?utf-8?B?U1V5NkV4T2NpM3pNM0dZV3RXMmFvTzQydERjSDBQWUlCbVdVak12d2RjNlBz?=
 =?utf-8?B?Y3pxakpDcllIYU9qSy9xNHZ0Z2p4RFRrVVZrQlJHeW9SdHBkT3Y1M3Fsb0R2?=
 =?utf-8?B?S0p1NkxuRUx0cnlPYTg1UjRlVWtpMDAwMkEvS1BzQ0ZUKzBkK1VSNm5FWlFp?=
 =?utf-8?B?dkV1eUNxMi85U0ZZTkUrYmNvSHlYN1IyZWFpTCs4eFdtU28vaTZqS0JMQnZ1?=
 =?utf-8?Q?YrFWhokXp7oVSlcwVyOQDjjf6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f55a0057-30a0-497c-9fe7-08dbbeadf5f9
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB7141.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 16:30:57.0399
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OJ1m/kJin/0sBrw0jewCGI5wW8E2XfJ6+I0aguOIPiaVPyvOaZmYczL54i0DOAN1Me7O3/VPzJAW9DIzO4BXig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6128
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:31:13 -0700 (PDT)


On 9/23/2023 7:23 PM, Fenghua Yu wrote:
> From: Dave Jiang <dave.jiang@intel.com>
> 
> Add rate limit to the dev_warn() call in the misc interrupt thread. This
> limits dmesg getting spammed if a descriptor submitter is spamming bad
> descriptors with invalid completion records and resulting the errors being
> continuously reported by the misc interrupt handling thread.
> 
> Reported-by: Sanjay Kumar <sanjay.k.kumar@intel.com>
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
> ---

Acked-by: Lijun Pan <lijun.pan@intel.com>

> 
> This patch was sent to dmaengine mailing list before:
> https://lore.kernel.org/all/165125377735.312075.15715853788802098990.stgit@djiang5-desk3.ch.intel.com/
> But it hasn't be merged into upstream yet. Add my Reviewed-by tag
> and re-send it. No code or commit message change.
> 
>   drivers/dma/idxd/irq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index 041be6a4dec4..8e895a1e1881 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -430,8 +430,8 @@ irqreturn_t idxd_misc_thread(int vec, void *data)
>   		val |= IDXD_INTC_ERR;
>   
>   		for (i = 0; i < 4; i++)
> -			dev_warn(dev, "err[%d]: %#16.16llx\n",
> -				 i, idxd->sw_err.bits[i]);
> +			dev_warn_ratelimited(dev, "err[%d]: %#16.16llx\n",
> +					     i, idxd->sw_err.bits[i]);
>   		err = true;
>   	}
>