Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
Message-ID: <983b5c76-f611-ffa3-683a-f754efab9d4c@intel.com>
Date:   Tue, 26 Sep 2023 10:23:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Betterbird/102.13.0
Subject: Re: [PATCH] dmaengine: idxd: Register dsa_bus_type before registering
 idxd sub-drivers
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Michael Prinke <michael.prinke@intel.com>
References: <20230924162232.1409454-1-fenghua.yu@intel.com>
Content-Language: en-US
From:   Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <20230924162232.1409454-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFlHdk9FemVQR0RBSnNMZzN0SmFndi9zcWpmdHZSdUNuYnlhMld0SjlvS2wy?=
 =?utf-8?B?SUljOWxIVFRBVVpRZ3Z0QUZoMkNMSkl0cHRpMUxUZGMwYkZUZ3lzZ0MyN2xq?=
 =?utf-8?B?YjZ6WWJkSXpMRkc0aXNXYkh3eHMrWHoxUjBRK3hrT0p0cHNlNTFFbGNzUkVw?=
 =?utf-8?B?V244L2dueDdUelAzZUEvS3IrVTZIQklYb3dicUxqZXFVQ25ack81VjBBTDZK?=
 =?utf-8?B?OUFtdERreE5QcHczRjJOQllYazEvVDc0STFLVVRqVmcxOHppZS9HR21qQXJ1?=
 =?utf-8?B?UlRMV1lQUXM1aSt4UmVTNzYzV3pLZ1dhckd4cG9UbXpSU0J2ejFEVCtKYzE0?=
 =?utf-8?B?cmp2RytQMlFoazJXalV4djJ1cEZSb3dTYzRVQXJadkhVekF2OEhmUnJLUmRz?=
 =?utf-8?B?aVVLUVU4US9qOG9samNzdWVIL2NOcmFTYVN4NFlIZ3pXbCt4UTBwb0pGN2pl?=
 =?utf-8?B?c0ZkSlJ5U2EyRnhNdlVHZlg4cm80M0ZGUlBibHU3SjArUzAvVEtzWnJUcWNR?=
 =?utf-8?B?cmRCMVpIV1NrSFJYZEdOSk5QTU4xL21XamFaT2xhZ3FuejFwekVEVUVYeWNF?=
 =?utf-8?B?UUM1NVBFN3hKUnc1elNvWUp0REM5TUNrTlNnOEh6bTZwaHJVMXdtUWNNT3Uy?=
 =?utf-8?B?M2lENXJ0dFFNd2xXN045Y0tDZXZKQ2YwbEdHREsvWjVzUjVyT3RSQm9rV3U1?=
 =?utf-8?B?WUtmdEQ4YlVjamlkUFpQbEtHVVRuc3l0ODRNSGxhTC92OU8xTEdzekhaL1RL?=
 =?utf-8?B?UThLR2ZQVnd0OU5xZXNWbFdLNEhCSkNtaUNLYW1HRCtOMVdNOWowaVhacE1Q?=
 =?utf-8?B?WWRTMzZZOFlVblMwL0FzLzF4d1czSFRhTElMUmlZL2pXL045dTBnWWtRdjFC?=
 =?utf-8?B?TlFrRTdQOTVraXpYT1d5K1ZNd29wMGQvK0d2TFhGUnFNMmJEMytaQXlaTlBD?=
 =?utf-8?B?eTREa0pnZGVFdkRHNDJFdzdpeWFsQ0xzaUx6OVYwcUNiL3hCN3JlU3RnSGtB?=
 =?utf-8?B?L3R4eFhGV0p0QVliY2ZldGk4SVEwK2N6RGtxOHkyb2JrODkxa3kwRnhIU0xu?=
 =?utf-8?B?UzJtaVpIZHBDSDZmbXl4Uzk2UjJBaWtLK1l3Y0YxbDNMaWYya0d2M0lFdXd0?=
 =?utf-8?B?UnE1TXd6aXlYMStEanlsRXpTSlNQV3d2bG5zZU5iVkJPTGRCNWZrQncveVZi?=
 =?utf-8?B?S2VEQmU3ZlVaeXUzMllJb1ZDbGpYb3JZVFFRSEZMNnRUY3puRkVVY3RjNmk3?=
 =?utf-8?B?OXY3T0JweU5nSHlxbUZRM2d2ajZsdG5ZdlVvelozT2xCQnpLME5ZS3hVeU5O?=
 =?utf-8?B?dUhvZmoyZ1ZyK1pLR3BnbklwWU5uOHFmdXhWN3hiMWt3K1MwNDRoeFVYSTdj?=
 =?utf-8?B?dDdDVk1wQ1M3ei9rOGYvVk1rYXg3azFlNzk2SHpxVW9PV2JGa2VxTlE5aGJs?=
 =?utf-8?B?anF5T0d2cG9sRmszMUJJcmJpTU9Dc0s3VGFYN3h6RVd0eWJNMEhVdFk0Tm83?=
 =?utf-8?B?LzlTaGZJOVJacmxFZmV3NG9qTTRxbVdGVEk3Um9xNE1kQTZienVvYVlpamtX?=
 =?utf-8?B?U3o2S25HdngxTUVaN1JMei9FTythaEhFYUEwM1dybW1CaU9ObjhFcGhzdGky?=
 =?utf-8?B?ME9pZGtFZUhwOVQ3blB2eUVIMy9PVjNiZEs2WjNNWmRISzhSVE1oaXRZbFlO?=
 =?utf-8?B?UEdiM3JJeU0wSktpMHhScWUyVnBsRHJhNWFrb3VSQVVkSHZsRU1sTTgwQTJw?=
 =?utf-8?B?N25SZlp4WG5RTkNzTDkzNGoyMCtwN3lvWGhpUFNaUDlFK0lPYjU3Z0ZkWnFN?=
 =?utf-8?B?Q2pjeEo0TGh5eUNFY2xKWmRDQldxT1NZL040MEUwOTZNOTg5ZytVSmtnNVZB?=
 =?utf-8?B?TFJJK3F2d2oxZTE3SkRPODZmOVhld25mYXVsTmRmbWNReFhGTFk2TUJUbUo3?=
 =?utf-8?B?UmU2NEtEay9tcTNRNEtjMmJ5Z0wzcE1QRElMN3dodVlVbWpIZk5ZZ2t0MzJu?=
 =?utf-8?B?MENkWW1hZEVRNGRzQXh6NENWZHZGcW0wYlZsS1hQMnJGT0lwZmFaVlFJYXBH?=
 =?utf-8?B?M3hxSTNJc2xTdGQzZ0ZYbU1haStFMDdFdktRMzhMUjExSGIzd1M5N2UvYyth?=
 =?utf-8?Q?BJk/yY37EmAqcCkkZ7cfkx5ZZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6f037781-2e0d-4125-1a9b-08dbbeb5403d
X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5984.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 17:23:08.1861
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J78+xoCUwIJDgCsxZKXR0D1c42WXae+I1RJGKXzofb+DbNRt4lKPsTOVG3Tnl09zJj9GVMnF9rLwumMp2dl/+w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8229
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 26 Sep 2023 10:23:28 -0700 (PDT)


On 9/24/23 09:22, Fenghua Yu wrote:
> idxd sub-drivers belong to bus dsa_bus_type. Thus, dsa_bus_type must be
> registered in dsa bus init before idxd drivers can be registered.
> 
> But the order is wrong when both idxd and idxd_bus are builtin drivers.
> In this case, idxd driver is compiled and linked before idxd_bus driver.
> Since the initcall order is determined by the link order, idxd sub-drivers
> are registered in idxd initcall before dsa_bus_type is registered
> in idxd_bus initcall. idxd initcall fails:
> 
> [   21.562803] calling  idxd_init_module+0x0/0x110 @ 1
> [   21.570761] Driver 'idxd' was unable to register with bus_type 'dsa' because the bus was not initialized.
> [   21.586475] initcall idxd_init_module+0x0/0x110 returned -22 after 15717 usecs
> [   21.597178] calling  dsa_bus_init+0x0/0x20 @ 1
> 
> To fix the issue, compile and link idxd_bus driver before idxd driver
> to ensure the right registration order.
> 
> Fixes: d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")
> Reported-by: Michael Prinke <michael.prinke@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dma/idxd/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/idxd/Makefile b/drivers/dma/idxd/Makefile
> index dc096839ac63..c5e679070e46 100644
> --- a/drivers/dma/idxd/Makefile
> +++ b/drivers/dma/idxd/Makefile
> @@ -1,12 +1,12 @@
>  ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=IDXD
>  
> +obj-$(CONFIG_INTEL_IDXD_BUS) += idxd_bus.o
> +idxd_bus-y := bus.o
> +
>  obj-$(CONFIG_INTEL_IDXD) += idxd.o
>  idxd-y := init.o irq.o device.o sysfs.o submit.o dma.o cdev.o debugfs.o
>  
>  idxd-$(CONFIG_INTEL_IDXD_PERFMON) += perfmon.o
>  
> -obj-$(CONFIG_INTEL_IDXD_BUS) += idxd_bus.o
> -idxd_bus-y := bus.o
> -
>  obj-$(CONFIG_INTEL_IDXD_COMPAT) += idxd_compat.o
>  idxd_compat-y := compat.o