Date: Mon, 12 Nov 2007 17:59:53 +0100
From: Andi Kleen <andi@firstfloor.org>
To: Jan Glauber <jang@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Rusty Russell <rusty@rustcorp.com.au>,
       Pavel Emelyanov <xemul@openvz.org>, Andi Kleen <andi@firstfloor.org>,
       Jon Masters <jonathan@jonmasters.org>
Subject: Re: [PATCH] module loader should not complain about unknown symbol
Message-ID: <20071112165952.GA26064@one.firstfloor.org>
References: <1194877107.5656.31.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1194877107.5656.31.camel@localhost.localdomain>
User-Agent: Mutt/1.4.2.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 917
Lines: 21

On Mon, Nov 12, 2007 at 02:18:27PM +0000, Jan Glauber wrote:
> If module A depends on module B and module B has not yet finished its
> init() the module loader may print a warning about an unknown symbol.
> 
> This happens if module B is still in state MODULE_STATE_COMING,
> as module A runs into resolve_symbol() for a symbol from module B.
> resolve_symbol() return 0 in that case and causes the warning.

I don't think that patch is a good idea. It points to a kernel problem of 
some sort that needs to be resolved. Making it fail silently is not
an improvement.

Also how else should the user know about "legitimate" (not caused by races)
unresolved symbols? 

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/