Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2117461rdh; Tue, 26 Sep 2023 13:02:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE4xz3N1izLdrBwTGEofU3IAlpEDDOB1xGEEWiruQFDaGCUowthA1qepPeWTemdbRdz8ZnQ X-Received: by 2002:a17:902:ea05:b0:1c6:3157:29f3 with SMTP id s5-20020a170902ea0500b001c6315729f3mr2491590plg.36.1695758541064; Tue, 26 Sep 2023 13:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695758541; cv=none; d=google.com; s=arc-20160816; b=Xiu0SpfrN3eEOg0HtBUVCYywJZFZPMDItLhmoDEUMsITtRA5/w0KIJ/PyfN1NAtM8q 7lDxFulQQ480r6y38zBMggZ8z3pjCvKrxnm0O+Djb5hdLW9YM12tZ2KYHVL5suQhkUnR uWpcHDebYEypi75AGncfL21iAnMOxpOYF8tVWKKmBUrWOW4ITOYeYH9hjWnD0idm/88F NlsLTmSGEcCVOjkNZeKuo3TABPGkTC3x6KMlq1aulItU4iKoKVfQDDGGXLDUQ1sueQEb GILXcdDToFKwYOCmix63v1EC82RUVXOuts36zVEdSfY+jq6lQMy8JlP6LrV78U4I+AaM 8/dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=Cx3P9XMJrUWs/rcJWQ9bHQisSJ4667Rmi6WpZzvHcL0=; fh=LJbrU5fdAqUoB8gbVw+4JJvBbiqLXP7T7/gPka3FX20=; b=KMdgEgeoegtEiU+d5mKYwBuS4++6HDfviH/ddHx4qASW2n/4CvcJxDlALrqok9Dv8z dRpoWi12Ysc7iBFUPovanRCTHavUXnlnu3ar7GMW6Hxjl1wzETJq48Nuqu0kzx6K8H71 EKhXPZMlH76DG1DvkJTzl9J4gs2Ni8rzU2Hj7sKOjGHVuElhcGndvXprX15l1LaQyYbb VbvElmUOZq06irswQn0PY1sKpOEeUtcUwVd3Jo3TicTs8BSyffsm+JTpSDGUAMuYEMGE mfRZBWJxZ14VrYar9BDehpbt7cv5XwYetjhEOQtS5J+apnyeRh7J99i2szbnEjneFYA1 BX2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id j5-20020a170902c3c500b001c6036c5b74si8118522plj.245.2023.09.26.13.02.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 13:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id EC9A1807FCEF; Tue, 26 Sep 2023 12:55:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235695AbjIZTz2 (ORCPT + 99 others); Tue, 26 Sep 2023 15:55:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229862AbjIZTz1 (ORCPT ); Tue, 26 Sep 2023 15:55:27 -0400 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A72299D for ; Tue, 26 Sep 2023 12:55:18 -0700 (PDT) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-40471c054f9so28420625e9.0 for ; Tue, 26 Sep 2023 12:55:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695758117; x=1696362917; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cx3P9XMJrUWs/rcJWQ9bHQisSJ4667Rmi6WpZzvHcL0=; b=gSmCall1GT+FaU9OHrP1iSkbod3jw8SWOAlvFqIpvxHDqJWZlMohRIYx3tXhzCP7oz Ql4Yjqp8C+oVed0d501aA80LUK/+RSqjG5YAb5T6fALu+i2L4nESrzo6DwYZ1EKUI8+1 3/2/gy3pVWd1Cg/tFI67qJ5IPIk49SyFz1hMOr62s1RIZ+TXpIGEKSxLKumoTg67R8Ry 2GdPmqtpnbX/JCoISC2BptPLM0DmTQWI8Y1SmOXbwJ1lMjsWbSBsXDm8kptDpNrah1om 94H35YXGI3dfCJsczX1gGHYxKqhUQ2WtcSHCrHlxs491HcZdidg1+z+To2dWJj8aIuPE vq9A== X-Gm-Message-State: AOJu0YzdUOr1uFPR9rP2lQdyDQ3uyGPEnvy586s0EAIyGtKGEoMqtCzd ualuB92TjsfaaEpLAXvI7cI= X-Received: by 2002:a05:600c:4e05:b0:405:3cc1:e115 with SMTP id b5-20020a05600c4e0500b004053cc1e115mr9594967wmq.3.1695758116659; Tue, 26 Sep 2023 12:55:16 -0700 (PDT) Received: from [10.100.102.67] (46-116-234-112.bb.netvision.net.il. [46.116.234.112]) by smtp.gmail.com with ESMTPSA id n14-20020a5d400e000000b00321773bb933sm15558190wrp.77.2023.09.26.12.55.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Sep 2023 12:55:15 -0700 (PDT) Message-ID: <709e6baa-8ac5-4f2c-984b-0d7b06deb7d0@grimberg.me> Date: Tue, 26 Sep 2023 22:55:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmet-rdma: use spin_lock_bh() on rsp_wr_wait_lock Content-Language: en-US To: Chengfeng Ye , hch@lst.de, kch@nvidia.com Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230926172208.55478-1-dg573847474@gmail.com> From: Sagi Grimberg In-Reply-To: <20230926172208.55478-1-dg573847474@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 12:55:39 -0700 (PDT) On 9/26/23 20:22, Chengfeng Ye wrote: > It seems to me that read_cqe.done could be executed under softirq > context, It doesn't though. > as done callbacks always do, and it acquires rsp_wr_wait_lock > along the following call chain. The CQ polling context is IB_POLL_WORKQUEUE, which does not run in softirq.