Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Biju Das <biju.das.jz@bp.renesas.com>
To:     Mark Brown <broonie@kernel.org>
CC:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Biju Das <biju.das.au@gmail.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: RE: [PATCH v3] regulator: max20086: Drop ID table
Thread-Topic: [PATCH v3] regulator: max20086: Drop ID table
Thread-Index: AQHZ8I6YjFD7lOKUy0iL5yFVMsO7drAtPJSQ
Date:   Tue, 26 Sep 2023 15:36:04 +0000
Message-ID: <OS0PR01MB59227E269E915E313109524686C3A@OS0PR01MB5922.jpnprd01.prod.outlook.com>
References: <20230910065444.25906-1-biju.das.jz@bp.renesas.com>
 <ZRL5ahsXZ5u3brDB@finisterre.sirena.org.uk>
In-Reply-To: <ZRL5ahsXZ5u3brDB@finisterre.sirena.org.uk>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RXq+V+JRhFZY8flIVatgUyuHcn8FWO+Ymu9lr3tAeM/FnDnbYBfVYxXl21Rn?=
 =?us-ascii?Q?2HmrteV9BAl3bLsRbuEc6jAKbwQHzLPlNdF9rtWt3jljmM7YNfQcwjgruEt8?=
 =?us-ascii?Q?gETWCmV5LX89RaqetoxSm449Wl4qwvOZzxPQR0YrJJB2ZWcD23nusSmbnj0j?=
 =?us-ascii?Q?SF3pQQd6DWX7vk8MdRb4R6DJ7Ox8SrXcvHnxtXbU3BNWCc+v3caEMZQOGB4P?=
 =?us-ascii?Q?CCAekaHm2H3YrF1XG1wx8Xhnvqx4qgvAVN5sDUpp2zX2SQV1KXaun8je5zOA?=
 =?us-ascii?Q?udj6BnQaXovgCqNtSgn9rqmspGPNFVG6OswGD04waGFQkZHLvK8gZYvT6O9E?=
 =?us-ascii?Q?irEs+IRuRP6yOHcDopUudDQmKfsP3cH5gze2wN9JOOf6taOXh9Rm0XKbJ6PM?=
 =?us-ascii?Q?r5uoqFp3WETF1DURLkXLyQbGoVPc377DIS5U/nQKdlX1cv5tMJh8lb/zhpk8?=
 =?us-ascii?Q?xBbIcE4+Ag4zQ2yRpg6d2N22h8pQ419qd+E/w6VnFeyq0HYIvPr95dYZPrq5?=
 =?us-ascii?Q?/uQUDi2+xV4BH6cMDl65LIe5gTtxMyQ56KIm8FrJc+Masq0xyWuh1SgHxrGI?=
 =?us-ascii?Q?1XSo1twDPmzkoEj51ljrBCOBwam/JRcaBSnVryQovCVB6vEWsGe7TGtd2MPZ?=
 =?us-ascii?Q?4Si/XK6zuRItWbfo0nkEPa4uciDF9T+ekXSbDjRsCdE2hZlfPHXZzJwb2Sdf?=
 =?us-ascii?Q?86YhsGFb8Bh+nGIjy3sZCAgChTCnlUpKGnFXuwcgk0q2zWZ1SCpdJ62dqymk?=
 =?us-ascii?Q?kk2suFXTzRpZMTC6a6I7rpKxWQlMn+6zlTCvbWAVBMFsBv5CVtFMojwuCt7j?=
 =?us-ascii?Q?YMNC0BX9Ns5rcs/kaJ09GTiuoJFINIwkB0gJJzym5ZROpUjhpG7rPLBkSXmE?=
 =?us-ascii?Q?p2S2Kbxb9S+oMniizG0oJSOYVgAbrxzFY+zahm4oH+v7EE5ahoxFc391Mymo?=
 =?us-ascii?Q?VAoeA3gP+0GBUNCHn0dUW5YU+Rnc/sofiWS1c38GF1TDHZnuwhS7p7LYSwwk?=
 =?us-ascii?Q?KdXlEDVKLdLXa5/dijdqSVhjvzQyKyBmdqSXWntF8jyCHJcxl8zI1efSA8UO?=
 =?us-ascii?Q?KUFqA2LbqG3pRiQCLzBuQU6iUXoFzqaOWuXio64DX4VvaDqBLG2qJIC3PTxZ?=
 =?us-ascii?Q?5ld5eov0gnuzmQPnlznLbT8Xaim2/Kn61F9qBhe7gpMI5RR2os01ygIm6ZiK?=
 =?us-ascii?Q?HLUAxt3BiyjGbVcTx/Mo4jzOGAm0gW9qsv0vr/Ac4N6XkQu8V+nl8POcR1qM?=
 =?us-ascii?Q?LFLPvJQMLEO/ksPgTHe6LcHsjn+o+SVC3kschi6AQXyz+yXpfbecRU/0BaCJ?=
 =?us-ascii?Q?+6a/Yy4RPwjUQDXII//u3Vh4Pu/ZJTrSC3TCUmEiHOpAEPTfnUiF+Op+HPVD?=
 =?us-ascii?Q?3OQc6yusDq2usW5xrL85VCaCJRvmAvdOMcJI1Snrh+k7HXn57QQfbP28be2T?=
 =?us-ascii?Q?xP1aI/zTh9+FnelED9jYdDJET4UK1vdbnx0Va80N3HX7C90T5mDZNk7Fwt2N?=
 =?us-ascii?Q?IIatTlbWE3dDF1RscjNMTXTZVcRPDlJWpNUjfpEHQRN8crhV6O0ZhkgXUIeR?=
 =?us-ascii?Q?5kMi6evT67GvNqkw2K26+EV+W0xTAcP0bSDnPoAYq9BFzjtjPoA2F8MeDfw3?=
 =?us-ascii?Q?jw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: bp.renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: OS0PR01MB5922.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78eeae48-319c-4fc8-fc29-08dbbea64be1
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Sep 2023 15:36:04.9457
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: EcHp65/S5coaALvc+JWf2voFxklhBk/ZOzO4HQec9YT5l4g6zweTKJGAC3teNM5iVBmj71lByVj6EBl70ugb7p2+g4X14ngMp4rObBeggHE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSZPR01MB9457
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 08:36:25 -0700 (PDT)

Hi Mark,

Thanks for the feedback.

> Subject: Re: [PATCH v3] regulator: max20086: Drop ID table
>=20
> On Sun, Sep 10, 2023 at 07:54:44AM +0100, Biju Das wrote:
> > The driver has an ID table, but it uses the wrong API for retrieving
> > match data and that will lead to a crash, if it is instantiated by
> > user space or using ID. From this, there is no user for the ID table
> > and let's drop it from the driver as it saves some memory.
>=20
> This doesn't apply against current code, please check and resend.

V2 version is accepted and is in next [1]. So I would like to
drop this patch as there is no harm in supporting both OF/ID
tables. Please let me know if you think otherwise.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/com=
mit/?h=3Dnext-20230926&id=3D9d9cd8e6a4572efa328ef72a83bbc78a39deca37

Cheers,
Biju