Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <56cc2e4e-81dd-f2d2-f690-6d82217b9e7d@intel.com>
Date:   Tue, 26 Sep 2023 16:25:26 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH] iommu/vt-d: Introduce a rb_tree for looking up device
Content-Language: en-US
To:     Joerg Roedel <joro@8bytes.org>
Cc:     kvm@vger.kernel.org, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, will@kernel.org,
        robin.murphy@arm.com, kevin.tian@intel.com,
        baolu.lu@linux.intel.com, jacob.jun.pan@linux.intel.com,
        yi.l.liu@intel.com, yi.y.sun@intel.com
References: <20230821071659.123981-1-jiaqing.huang@intel.com>
 <ZRFA3uj1-QjlXpGx@8bytes.org>
From:   "Huang, Jiaqing" <jiaqing.huang@intel.com>
In-Reply-To: <ZRFA3uj1-QjlXpGx@8bytes.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/25/2023 4:12 PM, Joerg Roedel wrote:

> On Mon, Aug 21, 2023 at 12:16:59AM -0700, Huang Jiaqing wrote:
>> The existing IO page fault handler locates the PCI device by calling
>> pci_get_domain_bus_and_slot(), which searches the list of all PCI
>> devices until the desired PCI device is found. This is inefficient
>> because the algorithm efficiency of searching a list is O(n). In the
>> critical path of handling an IO page fault, this can cause a significant
>> performance bottleneck.
> Can you elaborate a little more on the 'significant performance
> bottleneck' part? Where do you see this as a problem?
>
> Regards,
>
> 	Joerg
While lots of dsa devices were enabled, parallel dsa_test with large 
transfer size
would be executed ineffciently and cause cpu stuck in 
pci_get_domain_bus_and_slot
by lock competition. The introduced patch could significantly improve 
the speed and
prevent the CPU from getting sutck. It maybe confusing for "significant 
performance
bottleneck" since it didn't benefit all the cases, would rephase it in 
the new patch. Thanks!

BRs,
Jiaqing