Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2143263rdh; Tue, 26 Sep 2023 14:00:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRAZ8AAGp0bkGkwQxc/2m/YZEQMNMWgzZ1e4jm6IiSKS5rN+U3qRN7wQ83j3wERn3jHaMl X-Received: by 2002:a05:6a20:42a9:b0:14e:2c56:7b02 with SMTP id o41-20020a056a2042a900b0014e2c567b02mr61267pzj.0.1695762058060; Tue, 26 Sep 2023 14:00:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695762058; cv=none; d=google.com; s=arc-20160816; b=uZPA6iN6diHF0eYiOyVlcWDBfOcT+NLioFJ7Fpgp7WDGOrQN4TcjjEpt0KRE7KmbOe dKDZm6Eh1leUB/ncyaDELBzxJS0r0eNyhnf0lAOwkIhW9blmlP37GKwqBnVUoG8Z0q3c U9c2n4uTTAthOczoM6wdNdUc/m8i3Qnp6+qQ7eo+/75p+HIn04vmHK6lJG/Jn4KKTA7M OYaGcfCCMBQ0otLaj4g5AfCoZMNLD1oM9Dt4TQBLZVGud+5loJfOaaDcbdoRidUlw+iE 2yNbbmpFP1lWXqlH5+bxa4xOCVdI7TUrVpc10XM8Jlq4ZpfhYcF8M7tky3Q+JmGz+TxV zfvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=TqGYzUkPo9ceXnSLTGK/1FGYMyC5di+Yd9Xyu9ssITE=; fh=pmO2GOaxRwgO5+LItasZBY6NOhKBrZd5NDojoBR8jzw=; b=l1gWh2YL+77iDL8o5Z+N/C8ir5CzI1OTz90kvhMC+zodBiSiLuobYp3335VcAZnjWY 3s8KOhBSq69QiR8Q0wnhZyuu5edYJliIcgiebT3nVDLE62qYswCF8FDseMqsQm6WtZx8 TFmE0Vw1Lc4vpkS1OjQTN6nWerk+C+Gx/DVxe7ndqnv20ZjW7tcJokDDGj9e5Lbbb+Kb PT3cWXWKX+NN19bLg4R3HugQMvuaEE7jXnzmsBtoyw/wdSgwdhqc09wR6NCL7AmsY/NU 7uOZzGV26G5fH4Fuowmc7u8TRioUlN/nk9vasE3kqR/GepbZonoM20UsnTZmUy7+gbF2 LuwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=guiyNTX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id n40-20020a056a000d6800b0068a590d803csi12755681pfv.361.2023.09.26.14.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 14:00:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=guiyNTX9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B7BD3813CD9B; Tue, 26 Sep 2023 11:45:48 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235484AbjIZSpu (ORCPT + 99 others); Tue, 26 Sep 2023 14:45:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjIZSpt (ORCPT ); Tue, 26 Sep 2023 14:45:49 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 861CD11D; Tue, 26 Sep 2023 11:45:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695753942; x=1727289942; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=wALDOfDch1TypPPb0YRrudhRYM25aDx55qWGrSyEGzQ=; b=guiyNTX9wWq2ZDr/h2kpebrT7/oGhhp9gIVi6tQkI1MyXKy22ry/PNVs 2V5H+pDOZVj+tgrKrf0+CJW7IMpDnNAb3F0IgRFKpRC5XkKYp2YOepRMj 14kCMbzAGkQ/oh3HnK/Qd9u/6ZRdAW5/cYCa4hPhlKbXFxYiuUPBl8l8H F+MkU9eHdgFKq14THWso8M21WC5+vazbiOSzif3Sukm9PFSUkp9i9nf20 gSDz1sKvLtQPGyHjxPLCjb1HdCw9hLDkEgfxrNoAuwVu9h4sDZLwZxcJv RpQquDvdWHfs3pZ/GuxCReHBnwEzKKXdmgV/GbYVBp8V1DXKH47RiSIuG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="378920251" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="378920251" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 11:45:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="752279630" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="752279630" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 11:45:28 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev Cc: rafael.j.wysocki@intel.com, andriy.shevchenko@intel.com, lenb@kernel.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, Michal Wilczynski Subject: [PATCH v1 0/2] Fix memory leak and move to modern scope based rollback Date: Tue, 26 Sep 2023 21:45:18 +0300 Message-ID: <20230926184520.2239723-1-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 26 Sep 2023 11:45:49 -0700 (PDT) In acpi_nfit_init_interleave_set() there is a memory leak + improper use of devm_*() family of functions for local memory allocations. This patch series provides two commits - one is meant as a bug fix, and could potentially be backported, and the other one improves old style rollback with scope based, similar to C++ RAII [1]. Link: https://lwn.net/Articles/934679/ [1] Michal Wilczynski (2): ACPI: NFIT: Fix memory leak, and local use of devm_*() ACPI: NFIT: Use modern scope based rollback drivers/acpi/nfit/core.c | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) -- 2.41.0