Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2151615rdh; Tue, 26 Sep 2023 14:18:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHdRNgBq6K2dnqDVALef7OmzGR/VGKYc+INw7Ew3/2ozw0feaLMAD3wMKi4l/6pSYxU5ei8 X-Received: by 2002:a05:6a00:2d01:b0:68f:ea5d:1f70 with SMTP id fa1-20020a056a002d0100b0068fea5d1f70mr186573pfb.14.1695763102970; Tue, 26 Sep 2023 14:18:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695763102; cv=none; d=google.com; s=arc-20160816; b=MrnTezwkOAVTP0NWL85boczUQWFl0xHdhct8E91Y8h6zZqIagVs8WrRG4Jvp/u7Zle hf948jLhyMwIMh4lSoMONuCZx8w01JoXc++LxbDNlj1+Rr421QnvSX4gG7S29Rz4sNpM lXT585VHmL4cSZ2H4OzgBS53Oy6qQNhNG9v2JmH2GmwnztL/gRP8VMDA9CDgs68egl7C oaS98BTb9bvhFaYbT5lkEK0m0G1gmpOHXNgBLCRDXuI6n9o0C2TWPuj7fjXGPzbDzUpN j4a96r8UUcYyM0kUKC4fmQYizQszmPCzyuNvLTEhxsCUFDiAbA/aUxMTHf4SKKDoZ7Uf an9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=dzh4YtXiS4cImmoubz/oXXNxaoJ+e/awu7IEoNgeBog=; fh=+4UO449wtpxwNnbfNVpLMpmKZoAQMOcWKjRmcnHNo+s=; b=g6rEMemlKrXk1fyinrMM+xck/0vw47lp/dQ/6YlDCmuRVrgoZmayKUsJrk/bWWc2tG T/PckxjKhUK97fBia9wM22zoJXWIY2jHpV22V0tkUewYjNYkmHndQqX09eN4LMJTIgL5 7NA0XDN7+z5NxW8cDZkg+5Epx7B8hh5TjDGTdROfXUOJnko1cjI8P4GYUQQAynOEY39W CvDJSsHMkbk36ibWfFOk/W1a7VZ9X3JCqoqMVcP0U+gAmcYVWCgwmfd7ASivCPIcpS6z MXZJE4vb2SUVtgtI5FvkARuvA9JMV/zImVyF/KuJZoKkfLooH6ZtvhZOF4HBMB12mFrx FULw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Dk/QzbfU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id f8-20020a056a001ac800b0068fd0b1bd61si14458379pfv.50.2023.09.26.14.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 14:18:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="Dk/QzbfU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id F299A8098B94; Tue, 26 Sep 2023 09:06:09 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234990AbjIZQGL (ORCPT + 99 others); Tue, 26 Sep 2023 12:06:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233451AbjIZQGJ (ORCPT ); Tue, 26 Sep 2023 12:06:09 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4ADDFFB; Tue, 26 Sep 2023 09:06:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695744363; x=1727280363; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1d47nvRusVKBELm9EbFnAsqAr8P3Sbsc2oZYIgRvtgk=; b=Dk/QzbfUTV1+9t+sR6W7F+IkDajqZ9htHStn2+4ZgTk+JQATwFMiqyul 9lBqP7o/yg03klJA+F9dhv7+nWq61Ux/BqUeRpySTaOhFHX88Z6IA6J9/ N1YhbvFLj82Q27bEcxQKrTz34mBUsU42MKeuuA5Ruuiqq5kOGgPUDbv2E AK8x9jZ87YTxtDesE0PukSkZBJLT8FnaVmENxrk4Z/HxCKekjfVer+iA/ yRiZDlatQzqFcMyx6aYdCZbFB1sebbqpxr5uPtHOLq8gaa9sqDqcdGkdb QGek6JjBjCUdfbBDAB2+n5iIo+XZoTYzZ/FJlQ6DFV2Z6XNgCNTHiyhcA g==; X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="378880240" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="378880240" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 09:05:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10845"; a="1079753902" X-IronPort-AV: E=Sophos;i="6.03,178,1694761200"; d="scan'208";a="1079753902" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga005.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Sep 2023 09:05:33 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97-RC0) (envelope-from ) id 1qlAZ0-00000000eps-1VMc; Tue, 26 Sep 2023 19:05:30 +0300 Date: Tue, 26 Sep 2023 19:05:30 +0300 From: Andy Shevchenko To: Mika Westerberg Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Raag Jadav Subject: Re: [PATCH v1 1/1] pinctrl: intel: Simplify code with cleanup helpers Message-ID: References: <20230926132336.416612-1-andriy.shevchenko@linux.intel.com> <20230926153729.GW3208943@black.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926153729.GW3208943@black.fi.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:06:10 -0700 (PDT) On Tue, Sep 26, 2023 at 06:37:29PM +0300, Mika Westerberg wrote: > On Tue, Sep 26, 2023 at 04:23:35PM +0300, Andy Shevchenko wrote: > > Use macros defined in linux/cleanup.h to automate resource lifetime > > control in the driver. > > > > While at it, unify the variables and approach in intel_gpio_irq_*(). > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Mika Westerberg Pushed to my review and testing queue, thanks! -- With Best Regards, Andy Shevchenko