Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Tue, 26 Sep 2023 12:56:34 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Li kunyu <kunyu@nfschina.com>, <gregkh@linuxfoundation.org>,
        <dan.j.williams@intel.com>, <pasha.tatashin@soleen.com>,
        <andriy.shevchenko@linux.intel.com>, <Jonathan.Cameron@huawei.com>,
        <ira.weiny@intel.com>
CC:     <linux-kernel@vger.kernel.org>, Li kunyu <kunyu@nfschina.com>
Subject: Re: [PATCH] kernel/resource: Remove unnecessary initial values of
 variables
Message-ID: <65133772ea921_e18a62948f@iweiny-mobl.notmuch>
References: <20230926014548.31523-1-kunyu@nfschina.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20230926014548.31523-1-kunyu@nfschina.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?vzatJb6UGX1qBL5O63UG5P6Odmjpw2bw0RgQhIfVIsvhFl7JhcpsIUMP6aUd?=
 =?us-ascii?Q?yFTxMfjDLjavZ5zKg0/SMGVSIh+4vxCySN9f48K9rPajDxYLviz9ys5KLZXZ?=
 =?us-ascii?Q?GjheRQiLU0r/IbtkgL3PzhW/a0rJ4F/F3QhDA4ur6UE/rYUUltCtPuYCPw65?=
 =?us-ascii?Q?f3Y/5AGs3E2aG2nBKSUj5K+28VtDxINxl90JDTfVETaHW6UhSF+3oz9O8YOe?=
 =?us-ascii?Q?CQDvO3O37S/i2fzk94gI6/vVRxDsPF10etay1srjtT22fvGw+qnLQRkeXdXf?=
 =?us-ascii?Q?cVZebMjwSHOP1m45E/VqzYxwJ08rP8lQi/SwyWjA0/ymL+f0wkTaQYht52S4?=
 =?us-ascii?Q?G4USnAr0L8yCkYZ5Y3I8OyURT9t0GlFnTLE8aI9zaQ4i3ZsetFtONlQTUx3M?=
 =?us-ascii?Q?mr5SbCuCF/wIIqaEavAGmxcxuiyqE7ABV8LLvzZ5Wy/UUhMpz0zM3TEOyvGb?=
 =?us-ascii?Q?1i4jaSPZv3ZcZj9TlYkXgL6saJu8qr8hsWSSa9ZuKWF8xllt4KnFsiwwpdCi?=
 =?us-ascii?Q?Aj0f74Nz1X5wowpqoI3ZtaIGrXhkTkUqKqEnlhU0sngOrI1n9OzjuU2v59N0?=
 =?us-ascii?Q?h0ATaP8TezShfqdz6tH46JoMJSCX56KCuuvrVKIpef/i43Yts+cN5S+RpFqg?=
 =?us-ascii?Q?TMVCEg7TQ9XbNTRE09bLRJhol+nNkSIzQC7W+yheuOs6K+yCpQ/v0UIyCZ+6?=
 =?us-ascii?Q?AcjgcdX2NAtHw9EQ9Ztgfn5wm44oMFntjAmCC9+S8RMWEQRA2U6D9agyaylK?=
 =?us-ascii?Q?m4uW8Jgw8zxOXH77x2ZA3hOa0IlJcLJzvApI1IRysiB2Y48DMP9dwNpiEUNt?=
 =?us-ascii?Q?1cS6MRNvmt2I1tueY7pO9NK8B5Q1KFksRNTGYQsHPvBkchANTL2AOgjtlF7M?=
 =?us-ascii?Q?FQfVNH4tt7YQJCBwf2WulTnPzvN5ZpdwCYpTOGKBHu1QnVG5H7Jrved/kzd5?=
 =?us-ascii?Q?EiHLBv8b68EpM//v7QkRM2ht+K/9wWUUMaT0eCSfX9BeaZ8yTuj6kj7TKurG?=
 =?us-ascii?Q?YcpWZxPf9lZbJpqYLSRSIiVbzKmyvGyHjL2sjbT3snHruSopmPnq2X5FdaFn?=
 =?us-ascii?Q?zkkPinHnEu6Mb1sHVMKRiqS3Z5c71rmFomA1MvUdIpXcuRHIcqf2cGPpGmko?=
 =?us-ascii?Q?5HKrNs+5PggUJAsBSnjjsZAeSJYHCZ/1m2DFboiiGaqBuUDRwO+R5+lPD01T?=
 =?us-ascii?Q?coWgnznLj0uVv+r0KGgQ0xTfnJ7dO/ATc2l9wbsxynUcti0M4x1tYKByEqEL?=
 =?us-ascii?Q?Wkx+1VXaJrRhSJPndNy+kraXB0aIcBi4tlvDouZmZKj6Olm2z/HmZ2nY+20A?=
 =?us-ascii?Q?nrTB83Fr+0fbFbA5cBnI1lNALn5lEBzfh3qU0Kge5tT7eJpvec0rWl75wuNm?=
 =?us-ascii?Q?r02fWeLNxseAhK/BAGO6HzdP9+TuZoQn+H0xxFk1q8luRoRb29tHrLIsBddG?=
 =?us-ascii?Q?r5++q+HRHUlZpuptSXAY+0Mj4BamgPSa99Sb3EgTkXRxte0hjP99vuFtPJE3?=
 =?us-ascii?Q?WqCYNiIfCHq0uk53tQomP/IvmyjPtiuq1tnVzURewYnsoEGh9u7DUg8pqPOj?=
 =?us-ascii?Q?edfATkHUzQErwFTHiFD2bea/XjhrRRkYXPmZu2bu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: bc977fc1-0992-49ca-6015-08dbbecab1c8
X-MS-Exchange-CrossTenant-AuthSource: SA1PR11MB6733.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 19:56:38.5564
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x863uKWR/ZJfhBR7h+gi7mIMG0QS+Mwpf4dlBtENbIrmgRnNJsyD1FbnFGS/7GiPvXZPLoX/vE+tFBTTzfcsOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7871
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 12:57:06 -0700 (PDT)

Li kunyu wrote:
> err, new_res and dr is assigned first, so it does not need to initialize
>  the assignment.

A good commit message will explain _why_ this change is required or
desired.  Changing code just for the sake of changing it is not
productive.

Ira

> 
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  kernel/resource.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/resource.c b/kernel/resource.c
> index b1763b2fd7ef..bbd7c113307a 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -656,7 +656,7 @@ static int reallocate_resource(struct resource *root, struct resource *old,
>  			       resource_size_t newsize,
>  			       struct resource_constraint *constraint)
>  {
> -	int err=0;
> +	int err;
>  	struct resource new = *old;
>  	struct resource *conflict;
>  
> @@ -1310,7 +1310,7 @@ EXPORT_SYMBOL(__release_region);
>  void release_mem_region_adjustable(resource_size_t start, resource_size_t size)
>  {
>  	struct resource *parent = &iomem_resource;
> -	struct resource *new_res = NULL;
> +	struct resource *new_res;
>  	bool alloc_nofail = false;
>  	struct resource **p;
>  	struct resource *res;
> @@ -1556,7 +1556,7 @@ struct resource *
>  __devm_request_region(struct device *dev, struct resource *parent,
>  		      resource_size_t start, resource_size_t n, const char *name)
>  {
> -	struct region_devres *dr = NULL;
> +	struct region_devres *dr;
>  	struct resource *res;
>  
>  	dr = devres_alloc(devm_region_release, sizeof(struct region_devres),
> -- 
> 2.18.2
>