Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <4d014356-cab9-f81a-15b0-0ddab8a5222a@intel.com>
Date:   Tue, 26 Sep 2023 11:27:49 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH] dmaengine: idxd: Register dsa_bus_type before registering
 idxd sub-drivers
To:     Fenghua Yu <fenghua.yu@intel.com>, Vinod Koul <vkoul@kernel.org>,
        "Dave Jiang" <dave.jiang@intel.com>
CC:     <dmaengine@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Michael Prinke <michael.prinke@intel.com>
References: <20230924162232.1409454-1-fenghua.yu@intel.com>
Content-Language: en-US
From:   Lijun Pan <lijun.pan@intel.com>
In-Reply-To: <20230924162232.1409454-1-fenghua.yu@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmhYSGorYkFXL0RTRFFKZ3BJRnVud3ZGemYwZDJET2w1ekQrT2wrdjVmemNy?=
 =?utf-8?B?TFl4ZThKR1ZFMjUxQ3c5VC9WUElybkxndjBHeE1nV2dZL1I3S09GR2FhTENm?=
 =?utf-8?B?Vk1qb1haY21mU0x0QVAyK2prWEZpVVdCelFHSkVqVGZtd1hqclZaN29hNzNC?=
 =?utf-8?B?NHZUNnFvelJJQ2hOMjZ6UkRPN21DTEdUMjVKYUtoWTNDZ1dFQWt2QVhkL3Mv?=
 =?utf-8?B?MlhIdEZYdzlKQisvTXdFTDFBR0tLR0FuK3dGYzBndzlRRFkvZ1VsdEQ1d0F3?=
 =?utf-8?B?WmljeWJZeVQyaU9Td3Ewd3RTeTNWYmZpdURFZ0xTWks5MzU5WHZuWDBFU1B2?=
 =?utf-8?B?ekNSQnA4OTczZlo0ZU1mWGovOWFVM3FLcU8ra3JaZlNYNUcwTlp4K1ZQSWNr?=
 =?utf-8?B?U2wwRUhtYnUxUVhSQzF2RDZsbXMzakpNTERhNUdrWXREajZGYVRWdXYvV2Jr?=
 =?utf-8?B?cW5rRGtEMlkvN0xCZHFwQTYxOGp5R0FRK3RwdjhpWGFMbzJJSDhVQ0VHSHI0?=
 =?utf-8?B?YjFzS2YyeFFtS0lhb1NkVWZXTWFRVjJrcEpBaTN5cE1jZUw1N1pCSW9Md09M?=
 =?utf-8?B?Zy9kWGNTZk5kMHcrVlM2OEh3clFBYXVWRVhXZTY3ZVBkTStWaHAycGFPdHBK?=
 =?utf-8?B?OU9ySGNzcFM4Q3QrQll3L1JyYlowZWF0TUZxZnROQTZUTUI3QWZMemFlbGlX?=
 =?utf-8?B?cXZPKzFJdXVjUTVUMndTVlg2SFdjclZpZFlOakpScEVGcjgxZUNoOFRlaHE4?=
 =?utf-8?B?NWpUU3JUODlDUngzNmtYbnovem96VXljYVBvcDk3RTNYMXVReDl6cTZKT3JS?=
 =?utf-8?B?UTM3c3FjaHVSNEY4cUd3QmhRRFI0SUVQTVJ1WC9kYi9YVXNxdGJ1bTc1anc2?=
 =?utf-8?B?b0dUODVoZTFYSzMxdmVkUzNNK0tWVzNVYVNCYnd4amNtbFVIWGJ4TjlROGNV?=
 =?utf-8?B?L05xcmRPYWN5SHBqT3UzQ0UvZGpKV1ozbS94WUEzbW04RUhrZHNvTi8ybnp3?=
 =?utf-8?B?a2R0OFZBek1hVndxOTBYS3p1b1hWeDRnK0JHeExLUEVsdHJrczhqZDBlOW43?=
 =?utf-8?B?ME83bWVsLzMrVXU2UjF3VEdoeUhDZXA3YWZTbWlUUTN2aVl6VUxSc2c2RmJw?=
 =?utf-8?B?OE40c1M4VWU5OFcwTU1vU1hoYmJjYkRpTzZvSFdnYzFyT0V1RURUVW1ScG10?=
 =?utf-8?B?ZXluN216RVg5dXE4b1c1YzRSSWlxNTUrMjhwYXJLcjdnUFpUMGF0STR0T1Yv?=
 =?utf-8?B?V3pkQW5OZ3E4MDk5WTV2NTQwV01pUEQ1b3pjcDVNWUlZZ1dsRXlPb3lKbEFa?=
 =?utf-8?B?aHBwdTkzOXNlamw1U0UvWlo0elFWcS9YMElEUmgwUU9wNGp6U1RKdXhkWlIw?=
 =?utf-8?B?d3NCRW44a2Z4TWRWbGdJalJlWW9WOXk0dGtqajhkUXBXVDdZbElXa2E4eC9E?=
 =?utf-8?B?ZjVrbWN4N3gxdnFjYzJodE1XYVhZMm9MUUErRklEeEpJWDFuMGttQ0VhTXRW?=
 =?utf-8?B?M2lzYjdRaXR6Z0UzNXdBV1cwYmVROC9ZUENGU25NRlBxZ0VER1Uyekw4c01Q?=
 =?utf-8?B?YVFsL0dkUFhOSitFZFFTaUl6bWNPMmVTWW80Y1V0NU0xOXgwVTZrUHFsYkJ1?=
 =?utf-8?B?WUlwY0tiQ3BuMWQvT1VJRHV1NHJETlBUa3lQODhMeC80ZlVhZHduNzRIK2FX?=
 =?utf-8?B?NGF2ODdpMUZkaWRuM3h5R0VJTUZqTWhiU0ZqT3JLMGM3Ym9BSmxaMTdQSlcr?=
 =?utf-8?B?akkxaUZsK3pId095OThla2J3NmJUcURaQXhiR1VNZyt5VXVpNTFVY3NIMHAx?=
 =?utf-8?B?elFUL2FRVTdjcTZWeEZDUkZONzhRZ2MzVk0vSk92K3haVUdobzkwaXFiVEFt?=
 =?utf-8?B?K3A4d1FJRTdpTE5XNWcwandYZERTL2lNaGZuVDJiTi9PcVVmdFpBOENXRkJC?=
 =?utf-8?B?RzhOYUdDS0FZS3kwbE9QSnBmbGtMaVRWVTVqTENGMVRNaXUzV0hrQVVVK25w?=
 =?utf-8?B?YVIwODlBZW9KRVE1MzB3dG1BQ0NpVXBFc2xROFZRbkY0MHp2enhHV3NEWFJ3?=
 =?utf-8?B?aFB6MTRqaXZyTjdNRkk0V2xMU0t0MEcxR1ROeDgzTWVPSk5HSThmUW1aQ1Va?=
 =?utf-8?Q?zwlYlITrZNdvldcxu73AFFBJ6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 455e6ebe-ea51-4e8c-4ba8-08dbbead8874
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB7141.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 16:27:53.2686
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BTwsYsjMLRBRHphBnaHGji7MC0cP6NEfK0hwc9ttZ2ff4zEOhVkmd/GpvqJgpP+GN9YW6FVSTAx1/QZmHZaMvw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4629
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 09:28:20 -0700 (PDT)


On 9/24/2023 11:22 AM, Fenghua Yu wrote:
> idxd sub-drivers belong to bus dsa_bus_type. Thus, dsa_bus_type must be
> registered in dsa bus init before idxd drivers can be registered.
> 
> But the order is wrong when both idxd and idxd_bus are builtin drivers.
> In this case, idxd driver is compiled and linked before idxd_bus driver.
> Since the initcall order is determined by the link order, idxd sub-drivers
> are registered in idxd initcall before dsa_bus_type is registered
> in idxd_bus initcall. idxd initcall fails:
> 
> [   21.562803] calling  idxd_init_module+0x0/0x110 @ 1
> [   21.570761] Driver 'idxd' was unable to register with bus_type 'dsa' because the bus was not initialized.
> [   21.586475] initcall idxd_init_module+0x0/0x110 returned -22 after 15717 usecs
> [   21.597178] calling  dsa_bus_init+0x0/0x20 @ 1
> 
> To fix the issue, compile and link idxd_bus driver before idxd driver
> to ensure the right registration order.
> 
> Fixes: d9e5481fca74 ("dmaengine: dsa: move dsa_bus_type out of idxd driver to standalone")
> Reported-by: Michael Prinke <michael.prinke@intel.com>
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> ---

I guess it was always configured as CONFIG_INTEL_IDXD=m.
Good catch on =y scenario.

Reviewed-by: Lijun Pan <lijun.pan@intel.com>
Tested-by: Lijun Pan <lijun.pan@intel.com>


>   drivers/dma/idxd/Makefile | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/dma/idxd/Makefile b/drivers/dma/idxd/Makefile
> index dc096839ac63..c5e679070e46 100644
> --- a/drivers/dma/idxd/Makefile
> +++ b/drivers/dma/idxd/Makefile
> @@ -1,12 +1,12 @@
>   ccflags-y += -DDEFAULT_SYMBOL_NAMESPACE=IDXD
>   
> +obj-$(CONFIG_INTEL_IDXD_BUS) += idxd_bus.o
> +idxd_bus-y := bus.o
> +
>   obj-$(CONFIG_INTEL_IDXD) += idxd.o
>   idxd-y := init.o irq.o device.o sysfs.o submit.o dma.o cdev.o debugfs.o
>   
>   idxd-$(CONFIG_INTEL_IDXD_PERFMON) += perfmon.o
>   
> -obj-$(CONFIG_INTEL_IDXD_BUS) += idxd_bus.o
> -idxd_bus-y := bus.o
> -
>   obj-$(CONFIG_INTEL_IDXD_COMPAT) += idxd_compat.o
>   idxd_compat-y := compat.o