Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <3d5554d7-5909-b851-bbd4-6b58a79b7cbd@intel.com>
Date:   Tue, 26 Sep 2023 11:09:27 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 0/8] selftests/resctrl: Rework benchmark command
 handling
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>, Shuah Khan <shuah@kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Babu Moger <babu.moger@amd.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <20230904095339.11321-1-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230904095339.11321-1-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UzVSdkVQaHpINnNubGEwSFdPbEpIb1FTNVJJOXJyc1RWamhGaEQwZDVsVXNt?=
 =?utf-8?B?aExlRGp6VDlvaGhBMnA0WGh5QWU1aEUybWlxYTRwblRsemxVb0MxREFtNEpm?=
 =?utf-8?B?S1BRbVQrQjFGUU44WWR0LzdPVktLbkxOcCtqTHVHTlRGTjJ0VGZxOGxJUjdK?=
 =?utf-8?B?T3B2N0NyM0VYZmxGQ1hETVZZTDNiN250ZUdGdzB1U3BJeVk4amgxM2RMK1Bi?=
 =?utf-8?B?K3dHbDZhcDNCWXp4dEhMMDNXYWowOHM5UXNQZFNBYWpKS0dkZW9UQ2ZQQW53?=
 =?utf-8?B?UWQ1SUZZbXphdndRck5xWGpUMVVmbmtlTTRFQ1F6YnVmRDNnQ0VNR3NmWjZo?=
 =?utf-8?B?eTNFNGVUaDFhK2dBKzRTWFZ6dTlqMmtlcnR6SWtTSWpIaG5WOUVyTWJYVTdh?=
 =?utf-8?B?V0pKenAzZzdCalNZQVJkRy9icnU1RWFWSG5QL00xOWI1WUtqR1E1VlIvQm1k?=
 =?utf-8?B?M2VPNTAvdzJ1V1prYlQ0Z1FzZHZJSytMN1EvNVlMc1dNNUI0d1Q5bkJGZlY1?=
 =?utf-8?B?UTRTSDljUjRYRDlKV2NobjVnK2tnaWY1MFczOFd6U1pvLzZHTG45Vlp6Y1Zs?=
 =?utf-8?B?RFFsell3dklLYTVOKzFCS1RmbFFXWkdHQVU4c21JdTA1eXA2REZzbzJmREpx?=
 =?utf-8?B?akRWV1dhQ3p4a0NJeUk3cVh4eXU5RE9RcjJYTGxERG56OWduYkdDcUc2NjNB?=
 =?utf-8?B?TW9OSzQySjNwdG5pTXA2OUlZeWNtQkdhRDEwMWZQWjlpTXorYVdwR2ZDTEpw?=
 =?utf-8?B?WHhCdTBpVFQ3RGY2SHE5MzB1N3kwVXZGOUFSVU9ITUJhNGl5ZVVkRUI4Z0xG?=
 =?utf-8?B?VDNLcEVIRk91aVdybzh2djA2em9XTW1ZT2U2d2tlLzR3UmhjY3RuL3QvcE1S?=
 =?utf-8?B?NzVSVkVSQXptSXUwMitVVXNpOHhnM2xqV085dExoQmZFN0dFYlhLSzFBNTZP?=
 =?utf-8?B?MnZ1YVY5UHkxejVlYTcvT1Y4LzNUVUVlUG5CNFpMNUZNb3U1MXFjREZsbjB6?=
 =?utf-8?B?T09CWDZPVGVrL3F3TDQ3WGovVGRjNmN2VU5NQmxpY3VNWDNwMVNCRlY1bXNY?=
 =?utf-8?B?R2MwTHdpUGNhS1gweGVrUDhqVHh0cXl2ckpKN2RnUis1ZnhmNmpVR05FV3BQ?=
 =?utf-8?B?aHZ6V244cmZYeER4NlVUVko5R2QwK1AzZFhTV0xiREo2dSsvbXViMjVSYjRC?=
 =?utf-8?B?Z1l6RENzeDN4L0dvMnJPbWNqYUQ0cFM3NTdlZ1ViTU1NVnZCT0ZrR3JNUWlk?=
 =?utf-8?B?UXhzVU81aTFhcW5kZWlGc2N6eGthbFd6bnFiVmtVLzJySnZ4cm5WeGlTbEJ3?=
 =?utf-8?B?cTUvUGdkd1JlTitSVEI2b2M4UENNYk4vanVVWG1oZXUzMVEyZGJhek9BS3VS?=
 =?utf-8?B?eENGL3pKTlJMUGtLMFNrbUNxb1NrcmUvaXhVYUF0MGlJSGJIREMrK09sRjYw?=
 =?utf-8?B?dDM3MXZMMlhUNU4wQWFmNlNKa0NWTkVpckw5ZTFvRGJ4d2p2VWw2YkxaQUx1?=
 =?utf-8?B?VjZCcEJydVY0cmV1N21uQktpNm0yMjk0NkcvZlVDMDZmemgyWHNHaHBDL0xi?=
 =?utf-8?B?TG1ITWMyWllUT3ZralZ0UTBHcnhPQnY4aWVyYzhETXVGZG9kelNUTzZVTlJS?=
 =?utf-8?B?NHdNN1o1Uys1QjVrem1TalU4R0oyQlY2Qm9LOFFmSnVCN3FJQ0JRckVqalZR?=
 =?utf-8?B?TnpSd2xQdDY1SjY1bFNrMDcyRVhtejFQbEhld1VyTmZXWEhSRzBuNk1Vcm5Y?=
 =?utf-8?B?NW52d1hlUGczUDYyVGVzYVF6akhCVWNPK0VFaE5MQ2JCSDQ4M3FwMUNiMlZ3?=
 =?utf-8?B?M29sYkxzMm9GempmTGRKcWhGa2Z4TWJkQ0ZZbk9LWVpvUHBUZXNRZWZXMUUx?=
 =?utf-8?B?bmxVQkM1WEVvTzFXVFZkTzNXSHBjeFd6VCtkWUFIaGtBYzQwZGV5bW5sam5o?=
 =?utf-8?B?YVZsYUd3WFVjK3E2RkZBMWtHTVZyMnVBaW1kSjVyNDhhdk1PbHNBdGd1TFpX?=
 =?utf-8?B?UmxpVHp3YUp5Smp5YTlsWWJ2bWdsb1p1WlFTM3FKQURnUG5zeFFTQWlDQWIy?=
 =?utf-8?B?Rkdld21NaFJEN1lqSzBFaGNqUk9oWWZQOTNRNkhMdG42cDMxbTlUUXVhbkd6?=
 =?utf-8?B?a1RaMnBEcU0zWm5JczFEdEIybGtYWERBd2kzYXhUZXY4RENwTnVRU25EM1Iw?=
 =?utf-8?B?K3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6ab7f07c-c4a5-4235-506d-08dbbebbba74
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 18:09:30.0813
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zxma3/Qxy7KUO4BijbtctREjx55CwRNRM3VDqYy+BvMi0CEXiqcNC//5v0GZpH9plaiQJRAG4xZOlam6XmE3KiAcY1yINfcJzBKq6krvQFY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5417
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 26 Sep 2023 11:09:50 -0700 (PDT)

Hi Shuah,

Could you please consider this series for inclusion?

Thank you very much

Reinette

On 9/4/2023 2:53 AM, Ilpo Järvinen wrote:
> The benchmark command handling (-b) in resctrl selftests is overly
> complicated code. This series turns the benchmark command immutable to
> preserve it for all selftests and improves benchmark command related
> error handling.
> 
> This series also ends up removing the strcpy() calls which were pointed
> out earlier.
> 
> v5:
> - Fix another off-by-one error
> - Reorder local var declarations in main() to follow rev. xmas tree
> 
> v4:
> - Correct off-by-one error in -b processing
> - Reordered code in main() to make freeing span_str simpler (in new patch)
> - Use consistent style for const char * const *
> 
> v3:
> - Removed DEFAULT_SPAN_STR for real and the duplicated copy of defines
>   that made to v2 likely due to my incorrect conflict resolutions
> 
> v2:
> - Added argument length check into patch 1/7
> - Updated also -b line in help message.
> - Document -b argument related "algorithm"
> - Use asprintf() to convert defined constant int to string
> - Improved changelog texts
> - Added \n to ksft_exit_fail_msg() call messages.
> - Print DEFAULT_SPAN with %u instead of %zu to avoid need to cast it
> 
> Ilpo Järvinen (8):
>   selftests/resctrl: Ensure the benchmark commands fits to its array
>   selftests/resctrl: Correct benchmark command help
>   selftests/resctrl: Remove bw_report and bm_type from main()
>   selftests/resctrl: Simplify span lifetime
>   selftests/resctrl: Reorder resctrl FS prep code and benchmark_cmd init
>   selftests/resctrl: Make benchmark command const and build it with
>     pointers
>   selftests/resctrl: Remove ben_count variable
>   selftests/resctrl: Cleanup benchmark argument parsing
> 
>  tools/testing/selftests/resctrl/cache.c       |   5 +-
>  tools/testing/selftests/resctrl/cat_test.c    |  13 +--
>  tools/testing/selftests/resctrl/cmt_test.c    |  34 ++++--
>  tools/testing/selftests/resctrl/mba_test.c    |   4 +-
>  tools/testing/selftests/resctrl/mbm_test.c    |   7 +-
>  tools/testing/selftests/resctrl/resctrl.h     |  16 +--
>  .../testing/selftests/resctrl/resctrl_tests.c | 100 ++++++++----------
>  tools/testing/selftests/resctrl/resctrl_val.c |  10 +-
>  8 files changed, 104 insertions(+), 85 deletions(-)
>