Received: by 2002:a05:7412:2a8c:b0:e2:908c:2ebd with SMTP id u12csp2198111rdh; Tue, 26 Sep 2023 16:08:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF0GEw+JJs2XrMXaPb5s6DtilCJVN5Nt+T8g60EL5aI1fKNSJAgBRlkpdg9jo1Gpb/gltpI X-Received: by 2002:a05:6a20:9707:b0:147:d861:50e4 with SMTP id hr7-20020a056a20970700b00147d86150e4mr285099pzc.33.1695769738888; Tue, 26 Sep 2023 16:08:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695769738; cv=none; d=google.com; s=arc-20160816; b=MOYHx2Yryee+v9ewIL5eThY8i5fDMSdrawG27BTv56+z10psIF2Pjfpq2dfVpmJz1N stSlfk751BZ0IXqBewx8Uo8CC4PmnU9t1mxHrPfJnDUjgJLgxWkIFj9eEwaM2OBtS2mw VvKe0i/rSX/xasYqhtbWxZqZg3ot7Flo8p5cJNMv2aSFi4k7kUr2j6R9rkwtXVy08/aI ULCYVfKwHuOwDyVyTv+yf1yzw/cY6kLlcCcmQvLMRIz8HnQ/hT2OWxl21FLPZvu1eGLR 3RcpSKDksn9VB3SLDog83WwOqpNcRjP6JBoA3SbG/8IMflw0kPHHhZUR9XgA+tUqWTy3 8osg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=rVPe3+KdW1jPsi0jBlXBNKMV25TaYQzseuW/GsNuJu0=; fh=btEp9Pd3EXPpsdOLLQkhzBm5xZ9Fx1FjfZPI/YhwgaU=; b=bzpjwCGCEIfQTCm1OxiaZ+hoikQN0yAVxeSoFiCRWO48rTWdhkF9JAwwEGHWMb3TVL P923WDIgcrHZVGZyDMwBQnMUt2BO3CTGw1AnG8RAZm6liOTqeo9RU36XxOca6/kARtdN rdCkJ42P+Q5UYbOtliEYKHt9K/MbN3yldVLch7djN+VBRdCwNgSn0ozLeCzUGwcfqdTv mAaWevwPYIvXIr6A1bZ2Y86H9ogET2HAFS/nvkcLCDF3aU9RVRyahdXPka21TkMFsrH4 5VwlRdLHx9grtRLkrDvyJr7USCfLa62+7VprpfauHdn3yeB2O6xkqayrft3xFylvrLny EnQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DgEn0WGd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id x7-20020a634847000000b0056c297d163csi13630184pgk.530.2023.09.26.16.08.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 16:08:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=DgEn0WGd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 2490580267F0; Tue, 26 Sep 2023 16:08:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230197AbjIZXIz (ORCPT + 99 others); Tue, 26 Sep 2023 19:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230094AbjIZXGz (ORCPT ); Tue, 26 Sep 2023 19:06:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 905FE19A2 for ; Tue, 26 Sep 2023 15:09:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695766146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rVPe3+KdW1jPsi0jBlXBNKMV25TaYQzseuW/GsNuJu0=; b=DgEn0WGdy08M58LjfNcfTjmtV88esitK1DX6QNcTwt224TiGaGQon3pHRlz2hGvPNz+Fet qaeoZpWOPPkwC1A8yC1VTRube5RJNJMRMHkxmu1coxcSImBg/rlN0RRexZW/XJs0cv0Sok /tZPHMvVfxtDu9yIqOr2U+iNRiJK/MA= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-482-WZ032l7-OM-44FQa4KHWDA-1; Tue, 26 Sep 2023 17:53:37 -0400 X-MC-Unique: WZ032l7-OM-44FQa4KHWDA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 96EC53C11A10; Tue, 26 Sep 2023 21:53:36 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.45.224.16]) by smtp.corp.redhat.com (Postfix) with SMTP id 4D3C82156A27; Tue, 26 Sep 2023 21:53:31 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 26 Sep 2023 23:52:40 +0200 (CEST) Date: Tue, 26 Sep 2023 23:52:34 +0200 From: Oleg Nesterov To: Li kunyu Cc: peterz@infradead.org, mcgrof@kernel.org, mathieu.desnoyers@efficios.com, elver@google.com, viro@zeniv.linux.org.uk, dvyukov@google.com, vincent.whitchurch@axis.com, michael.christie@oracle.com, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH] kernel/signal: =?utf-8?Q?Remov?= =?utf-8?B?ZSB1bm5lY2Vzc2FyeSDigJhOVUxM4oCZ?= values from ucounts Message-ID: <20230926215233.GA26968@redhat.com> References: <20230926022410.4280-1-kunyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230926022410.4280-1-kunyu@nfschina.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 26 Sep 2023 16:08:57 -0700 (PDT) On 09/26, Li kunyu wrote: > > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -415,7 +415,7 @@ __sigqueue_alloc(int sig, struct task_struct *t, gfp_t gfp_flags, > int override_rlimit, const unsigned int sigqueue_flags) > { > struct sigqueue *q = NULL; > - struct ucounts *ucounts = NULL; > + struct ucounts *ucounts; > long sigpending; this looks obviously correct, so Acked-by: Oleg Nesterov but you know, this change is so trivial, perhaps you should resend this minor cleanup to kernel-janitors@vger.kernel.org but let me add Andrew, perhaps he will take this patch... Oleg.