Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Message-ID: <f72ba71f-07e1-6e1c-9b8f-0724694a79b8@intel.com>
Date:   Tue, 26 Sep 2023 14:40:13 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v2 4/6] selftests/resctrl: Refactor feature check to use
 resource and feature name
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230915154438.82931-1-ilpo.jarvinen@linux.intel.com>
 <20230915154438.82931-5-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915154438.82931-5-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q092V0ViRHVLVENCb3krTWtuUmtnajQ2WnQxSG9kb0pNTzVYZy9hOGJaNDMw?=
 =?utf-8?B?MGMvS3ZlMk9abkdkZWdqMlVoenYwdFFhTlFtcGVhUXF5UkdJbnBlQ3lMaFhY?=
 =?utf-8?B?d1F5ZFhUVFNpbzI5TFh2RUJsbnNYNi93UWswbkUrQmJSQytkUFRTVDVtRFRU?=
 =?utf-8?B?Ui84STArZ1hMWmkwU21JUnFPeWEzOEl3U01OQ281VGlXM0FJU0poNnBqT1hI?=
 =?utf-8?B?cDVsRzJxRFRwWFBZL1dQRmJxWmdoRCs4WEVMd0xnaU1kV3RIM2txb1NKY0g4?=
 =?utf-8?B?cnRDMDNGQlVORzEvYzNxVUxjWlAySUgvRHg2YlVWOEZETzIyL1lRTW10aUhn?=
 =?utf-8?B?aWthUnhlK3ZadmJ0M0ZzeVpyWWxWSTZqcVg5NWFwOHhsL3daUlNHWmZDM20v?=
 =?utf-8?B?NURsWHU1MGpJN2ZDbzN1dzRVQi9GR3hKY1ZuY1VGSEZuQXFraWY0M2V1ekJ2?=
 =?utf-8?B?ZnVFN3FRNTFDSHVjTm5vMHFWaXZ4K256a0E2RDB0RlhiNHpab25QdW9XMlZt?=
 =?utf-8?B?dnN0Mldyd05ucjZBRSsrUVc1aWRwM1BYekw3bkppeXNNRmFtcnJaZHo3QS9D?=
 =?utf-8?B?Qk82TDkwSThmd3I5K2lFYkRuTVhEK3Qxak9sNFVqbHIrek1JdmFIYzA4SGJB?=
 =?utf-8?B?TVQrNjNzL0dma2p3UXV4aTNLbVk3T0Y1dUhKQnJ0d0RQNVBPR1ExamV2S3Yz?=
 =?utf-8?B?aGRrOE9PR05pRW0wL1JoaVZZRXpWdFJxN1o1dmN6MkJpMno4bElxdFRrYldX?=
 =?utf-8?B?UUZ6czkrc3QzaHFsRUdyKzE5Q3ZXaUVZNTd4dkJESTBXbFF3MW9rUUxURGVE?=
 =?utf-8?B?bkRrWGNmTXRKZ3p4dk1Mb3RFQ2lOQmkxN2RObi9SbHluK3VVMDBmZjNZN3R5?=
 =?utf-8?B?Si9DT001cWVUMW5IT1lPMW5peHY2ak51TmRwQ1djZWk5UlRYWENodXBMdGNh?=
 =?utf-8?B?bzByeVJoeXBDanQrR3VQQVVpRkxOMnAzZndMV1oxbngvQVp0YWFVOE1HQ0VQ?=
 =?utf-8?B?OTJ0V1owT1B6RXBKKy9US0k5K2Rqa2FOSXJKaDJLLzZ4eG0wdnB2Q1B1Y25o?=
 =?utf-8?B?dFhDNXI1a2tBekdGZTVqNGE5Q3kvMytmOFM4ZTNsWTdOZUt1b1Y4MG9ScXRV?=
 =?utf-8?B?c1JHSkUwLzIyQlkrTUdUbUt6d2JSSG93MnhJaXg4ZDRkYUt4dXN5Snovb21L?=
 =?utf-8?B?bXNSZG1laWdxOTBWYTQ0dWJEeG4wNjJIWmFsZE14Z05pVTdhbUdJUjkrbm9u?=
 =?utf-8?B?Vy85cTJ6Y0VqQ3htY2lrT2plMTE1TGFDVTRuOTY4S0JkQ2loWHlvVHRMNmRD?=
 =?utf-8?B?L3VqZVRYTGNsZjkvTmlSK0tXeUlHc0llQUNEZWQ0S2tBMTZmQThNbW95Lytu?=
 =?utf-8?B?Wm84MXh0bUtjMVlKampPWnZER1l1S2RjMG5PN2hMYmNwc1VlNVM5dGFDVDRU?=
 =?utf-8?B?K3pIbm5GaEkxTURJK1pSbUF6QytzUEkwSFFkL2FuYjZsUEZLVW5Gck4rK0Zz?=
 =?utf-8?B?NW5tbzB0VzRtRS82d0svMDQxOHdZellQMzlOUi9nYWowVnRKZExLMitCSkRK?=
 =?utf-8?B?M0duQ2lCOGE2TXAvR1QzbmRxRkNaQ1c3ZFZrTEMvOHNTdUlMVytUMUVEQWkx?=
 =?utf-8?B?Ris1NXR6WTZGbURXWUVCOUEwdWw4QzlOYldyVWw4b2E1aFNyTlVkay8razBn?=
 =?utf-8?B?MStQREV0ZzJpZUduUG5WVnFYWDlVWlQ1cGh4RGdKb2pRcHRaak9QUVVxZDhI?=
 =?utf-8?B?ZkZBTUFKSk1YTlRNRDhNajNDSkkyZ3R3QXBjOElNN3NnRk0wN1R3WUNWMEdN?=
 =?utf-8?B?a3c2aEludU02bFVGZFcxbjhFRjludk1hNEIwbnN4R0Z2YzJnOVVIT2wvOE1q?=
 =?utf-8?B?OHRvb3F1RitnNHZBbjJUMlhWKzBYZXp0WVphUEsyTTE1WlZOSHMyNDdEUE9I?=
 =?utf-8?B?NkNnYXN1ZVExZk5EeFhtZW5mYjFKTGhtYXEyTmgwUnljV0xBK2tYVWlwNXdR?=
 =?utf-8?B?MC9uNjJDS1FrdVRGbVV0Mm05SytHUGE0OVkwVEhvSWVxc0gva2U0bUF3bjRC?=
 =?utf-8?B?eTRGZktGUm1uNzNBcndXNEtWWTIwQzFtQm9VREE1VmQvMFdMRjBoZ0NYL1VP?=
 =?utf-8?B?Q3JkTXloMmxibWt4R3NVd3dKcEUzOVMycEtiWjIrWjg4Rzg4RW9GdFN3WlVz?=
 =?utf-8?B?M1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 445d03c7-8e2a-4c62-35dc-08dbbed92c0c
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 21:40:16.0743
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /NK76YHR0tMxLrzG/mmvUldU3w9MzNhQ4XeLmvZ0W2ZjM0qXhUATKXtDKo8kz+tuWubeS6Pi6VE1A7KyHGjfbq9OpJb9MNTxyxDZtNp6RwA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8424
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 26 Sep 2023 16:42:50 -0700 (PDT)

Hi Ilpo,

On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> Feature check in validate_resctrl_feature_request() takes in the test
> name string and maps that to what to check per test.
> 
> Pass resource and feature names to validate_resctrl_feature_request()
> directly rather than deriving them from the test name inside the
> function which makes the feature check easier to extend for new test
> cases.
> 
> Use !! in the return statement to make the boolean conversion more
> obvious even if it is not strictly necessary from correctness point of
> view (to avoid it looking like the function is returning a freed
> pointer).
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org> # selftests/resctrl: Remove duplicate feature check from CMT test
> Cc: <stable@vger.kernel.org> # selftests/resctrl: Move _GNU_SOURCE define into Makefile

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette