Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <94004987-3cab-9fde-a231-7c63ac88a866@intel.com>
Date:   Mon, 25 Sep 2023 14:17:37 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.13.0
Subject: Re: [PATCH v4 01/17] iommu: Add hwpt_type with user_data for
 domain_alloc_user op
To:     Robin Murphy <robin.murphy@arm.com>,
        Jason Gunthorpe <jgg@nvidia.com>,
        Baolu Lu <baolu.lu@linux.intel.com>
CC:     <joro@8bytes.org>, <alex.williamson@redhat.com>,
        <kevin.tian@intel.com>, <cohuck@redhat.com>,
        <eric.auger@redhat.com>, <nicolinc@nvidia.com>,
        <kvm@vger.kernel.org>, <mjrosato@linux.ibm.com>,
        <chao.p.peng@linux.intel.com>, <yi.y.sun@linux.intel.com>,
        <peterx@redhat.com>, <jasowang@redhat.com>,
        <shameerali.kolothum.thodi@huawei.com>, <lulu@redhat.com>,
        <suravee.suthikulpanit@amd.com>, <iommu@lists.linux.dev>,
        <linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
        <zhenzhong.duan@intel.com>, <joao.m.martins@oracle.com>
References: <20230921075138.124099-1-yi.l.liu@intel.com>
 <20230921075138.124099-2-yi.l.liu@intel.com>
 <0d37a1b1-e7ef-fa73-d17c-629cd254ae75@linux.intel.com>
 <20230921164447.GQ13733@nvidia.com>
 <dcde6757-8d14-6460-c75e-c30d69219e4b@arm.com>
Content-Language: en-US
From:   Yi Liu <yi.l.liu@intel.com>
In-Reply-To: <dcde6757-8d14-6460-c75e-c30d69219e4b@arm.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWJRbWdXalBUbU12VkhOL3dtUlNwdjFseFBmb1FCN2RGVXBScEo4amZ5Q3NM?=
 =?utf-8?B?ODJWdWJOL3NYd1ByMlg1RWJFSU5xVzhYdkVJbmwwZlJKREJ6VmlKYmNycnVZ?=
 =?utf-8?B?NUpPMDBIWnJZM1pLT29hVjZWczhVM0JIT3h0TWhnZHVIWFZuOVZSWFdDMDlG?=
 =?utf-8?B?Q0JqNFZiL1ZjM0pNUVI0TmZmd2hzMVo1TEJwdlkxM2Zwd3llTEw3SnozZ0JO?=
 =?utf-8?B?ZUZpUC85OW5SSmcxVHJBZWtiblo1N3E2dE9xQVRhWEhMc0lSeE9KdEF2K0RS?=
 =?utf-8?B?V2tqTGhRMjRrRVVQTXlyMWlsQnRtNFYwRGlpeTljTVlGQjN2MjZXSnRzYmp2?=
 =?utf-8?B?aVE5TTZrRktLeWhjUWhPbHo4QThJK01OQllWTk9mUk9meGcyMHozSzZlMTJ2?=
 =?utf-8?B?Vk5mdWY5b1lTM0pZOWF1MEpsQ2kzVzhlYW4yMFlXNUFqbXlWRysyT1RMZGwv?=
 =?utf-8?B?Z29tcFhMRGw0akdJbUpiZWtYL01VUUs0VlF1cGtJdStuRm1QYmNjcUlqYVJG?=
 =?utf-8?B?MXRlWDhuZmdwdGdWeWFMME9uZlg1VUtZNllCWEN3NU1XL2dzRUkzZi9DaVdV?=
 =?utf-8?B?aFB6cUpJanJBZjdXSERiUlE4VlF4K21CaWFiMFJaVmFXYndHd0NJZGJKME5u?=
 =?utf-8?B?djVwSFE1NkwyUzJ2ZnhuYlR6amhQNTFnUEZJaUFKU0JCeFpNMGNVUEsvQldM?=
 =?utf-8?B?cGx6T3VhRFlwY1NQcGlDclhJVTVwZU5HVEVnMFhlY2F3N3lYNW5UUGVtRU9M?=
 =?utf-8?B?ZFprMXpMY2JCL1ZtRmFEN1lGRTZidndSSjhOczRpa1Nib1pYaFhHalRrWVRu?=
 =?utf-8?B?d3RSaU1jNmc1cEhqbGVtTExob0JKOUxFYlB4OUZpZHNXTHZZd1hQKzRaNEo1?=
 =?utf-8?B?WUNCM01RdjBzQ1RCL2cxVHpNQnpGMitVUjFBRHNwbXNnQ2xEWjJOY1ZReU04?=
 =?utf-8?B?VjZOZk1KT1pzYUYrTjd2cTU4R0ZWdU8rSzcvMXlLakJBSTJWUURWOGhWaTZp?=
 =?utf-8?B?b01IM0JweTZ6UDY4NUNpTHJ6RHM4QzVReG5YTDQ2NXplTkhZcmxYZ2JlbXQy?=
 =?utf-8?B?bzNrMFB0VVdibFhkQ0hoL2d6VHlTMUNtbHpscDlnM2c1b3hjd2pkaDIya2F3?=
 =?utf-8?B?b0x0Q3JmN3Nkd1phMllDUXpVWXVMenRrTjZnNktIdTErWlRDY0w2YWtQWS9s?=
 =?utf-8?B?MzlxdHVzR3FqeitoUDVsVVgvUlBCWjJjQnpZSHFWcGF5ZGozaTJsS0MySVd2?=
 =?utf-8?B?cUwzbnc1c0xhbkZiSVcvbnB3SW92MGxqQmhYMGNFMjYyZHM2Rk5UZk5oN3hD?=
 =?utf-8?B?dStubjJZM3VlYzc0aTl1dGdLNzIzK0kvQnR1Nk56RHQzZVN4S1JYVGdEZHFE?=
 =?utf-8?B?d1NhWGVxU3NvUms3SlNkb0hMWVZxUmthNnF1YjVNenN6OGRTa1NCWnJ3dk0r?=
 =?utf-8?B?STZuRTBIcHB4KzRDSmRubmxSb29VTWR6L25FOEJLVFE4S1hmSHh3UlBwb3Bl?=
 =?utf-8?B?a3ArcHY1SFlhWStGNDNic2c2Ym02NGorSWRZRlF5eVE3MDZ5Y1ZSNlA0S3Mw?=
 =?utf-8?B?Y2VBUkpSM3pwNVpXMVJLR2FoUXZvb0FFVThicExlRjRQMXArUnlLUHRpRWdr?=
 =?utf-8?B?MDIzN0ZrWXpxcDVxeHdIOUVYSFJLWGF1S3JsYlFyeEhiQW9wa09pSVY5cVoz?=
 =?utf-8?B?cGtHTklOUmFDY1hET3EwUzMwdVhaTytmZ1BuQlhUMVJOUVI0VU9rdUVqdThJ?=
 =?utf-8?B?aGtxV2lFUkpYVjFzZ3drUTdCSE16dXdrN1dRT0ZzRE1mWjREdlN1ZWg4YUpi?=
 =?utf-8?B?alZudkdGUmxPb2dBWnRrMHllTk96WHN5c3d5Zk9rTXlRcFh3eTljUGl5eEls?=
 =?utf-8?B?R2JBaEc3NWhoc015ZmlLTjl5cUFjR1VKb0JVZTlrZjJXbFdIeEV4QmVXbE85?=
 =?utf-8?B?KzVpYnUvNHg2LzlucC8zSHRuK0RhVHFZY040VHp2cFRpWGpwVWpjck5uQnBE?=
 =?utf-8?B?VWg5V1BKSGZkSzcyZXhkTWZZVUUyWjBnN3ZBVmRZMEpwZVp5Qmx4dUJjdXB6?=
 =?utf-8?B?MEZCRWdxSlNFNi9SRW9vYmdkR2VyaG1vRUJtcjRJb1B4ekJSdDNudWlyWDJo?=
 =?utf-8?Q?FK3FYVr2IJqMA6QzyErJDJ8zu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6262718a-fb85-4c31-2c14-08dbbd8ecd12
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7529.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Sep 2023 06:15:22.9984
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: e8YXp5cpcNTyje9SKd/MAC5lQ7RCu7E993I3E8bHIGHhHQX17YVIzv+j+er46EiNDsaHzg1V5tOmBpdb5NXlzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8441
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Sun, 24 Sep 2023 23:16:01 -0700 (PDT)

On 2023/9/22 17:47, Robin Murphy wrote:
> On 2023-09-21 17:44, Jason Gunthorpe wrote:
>> On Thu, Sep 21, 2023 at 08:12:03PM +0800, Baolu Lu wrote:
>>> On 2023/9/21 15:51, Yi Liu wrote:
>>>> diff --git a/include/uapi/linux/iommufd.h b/include/uapi/linux/iommufd.h
>>>> index 4a7c5c8fdbb4..3c8660fe9bb1 100644
>>>> --- a/include/uapi/linux/iommufd.h
>>>> +++ b/include/uapi/linux/iommufd.h
>>>> @@ -357,6 +357,14 @@ enum iommufd_hwpt_alloc_flags {
>>>>        IOMMU_HWPT_ALLOC_NEST_PARENT = 1 << 0,
>>>>    };
>>>> +/**
>>>> + * enum iommu_hwpt_type - IOMMU HWPT Type
>>>> + * @IOMMU_HWPT_TYPE_DEFAULT: default
>>>
>>> How about s/default/vendor agnostic/ ?
>>
>> Please don't use the word vendor :)
>>
>> IOMMU_HWPT_TYPE_GENERIC perhaps if we don't like default
> 
> Ah yes, a default domain type, not to be confused with any default domain 
> type, including the default default domain type. Just in case anyone had 
> forgotten how gleefully fun this is :D
> 
> I particularly like the bit where we end up with this construct later:
> 
>      switch (hwpt_type) {
>      case IOMMU_HWPT_TYPE_DEFAULT:
>          /* allocate a domain */
>      default:
>          /* allocate a different domain */
>      }
> 
> But of course neither case allocates a *default* domain, because it's quite 
> obviously the wrong place to be doing that.
> 
> I could go on enjoying myself, but basically yeah, "default" can't be a 
> type in itself (at best it would be a meta-type which could be requested, 
> such that it resolves to some real type to actually allocate), so a good 
> name should reflect what the type functionally *means* to the user. IIUC 
> the important distinction is that it's an abstract kernel-owned pagetable 
> for the user to indirectly control via the API, rather than one it owns and 
> writes directly (and thus has to be in a specific agreed format).

yes. It is just what the existing domain_alloc_user op does. Here we add
a hwpt_type as the type can be given by user, so we need to define a 
specific type for it.

Perhaps we can also name it as IOMMU_HWPT_TYPE_UNMANAGED to be aligned with
the domain type naming. IOMMU_HWPT_TYPE_GENERIC is also a good choice.
Please feel free let me know your preference.

-- 
Regards,
Yi Liu