Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230925-strncpy-drivers-md-md-c-v1-1-2b0093b89c2b@google.com> <202309251122.6E3E678140@keescook>
In-Reply-To: <202309251122.6E3E678140@keescook>
From:   Song Liu <song@kernel.org>
Date:   Tue, 26 Sep 2023 16:17:05 -0700
Message-ID: <CAPhsuW6MGr=ZA1yoHSH3YdG4Z5x5+qcJt8cMoNqG2cb7EqJYcg@mail.gmail.com>
Subject: Re: [PATCH] md: replace deprecated strncpy with memcpy
To:     Kees Cook <keescook@chromium.org>
Cc:     Justin Stitt <justinstitt@google.com>, linux-raid@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Sep 25, 2023 at 11:22=E2=80=AFAM Kees Cook <keescook@chromium.org> =
wrote:
>
[...]
> >
> > So really, all these instances have precisely calculated lengths and
> > purposeful NUL-termination so we can just use memcpy to remove ambiguit=
y
> > surrounding strncpy.
> >
> > Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#st=
rncpy-on-nul-terminated-strings [1]
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: linux-hardening@vger.kernel.org
> > Signed-off-by: Justin Stitt <justinstitt@google.com>
>
> I agree on the analysis of the replacements. Thanks for all the detail!
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Applied to md-next.  Thanks!

Song