Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1;
Message-ID: <81278084-e048-1dcb-872d-ebf7becb0f58@intel.com>
Date:   Tue, 26 Sep 2023 14:39:30 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v2 2/6] selftests/resctrl: Remove duplicate feature check
 from CMT test
Content-Language: en-US
To:     =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= <ilpo.jarvinen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        Shuah Khan <skhan@linuxfoundation.org>,
        <linux-kselftest@vger.kernel.org>,
        =?UTF-8?Q?Maciej_Wiecz=c3=b3r-Retman?= 
        <maciej.wieczor-retman@intel.com>
CC:     LKML <linux-kernel@vger.kernel.org>,
        Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>,
        <stable@vger.kernel.org>
References: <20230915154438.82931-1-ilpo.jarvinen@linux.intel.com>
 <20230915154438.82931-3-ilpo.jarvinen@linux.intel.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20230915154438.82931-3-ilpo.jarvinen@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Sm5PT3ltaFhXZmJXVEc1d3hZUlpCWVBnbEZ4eEl5cTNDYlAxOGE4OVpJSTA3?=
 =?utf-8?B?VjZlNjZhclFrd2E2ZjVkQmpIQXJhTTdLTTVRMEhRWEVxVktQcGxWbzhJVHVR?=
 =?utf-8?B?UTJCV2pIMFBJUTl0STRhWXc0QjEyZm9YWjdzM0IxZXhyeVBPSEV6d1grclo3?=
 =?utf-8?B?RDhJc0RjOHpqTmFHZy9BaTYydmhPd3BZS1Y4akNrdHRzVnY1dUIvaVNhMzF1?=
 =?utf-8?B?UXA0NXJRNzNBb0l4N1VQV3RSREJZR29UREYxNWN3UmFrdmlvd2svbTkrc3Yv?=
 =?utf-8?B?QzF2SG9HaGErQnM5V0cyWkNlUFM5SzJqOWJMTmdQT0ZObEZ1aFprY1c0cEtD?=
 =?utf-8?B?SlM2UndSOXdoTWZHaTl5TW9Ta3NyTjVvdDFtUVlmU0RES3RKenhxcmVNTUx6?=
 =?utf-8?B?anVtaURCUTY3NE9MWFFqWnRINU4vRUk4MXZPVFV1cGNHMitTRWJ4U1JvQi8z?=
 =?utf-8?B?WVFvb3hTZS9UVEYrRnpMdGVJQWFYUFk1MkNra09PYVdYNnNHa251VlQyQWxq?=
 =?utf-8?B?Nk5ML2Z4UGlLM29POE9IT2k3VDdXYitBQWdndWdKRURJNkJTVnJ1ZjB0MEZr?=
 =?utf-8?B?WU1hanIxb3orcVpJNFpaSjdtdVhOL0RscFZFRGorKzlvbWtWaDZUT2pKS0Np?=
 =?utf-8?B?ajB1dTIyU3kxdFluWWJnUmlJTEdsdUlSNzU3Y24rdUl0cS9jNWo3VUd6Ky9U?=
 =?utf-8?B?aHlsT2xqMkcvbFlOeHZRQjBHOUVrbGVmQ1ZWYU9namhHalhDRlB1TnlDR3VR?=
 =?utf-8?B?em1PVzB0NFJmdGYvY3NqMUU0b0lIcmxFZTVBUlZTOHFKQnBLY01kcW1PcUZZ?=
 =?utf-8?B?bmQzMjdud051RFBUVC9lYnl4UldqQlpJbUtuOVNmd1FreUhYbTJxMml6UVVS?=
 =?utf-8?B?Uk5GcHNsZnF5Vm1XTUpiMXFwdFpaZUZNbHhSYkxPaUZpQUdCTVREUEUzQ1BQ?=
 =?utf-8?B?ZDFzYjdWVnc2NXBLK3U0NGhVQkc4S0pMZ21zdEt5UmRLWFhtbUJBbEgzYmdw?=
 =?utf-8?B?cGV0ODk0c1I5eGtMaG0yWmt6UFJyd29uSXB3dmhjUzRvM250Z1VCc3JMRzU1?=
 =?utf-8?B?ekd2SkVQYkRsUHc0OE9GMlJEZVZlamdUbXRJSFlTWkJGL3FOdFh4K3A0djZL?=
 =?utf-8?B?SlF3ejh6YXo3R1Q2R0NwdGpydjZlUFBFWjh6RW1odU0yY1RlSHd0eGh4Nkw0?=
 =?utf-8?B?NjVlYVFoV1lSR3NHdU9UZzRTV1JtYkx0TENsRHhJcUpJSENNZnZBY1BFTzdQ?=
 =?utf-8?B?a0NIdE9QR0MreXJlWXNVSVdNVWNMcTh5SW5PQmkxWnJWNXVQOSsrOEZNRTAx?=
 =?utf-8?B?YTk5b1NZMFhMN3hTODhNYkdtbllueGdQQ3F1U0NwazVRMDVrNy9NL05MS0VZ?=
 =?utf-8?B?TzJHL0ltWkpMZUdaL2JscU4vTjJTM1VHeGd0RGZhVVNFKzQwQlJSWjg4TCty?=
 =?utf-8?B?emNqbU0rYU4zOHU0ejFvbzNRbzZzZEJmcGZlZmZ5Q0xaQUl3aHBPV3YvVmg3?=
 =?utf-8?B?UGREZ0dvcXkrdHVNSTRIa0ZiVjB4RTZFOEhUcHIrODlXM0F5dEZ5dXNIWksw?=
 =?utf-8?B?QnJDVWpYOGl3NU5aZ1JHWGNVd1NYTVhFOGtFOWdVcHhIMnM0M1dKV2lyV1Zj?=
 =?utf-8?B?MllGZGJVM051ZTNMQ2lEdlNMcGVIS2srYU4vZmE0cjZRc3dRWUtIM29aRSsr?=
 =?utf-8?B?dTdmVnRldjBwY1g0cTBYNVllMGVWL2FoTDRrTW1GMmR1S05ZWVhYNWFzV05C?=
 =?utf-8?B?QUNBZm9MdlBEVURXZ0x0dmxkTkMvT2U5djlYdk5lRE82RGRYb05LQXIwVlZa?=
 =?utf-8?B?TFA1TCtJQVZKNEtKOTNqRGZ0NWRnaklMRFp4UDUyWFkyNG9zdmJyWkMzK29B?=
 =?utf-8?B?ekRSd0FRUTBGVWRubjlDb3ZadzVEVVJTT3lJWUppemprMTRleC9JMXBCdDd3?=
 =?utf-8?B?T2RNVERUZVU0c21SelFLbEZpZXdvYStqOUYrTW50VFB6UXJCa2tqekE5Y2tK?=
 =?utf-8?B?dkNyMGxHelorQUlLdjBHTFVvNkNYWithQy95dkRqQUU3MmF6OTA2cG9IVW1s?=
 =?utf-8?B?MXRsTTZGTXZsUGUyYUJFSkI0RnBrOFlFUUI0OVdwQ1g0RGluNXNIZ0hZelRz?=
 =?utf-8?B?ZE5UUGZBblNSWnBWSUtOUWZ5Ti9IVXN4VnVEVTZsZUx4Mm8rQXlscXpMTWNn?=
 =?utf-8?B?T0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cb6d04a-737d-477a-e169-08dbbed9123e
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 21:39:32.7777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IH5BYiLxdjEP1MGtt7prohyJo27zIpAdrF24eYS9FoOrx9M0KNNgqbJ86jHpz4WEnQUAPIr/LItdtjZriJUta/whFXg7beKwGK10OFLeLH0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5131
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 26 Sep 2023 17:56:10 -0700 (PDT)

Hi Ilpo,

On 9/15/2023 8:44 AM, Ilpo Järvinen wrote:
> The test runner run_cmt_test() in resctrl_tests.c checks for CMT
> feature and does not run cmt_resctrl_val() if CMT is not supported.
> Then cmt_resctrl_val() also check is CMT is supported.
> 
> Remove the duplicated feature check for CMT from cmt_resctrl_val().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Cc: <stable@vger.kernel.org>

Thank you.

Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette