Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Date:   Tue, 26 Sep 2023 14:58:24 -0700 (PDT)
From:   Hugh Dickins <hughd@google.com>
To:     Matthew Wilcox <willy@infradead.org>
cc:     Hugh Dickins <hughd@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andi Kleen <ak@linux.intel.com>,
        Christoph Lameter <cl@linux.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        David Hildenbrand <david@redhat.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Yang Shi <shy828301@gmail.com>,
        Sidhartha Kumar <sidhartha.kumar@oracle.com>,
        Vishal Moola <vishal.moola@gmail.com>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tejun Heo <tj@kernel.org>,
        Mel Gorman <mgorman@techsingularity.net>,
        Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH 09/12] mm: add page_rmappable_folio() wrapper
In-Reply-To: <ZRIQjZOZJ2ZFkY8C@casper.infradead.org>
Message-ID: <8bfe25ca-def2-f33d-fdba-8ce5fbb5efd0@google.com>
References: <2d872cef-7787-a7ca-10e-9d45a64c80b4@google.com> <f4dc7bb6-be3a-c1b-c30-37c4e0c16e4d@google.com> <ZRIQjZOZJ2ZFkY8C@casper.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 25 Sep 2023, Matthew Wilcox wrote:
> On Mon, Sep 25, 2023 at 01:32:02AM -0700, Hugh Dickins wrote:
> >  {
> >  	struct page *page = __alloc_pages(gfp | __GFP_COMP, order,
> > -			preferred_nid, nodemask);
> > +					  preferred_nid, nodemask);
> 
> I really prefer not to do this "align arguments with opening bracket"
> style.  As long as they're indented enough to make them visually distinct
> from indentation-for-if-blocks, I find it annoying when functions get
> renamed to something with a different length and somebody then wastes
> time reindenting all the arguments to match.

Okay, I don't care much about inserting spaces to align with the bracket,
but didn't like those continuation args leftward of function name above.
I'll adjust in v2, and eventually we reach a compromise.

> 
> > +	return page_rmappable_folio(page);
> 
> I don't particularly object to the main thrust of this patch.  I'm not
> sure I like it in huge_mm.h though.  Maybe in mm/internal.h?  I
> wouldn't want anyone outside mm/ calling it.

I was expecting more resistance :)  Right, I put it in huge_mm.h to be
next to your folio_prep_large_rmappable() declaration, but it doesn't
have to be there.  Ooh, there's a folio_undo_large_rmappable() in
mm/internal.h, I'll move page_rmappable_folio() next to that.

Hugh