Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Message-ID: <11bebd5e-8183-d7a7-6acc-53b00a6cc2d5@oracle.com>
Date:   Tue, 26 Sep 2023 16:53:37 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.10.0
Subject: Re: [PATCH v3] Crash: add lock to serialize crash hotplug handling
Content-Language: en-US
To:     Andrew Morton <akpm@linux-foundation.org>,
        Baoquan He <bhe@redhat.com>
Cc:     linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        vschneid@redhat.com, sourabhjain@linux.ibm.com
References: <20230926120905.392903-1-bhe@redhat.com>
 <20230926135001.4eb6ca73b1a4aa6224355ad1@linux-foundation.org>
From:   Eric DeVolder <eric.devolder@oracle.com>
In-Reply-To: <20230926135001.4eb6ca73b1a4aa6224355ad1@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZVZoRzNia0JLNm9NdU1KZjhiTmFpbXByTW9wa3h4c0hVdXQxb253RkZodkhy?=
 =?utf-8?B?S0E5UE55OGMxdDNVYXlhQTVGNnI1TVF4SG9NbGJkb1pTeW5ub1JYVjhTMk9F?=
 =?utf-8?B?RDB0RGw3bVh6T2JmSVlBTUF3YlBSS29JMFdWMFRnWWhNWm41bEtQQTN1MitF?=
 =?utf-8?B?MkZlOHhJa2dEdnZDM1pPa0l1Wld0dnRmTERzR3o1R2V2NGNTeFhrTlo1dVFP?=
 =?utf-8?B?QWhabVM3cjY4ckFNbDUvVkV4TzFpdFljVW9YMTJsZTlKRk9VdENiNFRvVWgz?=
 =?utf-8?B?dWVpVDdtc2JEQVF0aXhacUdsdjVWdmVVL2tnbE02dGlESUVkN0ZsVzl3RXRW?=
 =?utf-8?B?N3I0bG5PUktCOUtJOE8xMGZic3JxNzU0UHNDYjdUNjk4T09xSTBNSDFYTnFE?=
 =?utf-8?B?TW5uT2V3NzhSRk5QTko0WlFsYzVpdDA0UzJxSW5HWlRKb0lySE9zUm5IOGRo?=
 =?utf-8?B?b3k2ZVYvbHVJZzArMURjZUhSMlJvNmFWL2wwVmVNRnRyK2JiSno2K1RWaStW?=
 =?utf-8?B?VjF0c3A3ekFBMExsbm1IL3p6dnBsVEw0OTNza0NHcVR0ZDI5RTlhdzlIc3ZR?=
 =?utf-8?B?V1Q4VU55cHZzdVRydkgxbjJ1U29ZOVd0SDJtV3N5UFFvalBQM0hsMi91enJE?=
 =?utf-8?B?UWVZK3Q2cVdCd0EzT0gvenAyOFNUbHYreTFOUFhyY3REaHBIN1RORzA2Q0o2?=
 =?utf-8?B?LzdRbGdIa1BINFlLYmVTVGhDT0c2ZUlkMkJvVEhCZXozNEZCOXBzdnhqQVlV?=
 =?utf-8?B?SlZ5MkgwV0w2cm9nVXdzbVBodkxhUkRaN3Q5VE5rSTZFQ3k0UVdIQnUwcThv?=
 =?utf-8?B?QS96eFp0ZmgwYURzMFBxd0F1NGpkN3E4MzRZOU1XOXNIQjF3OVR0UG8zMGlq?=
 =?utf-8?B?eGlpbmYxbThTdzQ0Qnpvd2l2S3Q2ZGtrV2dFRU44aFQ4aUJKRk5ZYkFMQmFp?=
 =?utf-8?B?SDAvSVkxNC9nRjN4YWl5NDZXT2FZMGh3VzlTNFQ3VVc4R3ExTnRORWNjVDEr?=
 =?utf-8?B?NHBPZVBaZk5lZHFSR3dlSUZDVGYzbERLL0YzSWhJWDJOblVmbDlNUjh6ajQ0?=
 =?utf-8?B?ZXBMNDA3NjlxbEFnK3BxYUxTQWRkeDRWWWtlc1NrdlYyTzVTaWJiYzFDS0Zl?=
 =?utf-8?B?OEF1QnFZVXlsOTB4RittN1FoT3RvNnJHbFlMVkszUE50Q0RGS0x4ZEIyTExo?=
 =?utf-8?B?c3RmRFZidmNNMkxQZ1Zoc1dhdTIyM2twbHBFZ2U0aWFPWUcrWDZENzhhMjg5?=
 =?utf-8?B?YkxKd3hsc1pWWWdOaWp0amQzd2VNQnlVMUhlWllwQ0ViSXV1bTZnOGV5SnE2?=
 =?utf-8?B?SUlBOVNWL3hvZGszYjJuTkJsQ0JSQUFONGF3bDl5THh3Y3NLY0R6OU9HNkI3?=
 =?utf-8?B?aGNzNGdBYVQvY3NtVHVwS2VzWTQxTGZXM3FIU2FmNS8yK0RUbW81NXZyREtj?=
 =?utf-8?B?S2JsT3dmVXM5U1NubzRMMnJiRmdyU2o1QTdvdWI0OFowOGgyays3REFZVHBs?=
 =?utf-8?B?Mkx6Y0h2dUdtRDNBY3k1NUJxa1ptMHkxZzMwRWI2VWcyQnAyNkU1bHdYODM2?=
 =?utf-8?B?bm8wK29Rem9xeWxySUdUTDd0aVhtdkJ3d05nRHJ2VkNpTlQrYldZMDN0TWNL?=
 =?utf-8?B?Q1A4a25CWGlUYmxyZGhOREhEa05JNDhjaXhPclZiVlhQekRtamY5MlV2cEpI?=
 =?utf-8?B?c2ZLeC80eDFIQzZscEE5SDVkdmVpZUZjT2VHVnJaaSt6c041NEJWSFJhZTh6?=
 =?utf-8?B?VGJjNTFxVG1hblJwaml6cVZaZUZva0J2Zm9renBDN1pSbDF3Y1pUZXkvL3E2?=
 =?utf-8?B?aXl4cjl0WEkwN2M5WkY1NmFER1lRWFhBRkJOWDRyaFNsUDRIdVBUOGpJQXBz?=
 =?utf-8?B?U3RPZDRVT2F3djlieUp1QWowb1A4ak0zcXIzczhrUy96cEVSeE9YZk95amVE?=
 =?utf-8?B?UUxwajNHckszSFJ4b2hQY3JLV2RjMHA0SEo5cmE2Ly9nakNtclhGVnZEdGtY?=
 =?utf-8?B?Qkh0dDQ4VVFNMWlPNkZDZmMvRXZ0OGhQb1Q0ZFRKRWJPVFo1VHlMWGxZcTBJ?=
 =?utf-8?B?N3EzNWNyV2VtSUM3Y1VOVlhyRVRxSGFRU2R4Ym5MS2swUlVpekFvaGlRMWdt?=
 =?utf-8?B?anZvK0xkM2p1c0dBN3hGckl1SEcrTEZLb3pyekwvRFRjOWVPK2JRcktaYWZa?=
 =?utf-8?B?S1E9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?UXgzaWVkNU5nUGhXOCtzMDVEQVJnbVdlWHAweVZOK3pEV0poTjE2cHNvdDE1?=
 =?utf-8?B?OStuNExaeWQrMmsxVHV6amQwVDZoSjFINUR2YXgrWlB4ODNpWmtrYkJ1dlB6?=
 =?utf-8?B?WTBINlhwdGtVZXBHNHVKTDhhc21JSWNhc2djc1BOcTBIaWNPa0FFNTJLeTZl?=
 =?utf-8?B?T25ETDNGTWJtMW5rQU83c2hYckJ3M3RYZHpzZnZ6YkZwSElVeWs2dWx3N0Vx?=
 =?utf-8?B?NnM3VXJqeFhXQWpEQXNPenpHMGpXckw5SlZoeTZTVlZWSTROOUxOd0czeFNx?=
 =?utf-8?B?VHFkd2U4b1FZQzJackhZeGs2MzBaWDFEa2tLVllORHBQU01uZGFaTU93TXJ6?=
 =?utf-8?B?bGpIeVlVd0VZRy8zYVVYUVdYOCtGUUtoanppMzUrb0Q0anl4cUVkbmdnNU1k?=
 =?utf-8?B?T3ZsNWtrY2JCR3FkTmlCNWo0K1RGZkhCVUZ5VkkvNzAwVUFBUlBqc21VbGJR?=
 =?utf-8?B?U1JQV2NibndYZndvNmhzb2hjbW1nd1l4WWU3NzVva0lSRFV0N0g3OS9xeWM5?=
 =?utf-8?B?RmRQaXIyRzBYazVzVHZSWlA1SGFGMUVWbjEveStMMjQxemRGejB5aVFzYit5?=
 =?utf-8?B?SE5PdDFxMTFFUU5kcmNuQkh5Z0Jaak9pQnVlWG5TRFNCdU5zM2dIbDhMY25S?=
 =?utf-8?B?VHAwaEtkRGMxeXV4UGZMNG1JQlhVMFNZQmJlQW5ZN3VibWpXOFJJWkZNSHhD?=
 =?utf-8?B?QkVqMWZOZC9EZTd3WFJLQXpBL0RwMEtEQW43clo0TFBDK2h1Wi9KMVM1Ulh2?=
 =?utf-8?B?bm1DYjM1eE9Uc29lSTlLQit2OE4wa3l6R2VjMGxoTHJEdTZvVzlTR2gvYWtT?=
 =?utf-8?B?WUdXakp6dHd1YUJNZWxwNEoranR1dXhGemdLSEpSak5CbWgzNk5FajNNTWdH?=
 =?utf-8?B?aUJsUVMzWlBYUzVieDQ2b2pGOTIrZTYzaFZvaHVPVUhubVJDS3UwaGhUWmZ3?=
 =?utf-8?B?aXk4Q3F3L1h3aTJyQ1hxemltbmQyeDdYbWRrVERSRUswb2F3cFNuUkVnZ3E2?=
 =?utf-8?B?Tml1YkZFdks0Y1c4eE1TWGMvb0EvMVNKY1NkQXlmaWxRanJTem9mcWVPWUJn?=
 =?utf-8?B?cGd4SExLYnlTQmwvenNOaHhpM09WTzMvUjhnYkc2cEVaV1hCNFcvM2s1ejFC?=
 =?utf-8?B?RTJFMzdxNmlRSDFiWVBBTkVnMTIzK2NQK2VlL05MVEEra2pMbjE4NjdWME9r?=
 =?utf-8?B?Z1cxT1RoZHNJd3pSSHNZdnFEWm5HcmViTHJzSitOZWoyME52cWZyOFRYQ2sy?=
 =?utf-8?Q?Vh+/sWxArFoQKZ3?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8766de10-dcc9-46c2-83d4-08dbbedb0bcf
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4531.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 21:53:41.4189
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ycaRNP/5agAqDySsZ5HSVnjWeWt5V0ktw46+cxX5qv/DGlD0657gqLLXyyJhowSYKRDdalTVsqJeiB2ALXZn7q47XQrja7z7hRqaTTNsnyU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4419
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-09-26_15,2023-09-26_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=999 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2309260188
X-Proofpoint-GUID: kfvIc9ej-6FuAyD635VmBslXfGshArW5
X-Proofpoint-ORIG-GUID: kfvIc9ej-6FuAyD635VmBslXfGshArW5
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 26 Sep 2023 17:16:56 -0700 (PDT)


On 9/26/23 15:50, Andrew Morton wrote:
> On Tue, 26 Sep 2023 20:09:05 +0800 Baoquan He <bhe@redhat.com> wrote:
> 
>> Eric reported that handling corresponding crash hotplug event can be
>> failed easily when many memory hotplug event are notified in a short
>> period. They failed because failing to take __kexec_lock.
> 
> I'm assuming that this failure is sufficiently likely so as to  justify a -stable
> backport of the fix.   Please let me know if this is incorrect.

Andrew,
Correct, this is sufficiently likely to happen.
Thanks,
eric