Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <5b2fd31e-3cef-3c35-7d17-411cea27502a@intel.com>
Date:   Tue, 26 Sep 2023 15:00:39 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.15.1
Subject: Re: [PATCH v5 3/8] x86/resctrl: Split the rdt_domain structure
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>
CC:     Fenghua Yu <fenghua.yu@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, <x86@kernel.org>,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Babu Moger <babu.moger@amd.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        <patches@lists.linux.dev>
References: <20230722190740.326190-1-tony.luck@intel.com>
 <20230829234426.64421-1-tony.luck@intel.com>
 <20230829234426.64421-4-tony.luck@intel.com>
 <5f1256d3-737e-a447-abbe-f541767b2c8f@intel.com>
 <ZRMnCFWzcxa6Qa4E@agluck-desk3>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <ZRMnCFWzcxa6Qa4E@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UjZKWVlnMzY1dmdxRHUxOXNpYUxra2lzS0pnaTEvYUZ0d2ZpUHNHa1l4QzEy?=
 =?utf-8?B?TktlRUFMK2Vjb1BHM2JhUDlzKzJlNm5UMGdXd1hPTmRSTmNGT2tJZXk5Rldh?=
 =?utf-8?B?ODhEQUtNazFobFhQcDRvakJQRVZqRHBVL1I3Mzc4cUJwb0JOZkRKS3BSdzcx?=
 =?utf-8?B?U1VEd1FlNnQ1b3lQelBjOHd6V01kOFdCUWFER1JadE5pb1Y1VmdDbTdrR09q?=
 =?utf-8?B?MjIwd3J5YkJRdFNPL0FlOVIyZk1yVWZPUGRQMmhHREVONEZJNmFYcU41MXhB?=
 =?utf-8?B?UTk2aWE4TWhEakhIN1dUM3hSWDJQcHpuUVRBVzJaNExEd0xhUkZkTGo0NE1y?=
 =?utf-8?B?L25UR2wrUlNUVmxRWVFpUDRPdHhmYUtwN2FtSnpibUJLYURUTXZaSjBPLzE5?=
 =?utf-8?B?eDFsVHkyaDVQWlNvNDhGUnRibXd5YnQ5YXlYUzQ4YVdBL1JHdWdiZCtKV055?=
 =?utf-8?B?UGRUSkVYaUF3OWFvZml4TlZ0L1c1SWFXbEdjZW4yTk4wVnFCeHREK0ZPN0Uz?=
 =?utf-8?B?NzZKUWg3clh4ZGNYd0ZKUm1lcUNSMVFicVVpdm1SQjYyOUkzK3NLYmc4VWd2?=
 =?utf-8?B?Z0JTZ2ZLWVpqQ05NNGw2czR2b2wwbnhlL3JDNmJ5RjJHWnAzaWUwMUx6VXJs?=
 =?utf-8?B?NFhRUnA3eGtJaFZrUFc0MlNMYXlqNFFmeHVtS3k1WG1yeXRHU3FsWFlBNm5z?=
 =?utf-8?B?SURTSXA4bnJIU3F0SzF4em42aDE1cU5QL0RXdXJ5bnh4cXVGQnZCLzhKWFo2?=
 =?utf-8?B?Wkh2TFl3eFJTVTRqOXdIZW84b0RWZHlkUHhqcVo0cTRRT2N1MzQ4Wnc2Q3Zm?=
 =?utf-8?B?Rm9uaTc5K1Z6Y003dU1XMjFld0lQQ1pDYWI1UEpXTDgvbmYzWWhkM3lYNDl4?=
 =?utf-8?B?N01VRDcrUERmcnJIRFZuLzc1S01IcHJaMTJLMm1iRGE0NnVEd1Z3TkJLRkZE?=
 =?utf-8?B?eUZ0OGlWN3VhUmVUcndjQ09OQ3FLVitqU2pkTXN0ZHE5N0VlR2lKem9NeW5v?=
 =?utf-8?B?eFFzTU5ObUw2MVo1aDg2OWpSQjRrTmovbllGK2Zrb2JkOVpGT2JmSVdJM1Ja?=
 =?utf-8?B?WFVPbHVoTzRsK3c4OXVlQ3lJSUFLL3pEc2tGSitHTE1xa0RIYWVQNTZBM2ZH?=
 =?utf-8?B?a2pySndJaElyMFk3MDM2YncrTDhRUXJOaHpvUVB5RW1XT3lXYjJOcWZYVHhx?=
 =?utf-8?B?ZE9yUlBLM0Y0QWZFWEhXTTZwWDZ0eHBjR3JWbm9iY1JQTEtGQjMxK2lMUmlo?=
 =?utf-8?B?aUI2R0dsei95KzJGQkJ4bmk0ME15QW4yRTV6bmFmTUQ3L0JoMVNZdlE1cXV3?=
 =?utf-8?B?dVd4a1BNWkVGalUrNml2ajdWNk05YUZJZGpJU01mTGZvZWF1R2VQZVFhUUww?=
 =?utf-8?B?OHBwZEdsaFBqV2M0L0dhMnRVZ3JjL1JmU0R1Q2R5VnFiLzZJVjdpSmRzdjlC?=
 =?utf-8?B?cDREVjVqaXdWRW11RGMxVng0dDh2UlZOZ2RJdmNWQzRDaHlJV2JnQTU1eC9J?=
 =?utf-8?B?Nlo2T2ZtR2VVQVVSWXc3dmFqVVJSYkpiOUdCMG5HYUVuRFJxZWVSdXQya3h0?=
 =?utf-8?B?ZUJrRDNtQ3VuWXJYL1AzTnB4cHZIR2xOaHhKcC84dk1xc29nMjNydXl5eVhS?=
 =?utf-8?B?dVBoZDBQTFlJbzQrcktla1M1SWlGTGNSSmNsVjhvUFZMTlBHaWpDY09sMy93?=
 =?utf-8?B?Z1h1cWJCSWppWUZHeHVNcnhLYnc2bktiZ0Z4OXA4dkFFUC85cnJIRHI2amZX?=
 =?utf-8?B?ZlBTMGw4NU5VeXdzRjFYY3o0QmpGenR2WmtlbGRnd2lpN2NsempTaWVRTGxX?=
 =?utf-8?B?RzRYSExqM1BncU15K3hSTGpsZEhpNVV0cFZIdndUcEpoNUk4eHJzYTN5WnNH?=
 =?utf-8?B?UFFWRm1BdVJwMjk1dlBpbWVPQW9qYy9VMytaRlJMN3VSMWNBNUlhZjJ2dDFV?=
 =?utf-8?B?WGhNb1JzdFFQVDZtUkpsbmFUdGxZYWRXZmpFYXp6RlR4bHliUU0vTENWUzY4?=
 =?utf-8?B?d2pJU2Q5VWZ5OFE5SlpmSUZYaDlGM0RXcjdrNjdFdXRpZTdBck53Q2t4anBh?=
 =?utf-8?B?aUxwRWpCbXE4M2hQV0J5TTRUUkdURHpoa2hQbjVIWElveW1ocXk2aER3djIw?=
 =?utf-8?B?L0FBK2ZSakkrRVVLMHVLVXRsTEtKMmJwMXdISy9EVVNQR0lRSkphQWo4QkdO?=
 =?utf-8?B?NGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 67ec9a39-530f-483d-97b1-08dbbedc06a9
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2023 22:01:01.1332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: L/VQaGwDFAfaD0jZtbJaHloMYmvUkHsDAT0La064o3WZVErRc97HXenNaiodP/GOt4FVOEoRiBf4ckbbpmT+f3tXhYCtoPuQzeL9kYYGSy4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5538
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.3 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 26 Sep 2023 17:55:13 -0700 (PDT)

Hi Tony,

On 9/26/2023 11:46 AM, Tony Luck wrote:
> On Mon, Sep 25, 2023 at 04:25:15PM -0700, Reinette Chatre wrote:
>>> +struct rdt_domain {
>>> +	// First three fields must match struct rdt_mondomain below.
>>
>> Please avoid comments within declarations. Even so, could you please
>> elaborate what the above means? Why do the first three fields have to
>> match? I understand there is common code, for example, __rdt_find_domain()
>> that operated on the same members of the two structs but does that
>> require the members be in the same position in the struct?
>> I understand that a comment may be required if position in the struct
>> is important but I cannot see that it is.
> 
> [Just replying to this one point in your message to get guidance. I'll
> address all the rest in other replies]
> 
> I'm wrong about the first *three* fields ... but the first *two* fields
> (the "list" and the "id") do need to be at the same offsets in different
> structures if a common routine is going to be used to access those
> fields.
> 
> If the "id" were at offset 0x10 in the control version of the domain
> structure, and at offset 0x20 in the monitor version of the domain
> structure, there would be no hope for a common routine to access the
> "id" field when searching a list that could be either control or
> monitor domains.
> 
> I'm looking at making this far more explicit with a new patch between
> 0001 and 0002 that pulls the two fields into a common substructure that
> will be included in each of the control and monitor versions of the
> structure.
> 
> Patch included below.
> 
> But this seems like it is a lot of churn to avoid having separate
> functions to search control and monitor lists. Each a clone of
> the existing ~24 line rdt_find_domain() with just the type changed
> for the return value and the list travsersal.

Yes. Sorry, I did not realize this implication during the earlier
discussions.

> 
> What do you think?
> 

It sounds to me as though you are advocating for open coding 
rdt_find_ctrl_domain() and rdt_find_mon_domain()? That sounds good
to me.

Sorry for the noise.

Reinette